You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Rajitha R <ra...@gmail.com> on 2016/11/03 09:10:11 UTC
Re: Review Request 53059: Druid sql rewriter changes
> On Oct. 27, 2016, 12:17 p.m., Rajat Khandelwal wrote:
> > lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java, line 681
> > <https://reviews.apache.org/r/53059/diff/6/?file=1547335#file1547335line681>
> >
> > We need to test for the opposite scenario too, if skip warnings is set to false, is validate/prepare failing?
setting it to false wont be enough. we ll need to get stmt.getwarnings() return non null for coming up with the negative test case
- Rajitha
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53059/#review153996
-----------------------------------------------------------
On Oct. 27, 2016, 10:12 a.m., Rajitha R wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53059/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2016, 10:12 a.m.)
>
>
> Review request for lens and Rajat Khandelwal.
>
>
> Bugs: LENS-1350
> https://issues.apache.org/jira/browse/LENS-1350
>
>
> Repository: lens
>
>
> Description
> -------
>
> Fix for bug : Lens-1350
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 355a1f0
> lens-cube/src/main/java/org/apache/lens/cube/parse/BetweenTimeRangeWriter.java 046149b
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryConfUtil.java f20f105
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestBetweenTimeRangeWriter.java 07852a0
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriter.java 3417031
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/DruidSQLRewriter.java eb1d69c
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 7ce1a97
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriverConfConstants.java f4e0451
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestDruidSQLRewriter.java c4cc91d
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java 6291021
> lens-driver-jdbc/src/test/resources/drivers/jdbc/druid/jdbcdriver-site.xml e4fad23
> src/site/apt/user/cli.apt cf9657a
>
> Diff: https://reviews.apache.org/r/53059/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajitha R
>
>