[GitHub] [pulsar] tisonkun commented on a diff in pull request #18008: [improve][io] JDBC Sink: add flag to exclude non declared fields

[GitBox <gi...@apache.org>]

tisonkun commented on code in PR #18008:
URL: https://github.com/apache/pulsar/pull/18008#discussion_r996844061


##########
pulsar-io/jdbc/core/src/main/java/org/apache/pulsar/io/jdbc/JdbcSinkConfig.java:
##########
@@ -73,6 +73,17 @@ public class JdbcSinkConfig implements Serializable {
             help = "Fields used in where condition of update and delete Events. A comma-separated list."
     )
     private String key;
+
+    @FieldDoc(
+            required = false,
+            defaultValue = "false",
+            help = "All the table fields are discovered automatically. 'excludeNonDeclaredFields' indicates if the "
+                    + "table fields not explicitly listed in `nonKey` and `key` must be included in the query. "
+                    + "By default all the table fields are included. To leverage of table fields defaults "
+                    + "during insertion, it is suggested to set this value to `false`."

Review Comment:
   ```suggestion
                       + "during insertion, it is suggested to set this value to `true`."
   ```
   ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org