You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "tisonkun (via GitHub)" <gi...@apache.org> on 2023/04/01 06:48:45 UTC
[GitHub] [pulsar] tisonkun opened a new pull request, #19991: [fix][build] Client modules should be built with Java 8
tisonkun opened a new pull request, #19991:
URL: https://github.com/apache/pulsar/pull/19991
This fixes #19982.
### Motivation
Client modules are promised to be compatible with Java 8.
### Modifications
Add `--releaase 8` for these two remaining client modules.
### Verifying this change
Locally tested.
Before:
```
file target/classes/org/apache/pulsar/client/impl/auth/AuthenticationAthenz.class
target/classes/org/apache/pulsar/client/impl/auth/AuthenticationAthenz.class: compiled Java class data, version 61.0
```
After:
```
file target/classes/org/apache/pulsar/client/impl/auth/AuthenticationAthenz.class
target/classes/org/apache/pulsar/client/impl/auth/AuthenticationAthenz.class: compiled Java class data, version 52.0 (Java 1.8)
```
I don't know if we can add a CI step to ensure it.
### Does this pull request potentially affect one of the following parts:
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
*If the box was checked, please highlight the changes*
- [ ] Dependencies (add or upgrade a dependency)
- [ ] The public API
- [ ] The schema
- [ ] The default values of configurations
- [ ] The threading model
- [ ] The binary protocol
- [ ] The REST endpoints
- [ ] The admin CLI options
- [ ] The metrics
- [ ] Anything that affects deployment
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
### Matching PR in forked repository
PR in forked repository: <!-- ENTER URL HERE -->
<!--
After opening this PR, the build in apache/pulsar will fail and instructions will
be provided for opening a PR in the PR author's forked repository.
apache/pulsar pull requests should be first tested in your own fork since the
apache/pulsar CI based on GitHub Actions has constrained resources and quota.
GitHub Actions provides separate quota for pull requests that are executed in
a forked repository.
The tests will be run in the forked repository until all PR review comments have
been handled, the tests pass and the PR is approved by a reviewer.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #19991: [fix][build] Client modules should be built with Java 8
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #19991:
URL: https://github.com/apache/pulsar/pull/19991#issuecomment-1492975093
Updated. Please give another look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #19991: [fix][build] Client modules should be built with Java 8
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #19991:
URL: https://github.com/apache/pulsar/pull/19991#issuecomment-1493873410
Hi @Technoboy-! This can be a release blocker to 2.11.1. Since you're the RM for this release, I'd like to let you know this patch and ask if you can cherry-pick it to branch-2.11 and include it in 2.11.1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #19991: [fix][build] Client modules should be built with Java 8
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #19991:
URL: https://github.com/apache/pulsar/pull/19991#issuecomment-1492974767
Hi @lhotari & @eolivelli!
The changeset for updating the broker compiler version is for profile `integration-test-java8`. But I agree I can revert the change as it won't hurt.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli merged pull request #19991: [fix][build] Client modules should be built with Java 8
Posted by "eolivelli (via GitHub)" <gi...@apache.org>.
eolivelli merged PR #19991:
URL: https://github.com/apache/pulsar/pull/19991
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on a diff in pull request #19991: [fix][build] Client modules should be built with Java 8
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on code in PR #19991:
URL: https://github.com/apache/pulsar/pull/19991#discussion_r1155074251
##########
pom.xml:
##########
@@ -1966,8 +1966,8 @@ flexible messaging model and an intuitive client API.</description>
<test.additional.args/>
<maven.compiler.source>8</maven.compiler.source>
<maven.compiler.target>8</maven.compiler.target>
- <pulsar.broker.compiler.release></pulsar.broker.compiler.release>
- <pulsar.client.compiler.release></pulsar.client.compiler.release>
+ <pulsar.broker.compiler.release>8</pulsar.broker.compiler.release>
+ <pulsar.client.compiler.release>8</pulsar.client.compiler.release>
Review Comment:
Aren't these set later by build profiles?
The pulsar.broker.compiler.release should be 17, not 8.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codecov-commenter commented on pull request #19991: [fix][build] Client modules should be built with Java 8
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #19991:
URL: https://github.com/apache/pulsar/pull/19991#issuecomment-1493044570
## [Codecov](https://codecov.io/gh/apache/pulsar/pull/19991?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19991](https://codecov.io/gh/apache/pulsar/pull/19991?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (29f99a8) into [master](https://codecov.io/gh/apache/pulsar/commit/68c10eed7604aa3dcc3a6d8b548575e99b94dca2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (68c10ee) will **decrease** coverage by `0.08%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/pulsar/pull/19991?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #19991 +/- ##
============================================
- Coverage 72.89% 72.82% -0.08%
+ Complexity 31619 31592 -27
============================================
Files 1861 1861
Lines 137356 137362 +6
Branches 15117 15118 +1
============================================
- Hits 100131 100039 -92
- Misses 29271 29366 +95
- Partials 7954 7957 +3
```
| Flag | Coverage Δ | |
|---|---|---|
| inttests | `24.44% <ø> (+<0.01%)` | :arrow_up: |
| systests | `25.00% <ø> (-0.04%)` | :arrow_down: |
| unittests | `72.11% <ø> (-0.07%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 76 files with indirect coverage changes](https://codecov.io/gh/apache/pulsar/pull/19991/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- commented on pull request #19991: [fix][build] Client modules should be built with Java 8
Posted by "Technoboy- (via GitHub)" <gi...@apache.org>.
Technoboy- commented on PR #19991:
URL: https://github.com/apache/pulsar/pull/19991#issuecomment-1493876953
> Hi @Technoboy-! This can be a release blocker to 2.11.1. Since you're the RM for this release, I'd like to let you know this patch and ask if you can cherry-pick it to branch-2.11 and include it in 2.11.1.
Thanks, cherry-picked to branch-2.11.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org