You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/02/17 14:12:56 UTC
[GitHub] [pulsar] lhotari opened a new pull request #14353: [Broker] Improve Jetty configuration to handle backpressure properly
lhotari opened a new pull request #14353:
URL: https://github.com/apache/pulsar/pull/14353
THIS IS A DRAFT. Extension to current PIP-142 related changes in #14320 .
### Motivation
The current Jetty configuration doesn't properly handle backpressure. This is explained in the changes made below.
### Modifications
- make the queue for Jetty's thread pool's bounded and configured with `httpServerThreadPoolQueueSize` setting
- the default is unlimited and doesn't cause backpressure which is desired when the queue grows
- Add `maxHttpServerConnections` setting which limits the number of TCP/IP connections.
- use `maxConcurrentHttpRequests` to configure Jetty's [QoSFilter](https://www.eclipse.org/jetty/javadoc/jetty-9/org/eclipse/jetty/servlets/QoSFilter.html)
- Currently `maxConcurrentHttpRequests` is used to configure accept queue size. This doesn't limit concurrent http requests.
- Add separate setting `httpServerAcceptQueueSize` to configure the accept queue size
- similar proxy changes TBD
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #14353: [Broker] Improve Jetty configuration to handle backpressure properly
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14353:
URL: https://github.com/apache/pulsar/pull/14353#issuecomment-1073147952
The pr had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #14353: [Broker] Improve Jetty configuration to handle backpressure properly
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #14353:
URL: https://github.com/apache/pulsar/pull/14353#issuecomment-1043514435
btw. It would be useful to investigate the use of https://www.eclipse.org/jetty/javadoc/jetty-9/org/eclipse/jetty/servlets/DoSFilter.html for basic DoS protection.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org