You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by "kamalsharma2 (via GitHub)" <gi...@apache.org> on 2023/10/30 05:02:23 UTC
[PR] HIVE-27576: Upgrade to calcite-1.19 [hive]
kamalsharma2 opened a new pull request, #4834:
URL: https://github.com/apache/hive/pull/4834
Backport of [HIVE-21001](https://issues.apache.org/jira/browse/HIVE-21001).
Jira URL : https://issues.apache.org/jira/browse/HIVE-27576
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-27576: Upgrade to calcite-1.19 [hive]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #4834:
URL: https://github.com/apache/hive/pull/4834#issuecomment-1880242761
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Feel free to reach out on the dev@hive.apache.org list if the patch is in need of reviews.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-27576: Upgrade to calcite-1.19 [hive]
Posted by "aturoczy (via GitHub)" <gi...@apache.org>.
aturoczy commented on code in PR #4834:
URL: https://github.com/apache/hive/pull/4834#discussion_r1386534882
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java:
##########
@@ -328,6 +328,9 @@ public Object process(Node nd, Stack<Node> stack, NodeProcessorCtx procCtx,
// Literal decimal
String strVal = expr.getText().substring(0, expr.getText().length() - 2);
return createDecimal(strVal, false);
+ } else if (expr.getText().endsWith("F")) {
Review Comment:
There were no Float checks before?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-27576: Upgrade to calcite-1.19 [hive]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #4834: HIVE-27576: Upgrade to calcite-1.19
URL: https://github.com/apache/hive/pull/4834
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org