[jira] [Commented] (WW-4145) file.ftl in xhtml theme directly references xhtml controlfooter.ftl

["adam brin (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WW-4145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13877685#comment-13877685 ] 

adam brin commented on WW-4145:
-------------------------------

To help clarify for those writing custom themes that extend. If my custom theme extends the controlheader and controlfooter, then in textarea.ftl, I need to change:
{code:title=original in textarea.ftl}
<#include "/${parameters.templateDir}/${parameters.theme}/controlheader.ftl" />
<#include "/${parameters.templateDir}/simple/textarea.ftl" />
<#include "/${parameters.templateDir}/${parameters.theme}/controlfooter.ftl" />
{code}

<b>should be rewritten as</b>
{code:title:new in textarea.ftl}
<#include "/${parameters.templateDir}/${parameters.expandTheme}/controlheader.ftl" />
<#include "/${parameters.templateDir}/simple/textarea.ftl" />
<#include "/${parameters.templateDir}/${parameters.expandTheme}/controlfooter.ftl" />
{code}

so that textarea.ftl is pulled from simple, but the custom controlheader.ftl and controlfooter.ftl are used?

> file.ftl in xhtml theme directly references xhtml controlfooter.ftl
> -------------------------------------------------------------------
>
>                 Key: WW-4145
>                 URL: https://issues.apache.org/jira/browse/WW-4145
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Other
>    Affects Versions: 2.3.15.1
>            Reporter: Jasper Rosenberg
>            Assignee: Lukasz Lenart
>              Labels: freemarker, tags, xhtml
>             Fix For: 2.3.16
>
>         Attachments: ThemeExpansion-Alt.patch, ThemeExpansion.patch
>
>
> Should use $\{parameters.theme} instead so can be used in theme extension.
> {code}
> <#include "/${parameters.templateDir}/${parameters.theme}/controlheader.ftl" />
> <#include "/${parameters.templateDir}/simple/file.ftl" />
> <#include "/${parameters.templateDir}/${parameters.theme}/controlfooter.ftl" />
> {code}



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)