You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by "izveigor (via GitHub)" <gi...@apache.org> on 2023/02/24 16:28:21 UTC

[GitHub] [incubator-devlake] izveigor opened a new pull request, #4520: Fixed the issue #4519

izveigor opened a new pull request, #4520:
URL: https://github.com/apache/incubator-devlake/pull/4520

   ### ⚠️ Pre Checklist
   
   > Please complete _ALL_ items in this checklist, and remove before submitting
   
   - [ ] I have read through the [Contributing Documentation](https://devlake.apache.org/community/).
   - [ ] I have added relevant tests.
   - [ ] I have added relevant documentation.
   - [ ] I will add labels to the PR, such as `pr-type/bug-fix`, `pr-type/feature-development`, etc.
   
   <!--
   Thanks for submitting a pull request!
   
   We appreciate you spending the time to work on these changes.
   Please fill out as many sections below as possible.
   -->
   
   ### Summary
   Fixing the issue #4519
   
   ### Does this close any open issues?
   Closes #4519
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] mindlesscloud merged pull request #4520: fix: the length of the column

Posted by "mindlesscloud (via GitHub)" <gi...@apache.org>.
mindlesscloud merged PR #4520:
URL: https://github.com/apache/incubator-devlake/pull/4520


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] mindlesscloud commented on pull request #4520: Fixed the issue #4519

Posted by "mindlesscloud (via GitHub)" <gi...@apache.org>.
mindlesscloud commented on PR #4520:
URL: https://github.com/apache/incubator-devlake/pull/4520#issuecomment-1446272605

   Thanks for your valuable contribution. We did neglect to check the length of the column names. According to the following docs, the length limitation for the column name is 64 for MySQL and 63 for PostgreSQL. 50 might be a safe and sufficient number to adopt. Would you mind modifying the number in your code? 
   
   https://dev.mysql.com/doc/refman/8.0/en/identifier-length.html
   https://www.postgresql.org/docs/current/limits.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org