You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by Robert Munteanu <ro...@apache.org> on 2023/02/07 09:31:06 UTC
Intent to release Feature Model (and friends) 2.0.0, CP Converter 1.3.0, maybe others
Hi,
I want to cut a CP Converter release, and that requires that I also
release some feature model artifacts (and maybe others affected touched
with SLING-11718 [1] ).
If all testing goes well, I will start the release votes tomorrow.
If anyone has any concerns, please let me know.
Thanks,
Robert
[1]: https://issues.apache.org/jira/browse/SLING-11718
Re: Intent to release Feature Model (and friends) 2.0.0, CP Converter 1.3.0, maybe others
Posted by Robert Munteanu <ro...@apache.org>.
On Wed, 2023-02-08 at 14:32 +0100, Konrad Windszus wrote:
> There is more work unfortunately. Also the implementation inside
> cp2fm needs to deal with the new statements.
> Maybe adding to the readme which version of repoinit language is
> supported is sufficient for now.
Create a PR, I will start work on the releases shortly, we don't need
the README updated within the release artifacts.
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/156
Thanks,
Robert
>
> > On 8. Feb 2023, at 14:17, Robert Munteanu <ro...@apache.org>
> > wrote:
> >
> > On Wed, 2023-02-08 at 12:15 +0100, Konrad Windszus wrote:
> > > IIUC then using the new repoinit statements will make the
> > > cpconverter
> > > throw an exception.
> > > That makes it pretty critical for me.
> > > Otherwise we should clearly indicate the non-compatibility with
> > > newer
> > > versions of repoinit somewhere.
> >
> > Yes, that is my understanding as well. I don't think it's terribly
> > problematic to not support the new statements yet, as we can always
> > cut
> > a release later on.
> >
> > If all that is needed is to get repoinit dependencies updated for
> > the
> > cpconverter, I can do that.
> >
> > For more work I suggest we defer this to the next release.
> >
> > Thanks,
> > Robert
>
Re: Intent to release Feature Model (and friends) 2.0.0, CP Converter 1.3.0, maybe others
Posted by Konrad Windszus <ko...@gmx.de>.
There is more work unfortunately. Also the implementation inside cp2fm needs to deal with the new statements.
Maybe adding to the readme which version of repoinit language is supported is sufficient for now.
> On 8. Feb 2023, at 14:17, Robert Munteanu <ro...@apache.org> wrote:
>
> On Wed, 2023-02-08 at 12:15 +0100, Konrad Windszus wrote:
>> IIUC then using the new repoinit statements will make the cpconverter
>> throw an exception.
>> That makes it pretty critical for me.
>> Otherwise we should clearly indicate the non-compatibility with newer
>> versions of repoinit somewhere.
>
> Yes, that is my understanding as well. I don't think it's terribly
> problematic to not support the new statements yet, as we can always cut
> a release later on.
>
> If all that is needed is to get repoinit dependencies updated for the
> cpconverter, I can do that.
>
> For more work I suggest we defer this to the next release.
>
> Thanks,
> Robert
Re: Intent to release Feature Model (and friends) 2.0.0, CP Converter 1.3.0, maybe others
Posted by Robert Munteanu <ro...@apache.org>.
On Wed, 2023-02-08 at 12:15 +0100, Konrad Windszus wrote:
> IIUC then using the new repoinit statements will make the cpconverter
> throw an exception.
> That makes it pretty critical for me.
> Otherwise we should clearly indicate the non-compatibility with newer
> versions of repoinit somewhere.
Yes, that is my understanding as well. I don't think it's terribly
problematic to not support the new statements yet, as we can always cut
a release later on.
If all that is needed is to get repoinit dependencies updated for the
cpconverter, I can do that.
For more work I suggest we defer this to the next release.
Thanks,
Robert
Re: Intent to release Feature Model (and friends) 2.0.0, CP Converter 1.3.0, maybe others
Posted by Konrad Windszus <kw...@apache.org>.
IIUC then using the new repoinit statements will make the cpconverter throw an exception.
That makes it pretty critical for me.
Otherwise we should clearly indicate the non-compatibility with newer versions of repoinit somewhere.
Maybe Angela can chime in to indicate if really all repoinit scripts are parsed and rewritten by cp2fm because I don’t know the details there.
Konrad
> On 8. Feb 2023, at 10:53, Robert Munteanu <ro...@apache.org> wrote:
>
> Hi Konrad,
>
> On Tue, 2023-02-07 at 11:09 +0100, Konrad Windszus wrote:
>> Probably
>> https://issues.apache.org/jira/browse/SLING-11750 <https://issues.apache.org/jira/browse/SLING-11750
>>> would be easy to integrate. Also as long as the new statements are
>> only parsed but not generated this is also 100% backwards compatible.
>> Won’t have time to look into this this week, though.
>> Konrad
>>
>
> Thanks for bringing this up. I also won't have time to look into it for
> the next release, and since it's a new feature I assume it won't be a
> problem.
>
> Thanks,
> Robert
>
>
>>> On 7. Feb 2023, at 10:31, Robert Munteanu <ro...@apache.org>
>>> wrote:
>>>
>>> Hi,
>>>
>>> I want to cut a CP Converter release, and that requires that I also
>>> release some feature model artifacts (and maybe others affected
>>> touched
>>> with SLING-11718 [1] ).
>>>
>>> If all testing goes well, I will start the release votes tomorrow.
>>>
>>> If anyone has any concerns, please let me know.
>>>
>>> Thanks,
>>> Robert
>>>
>>> [1]: https://issues.apache.org/jira/browse/SLING-11718
>>
>
Re: Intent to release Feature Model (and friends) 2.0.0, CP Converter 1.3.0, maybe others
Posted by Robert Munteanu <ro...@apache.org>.
Hi Konrad,
On Tue, 2023-02-07 at 11:09 +0100, Konrad Windszus wrote:
> Probably
> https://issues.apache.org/jira/browse/SLING-11750 <https://issues.apache.org/jira/browse/SLING-11750
> > would be easy to integrate. Also as long as the new statements are
> only parsed but not generated this is also 100% backwards compatible.
> Won’t have time to look into this this week, though.
> Konrad
>
Thanks for bringing this up. I also won't have time to look into it for
the next release, and since it's a new feature I assume it won't be a
problem.
Thanks,
Robert
> > On 7. Feb 2023, at 10:31, Robert Munteanu <ro...@apache.org>
> > wrote:
> >
> > Hi,
> >
> > I want to cut a CP Converter release, and that requires that I also
> > release some feature model artifacts (and maybe others affected
> > touched
> > with SLING-11718 [1] ).
> >
> > If all testing goes well, I will start the release votes tomorrow.
> >
> > If anyone has any concerns, please let me know.
> >
> > Thanks,
> > Robert
> >
> > [1]: https://issues.apache.org/jira/browse/SLING-11718
>
Re: Intent to release Feature Model (and friends) 2.0.0, CP Converter 1.3.0, maybe others
Posted by Konrad Windszus <kw...@apache.org>.
Probably https://issues.apache.org/jira/browse/SLING-11750 <https://issues.apache.org/jira/browse/SLING-11750> would be easy to integrate. Also as long as the new statements are only parsed but not generated this is also 100% backwards compatible.
Won’t have time to look into this this week, though.
Konrad
> On 7. Feb 2023, at 10:31, Robert Munteanu <ro...@apache.org> wrote:
>
> Hi,
>
> I want to cut a CP Converter release, and that requires that I also
> release some feature model artifacts (and maybe others affected touched
> with SLING-11718 [1] ).
>
> If all testing goes well, I will start the release votes tomorrow.
>
> If anyone has any concerns, please let me know.
>
> Thanks,
> Robert
>
> [1]: https://issues.apache.org/jira/browse/SLING-11718