You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by yao lei <le...@163.com> on 2017/05/09 09:49:29 UTC
Review Request 59085: RBAC: Service Operator/Administrator Role don't
have
HOST.ADD_DELETE_COMPONENTS permission so we 'd better hide relevant buttons
on Web UI
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59085/
-----------------------------------------------------------
Review request for Ambari, Alexandr Antonenko, Robert Levas, and Richard Zang.
Bugs: AMBARI-20961
https://issues.apache.org/jira/browse/AMBARI-20961
Repository: ambari
Description
-------
Steps to reproduce:
1.Create a user named test and assign Service Operator(Administrator) Role to this user.
2.Login with this user and open Services -> Hive -> Service Actions, the menu include highlight items : Add Hive Metastore and Add HiveServer2.
Zookeeper,Hbase and other service also have the above issue.
Because Service Operator(Administrator) Role don't have HOST.ADD_DELETE_COMPONENTS permission at all , we 'd better hide these buttons
Diffs
-----
ambari-web/app/views/main/service/item.js ac736a6
Diff: https://reviews.apache.org/r/59085/diff/1/
Testing
-------
1.Create five users: test1 ,test2 ,test3 ,test4 ,test5
2.Assign role Cluster User to test1?
Service Operator to test2?
Service Administrator to test3?
Cluster Operator to test4?
Cluster Administrator to test5
3.Login with above users in sequence and find items of Service Actions shown as expected
Thanks,
yao lei
Re: Review Request 59085: RBAC: Service Operator/Administrator Role
don't
have HOST.ADD_DELETE_COMPONENTS permission so we 'd better hide relevant
buttons on Web UI
Posted by yao lei <le...@163.com>.
> On 五月 9, 2017, 3:10 p.m., Robert Levas wrote:
> > Ship It!
Thanks for your review
- yao
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59085/#review174319
-----------------------------------------------------------
On 五月 9, 2017, 9:49 a.m., yao lei wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59085/
> -----------------------------------------------------------
>
> (Updated 五月 9, 2017, 9:49 a.m.)
>
>
> Review request for Ambari, Alexandr Antonenko, Robert Levas, and Richard Zang.
>
>
> Bugs: AMBARI-20961
> https://issues.apache.org/jira/browse/AMBARI-20961
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Steps to reproduce:
> 1.Create a user named test and assign Service Operator(Administrator) Role to this user.
> 2.Login with this user and open Services -> Hive -> Service Actions, the menu include highlight items : Add Hive Metastore and Add HiveServer2.
> Zookeeper,Hbase and other service also have the above issue.
>
> Because Service Operator(Administrator) Role don't have HOST.ADD_DELETE_COMPONENTS permission at all , we 'd better hide these buttons
>
>
> Diffs
> -----
>
> ambari-web/app/views/main/service/item.js ac736a6
>
>
> Diff: https://reviews.apache.org/r/59085/diff/2/
>
>
> Testing
> -------
>
> 1.Create five users: test1 ,test2 ,test3 ,test4 ,test5
> 2.Assign role Cluster User to test1,
> Service Operator to test2,
> Service Administrator to test3,
> Cluster Operator to test4,
> Cluster Administrator to test5
> 3.Login with above users in sequence and find items of Service Actions shown as expected
>
>
> Thanks,
>
> yao lei
>
>
Re: Review Request 59085: RBAC: Service Operator/Administrator Role
don't
have HOST.ADD_DELETE_COMPONENTS permission so we 'd better hide relevant
buttons on Web UI
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59085/#review174319
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Levas
On May 9, 2017, 5:49 a.m., yao lei wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59085/
> -----------------------------------------------------------
>
> (Updated May 9, 2017, 5:49 a.m.)
>
>
> Review request for Ambari, Alexandr Antonenko, Robert Levas, and Richard Zang.
>
>
> Bugs: AMBARI-20961
> https://issues.apache.org/jira/browse/AMBARI-20961
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Steps to reproduce:
> 1.Create a user named test and assign Service Operator(Administrator) Role to this user.
> 2.Login with this user and open Services -> Hive -> Service Actions, the menu include highlight items : Add Hive Metastore and Add HiveServer2.
> Zookeeper,Hbase and other service also have the above issue.
>
> Because Service Operator(Administrator) Role don't have HOST.ADD_DELETE_COMPONENTS permission at all , we 'd better hide these buttons
>
>
> Diffs
> -----
>
> ambari-web/app/views/main/service/item.js ac736a6
>
>
> Diff: https://reviews.apache.org/r/59085/diff/2/
>
>
> Testing
> -------
>
> 1.Create five users: test1 ,test2 ,test3 ,test4 ,test5
> 2.Assign role Cluster User to test1,
> Service Operator to test2,
> Service Administrator to test3,
> Cluster Operator to test4,
> Cluster Administrator to test5
> 3.Login with above users in sequence and find items of Service Actions shown as expected
>
>
> Thanks,
>
> yao lei
>
>