You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by mattf <gi...@git.apache.org> on 2014/09/06 16:27:57 UTC
[GitHub] spark pull request: [SPARK-1701] remove unnecessary use of numSlic...
GitHub user mattf opened a pull request:
https://github.com/apache/spark/pull/2303
[SPARK-1701] remove unnecessary use of numSlices from pyspark tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mattf/spark SPARK-1701-pyspark-remove-numSlices
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/2303.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2303
----
commit 0883e681429c07ea94858573b2ca3370657c82bb
Author: Matthew Farrellee <ma...@redhat.com>
Date: 2014-09-06T14:25:50Z
[SPARK-1701] remove unnecessary use of numSlices from pyspark tests
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-1701] remove unnecessary use of numSlic...
Posted by mattf <gi...@git.apache.org>.
Github user mattf commented on the pull request:
https://github.com/apache/spark/pull/2303#issuecomment-54716879
@JoshRosen only #2299 is truly for SPARK-1701, the others are tangentially related so i tagged them along with 1701, but they can all stand alone. my hope is that the reviews can move forward independently as distinct units.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-1701] remove unnecessary use of numSlic...
Posted by mattf <gi...@git.apache.org>.
Github user mattf commented on the pull request:
https://github.com/apache/spark/pull/2303#issuecomment-54723343
> Was your intent for us to merge / backport only the documentation fixes?
fyi, there is no urgency on my side for any of these
yes, my read of SPARK-1701 is that it's a documentation issue, so #2299 should be merged for it.
as for #2302, #2303, #2304, my hope is they're small and can be filler PRs when y'all have time for them. they're not really valid in the context of SPARK-1701, since they're not just documentation.
i apologize for mudding SPARK-1701 by associating 2302-4, it was more a stream of my cosciousness than a set of things that should be included w/ SPARK-1701. i'll clean them up.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-1701] remove unnecessary use of numSlic...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2303#issuecomment-54715939
[QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19914/consoleFull) for PR 2303 at commit [`0883e68`](https://github.com/apache/spark/commit/0883e681429c07ea94858573b2ca3370657c82bb).
* This patch **passes** unit tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-1701] remove unnecessary use of numSlic...
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/2303#issuecomment-54718542
I'd still like for these to be combined into a single PR. Each additional PR means another run of Jenkins tests, another commit message, another round of emails / entry in our [PR tracker](http://spark-prs.appspot.com/); this adds up to be a lot more work for us (there's a large backlog of pull requests that we're making good progress in reviewing and merging).
Sometimes there are very good reasons to split up a PR. For example, the recent TorrentBroadcast improvements are being performed as a series of multiple PRs, but I that's okay because those PRs are much larger units of functionality (e.g. hundreds of lines, instead of < 10) which we might want to merge and backport separately.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-1701] remove unnecessary use of numSlic...
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/2303#issuecomment-54716695
Hi @mattf,
It looks like you've opened four separate PRS (#2299, #2303, #2302, #2304) for SPARK-1701. Since these all deal with the same JIRA, can you please close all of these and re-open a single PR that contains all of these commits? Four separate PRs for such a small feature makes this much harder for us to review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-1701] remove unnecessary use of numSlic...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2303#issuecomment-54714147
[QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19914/consoleFull) for PR 2303 at commit [`0883e68`](https://github.com/apache/spark/commit/0883e681429c07ea94858573b2ca3370657c82bb).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-1701] remove unnecessary use of numSlic...
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/2303#issuecomment-54719377
Was your intent for us to merge / backport only the documentation fixes?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-1701] remove unnecessary use of numSlic...
Posted by mattf <gi...@git.apache.org>.
Github user mattf closed the pull request at:
https://github.com/apache/spark/pull/2303
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org