You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@helix.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/04/16 17:13:00 UTC
[jira] [Commented] (HELIX-695) Add Helix Manager listener for new
connection notification
[ https://issues.apache.org/jira/browse/HELIX-695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16439730#comment-16439730 ]
ASF GitHub Bot commented on HELIX-695:
--------------------------------------
GitHub user zhan849 opened a pull request:
https://github.com/apache/helix/pull/182
[HELIX-695] add helix manager listener for new connection notification
In this PR I added invocation and related tests of `stateListener.onConnected()` method in ZkHelixManager when it is connected.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhan849/helix harry/helix-manager-onconnected
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/helix/pull/182.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #182
----
commit 65e84713503437c542e545a2222bd521c2ba6d26
Author: Harry Zhang <zh...@...>
Date: 2018-04-16T17:05:30Z
[HELIX-695] add helix manager listener for new connection notification
----
> Add Helix Manager listener for new connection notification
> ----------------------------------------------------------
>
> Key: HELIX-695
> URL: https://issues.apache.org/jira/browse/HELIX-695
> Project: Apache Helix
> Issue Type: Task
> Reporter: Hao Zhang
> Priority: Major
>
> Currently HelixManager is not notifying state listener about connection establishment. Adding this notification is useful since HelixManager supports get ZkClient method and when connection is re-established, ZkClient is newly created and users who used get method to extract client should be notified and refresh their client.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)