You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@curator.apache.org by "tisonkun (via GitHub)" <gi...@apache.org> on 2023/05/18 01:54:04 UTC
[GitHub] [curator] tisonkun opened a new pull request, #463: CURATOR-XXX. Apply code style with spotless
tisonkun opened a new pull request, #463:
URL: https://github.com/apache/curator/pull/463
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [curator] tisonkun commented on pull request #463: CURATOR-674. Apply code style with spotless
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #463:
URL: https://github.com/apache/curator/pull/463#issuecomment-1572217614
Updated. PTAL @kezhuw @cammckenzie @eolivelli
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [curator] kezhuw commented on pull request #463: CURATOR-674. Apply code style with spotless
Posted by "kezhuw (via GitHub)" <gi...@apache.org>.
kezhuw commented on PR #463:
URL: https://github.com/apache/curator/pull/463#issuecomment-1572974635
I replayed this.
1. git fetch origin
2. gh pr checkout -f 463
3. git reset --hard d8c8bc38c682fa674617907f8fe3112947e8bdf0
4. git rebase origin/master
5. ./mvnw spotless:apply
6. git diff 236d49fc888c6897164419115b69a4bf4f57688d
The final step gives no output and `echo $?` outputs `0`. So I am confident about the remains.
Look forward for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [curator] tisonkun commented on pull request #463: CURATOR-674. Apply code style with spotless
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #463:
URL: https://github.com/apache/curator/pull/463#issuecomment-1573332799
Merging...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [curator] tisonkun merged pull request #463: CURATOR-674. Apply code style with spotless
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun merged PR #463:
URL: https://github.com/apache/curator/pull/463
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [curator] kezhuw commented on a diff in pull request #463: CURATOR-674. Apply code style with spotless
Posted by "kezhuw (via GitHub)" <gi...@apache.org>.
kezhuw commented on code in PR #463:
URL: https://github.com/apache/curator/pull/463#discussion_r1213393217
##########
pom.xml:
##########
@@ -985,6 +992,29 @@
<artifactId>maven-dependency-plugin</artifactId>
<version>${maven-dependency-plugin-version}</version>
</plugin>
+
+ <plugin>
+ <groupId>com.diffplug.spotless</groupId>
+ <artifactId>spotless-maven-plugin</artifactId>
+ <configuration>
+ <java>
+ <palantirJavaFormat>
+ <version>2.30.0</version>
Review Comment:
Add to "properties" tag ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [curator] tisonkun commented on a diff in pull request #463: CURATOR-674. Apply code style with spotless
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #463:
URL: https://github.com/apache/curator/pull/463#discussion_r1213799292
##########
pom.xml:
##########
@@ -985,6 +992,29 @@
<artifactId>maven-dependency-plugin</artifactId>
<version>${maven-dependency-plugin-version}</version>
</plugin>
+
+ <plugin>
+ <groupId>com.diffplug.spotless</groupId>
+ <artifactId>spotless-maven-plugin</artifactId>
+ <configuration>
+ <java>
+ <palantirJavaFormat>
+ <version>2.30.0</version>
Review Comment:
Make sense. As this PR already touch a large range of code. I tend to postpone this suggestion after we merge this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [curator] tisonkun commented on pull request #463: CURATOR-674. Apply code style with spotless
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #463:
URL: https://github.com/apache/curator/pull/463#issuecomment-1573006147
As we agree on the mailing list already, I'll merge this patch in hours.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org