You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by br...@apache.org on 2009/05/18 03:15:18 UTC

svn commit: r775789 - in /maven/resources/trunk/apache-source-release-assembly-descriptor: ./ pom.xml src/ src/main/ src/main/resources/ src/main/resources/assemblies/ src/main/resources/assemblies/source-release.xml

Author: brianf
Date: Mon May 18 01:15:18 2009
New Revision: 775789

URL: http://svn.apache.org/viewvc?rev=775789&view=rev
Log:
add new component to hold the asf specific source descriptor

Added:
    maven/resources/trunk/apache-source-release-assembly-descriptor/
    maven/resources/trunk/apache-source-release-assembly-descriptor/pom.xml
      - copied, changed from r775784, maven/resources/trunk/apache-license-header-resource-bundle/pom.xml
    maven/resources/trunk/apache-source-release-assembly-descriptor/src/
    maven/resources/trunk/apache-source-release-assembly-descriptor/src/main/
    maven/resources/trunk/apache-source-release-assembly-descriptor/src/main/resources/
    maven/resources/trunk/apache-source-release-assembly-descriptor/src/main/resources/assemblies/
    maven/resources/trunk/apache-source-release-assembly-descriptor/src/main/resources/assemblies/source-release.xml

Copied: maven/resources/trunk/apache-source-release-assembly-descriptor/pom.xml (from r775784, maven/resources/trunk/apache-license-header-resource-bundle/pom.xml)
URL: http://svn.apache.org/viewvc/maven/resources/trunk/apache-source-release-assembly-descriptor/pom.xml?p2=maven/resources/trunk/apache-source-release-assembly-descriptor/pom.xml&p1=maven/resources/trunk/apache-license-header-resource-bundle/pom.xml&r1=775784&r2=775789&rev=775789&view=diff
==============================================================================
--- maven/resources/trunk/apache-license-header-resource-bundle/pom.xml (original)
+++ maven/resources/trunk/apache-source-release-assembly-descriptor/pom.xml Mon May 18 01:15:18 2009
@@ -29,11 +29,11 @@
     <relativePath>../pom.xml</relativePath>
   </parent>
 
-  <artifactId>apache-license-header-resource-bundle</artifactId>
-  <version>1.2-SNAPSHOT</version>
+  <artifactId>apache-source-release-assembly-descriptor</artifactId>
+  <version>1.0-SNAPSHOT</version>
 
-  <name>Apache License Header Resource Bundle</name>
+  <name>Apache Source Release Assembly Descriptor</name>
   <description>
-    An archive which contains the notice file template.
+    This jar contains a customized source assembly descriptor to produce Apache compliant source bundles.
   </description>
 </project>

Added: maven/resources/trunk/apache-source-release-assembly-descriptor/src/main/resources/assemblies/source-release.xml
URL: http://svn.apache.org/viewvc/maven/resources/trunk/apache-source-release-assembly-descriptor/src/main/resources/assemblies/source-release.xml?rev=775789&view=auto
==============================================================================
--- maven/resources/trunk/apache-source-release-assembly-descriptor/src/main/resources/assemblies/source-release.xml (added)
+++ maven/resources/trunk/apache-source-release-assembly-descriptor/src/main/resources/assemblies/source-release.xml Mon May 18 01:15:18 2009
@@ -0,0 +1,36 @@
+<?xml version='1.0' encoding='UTF-8'?>
+<!--
+  Licensed to the Apache Software Foundation (ASF) under one
+  or more contributor license agreements.  See the NOTICE file
+  distributed with this work for additional information
+  regarding copyright ownership.  The ASF licenses this file
+  to you under the Apache License, Version 2.0 (the
+  "License"); you may not use this file except in compliance
+  with the License.  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+  Unless required by applicable law or agreed to in writing,
+  software distributed under the License is distributed on an
+  "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+  KIND, either express or implied.  See the License for the
+  specific language governing permissions and limitations
+  under the License.
+-->
+
+<assembly>
+  <id>source-release</id>
+  <formats>
+    <format>tar.gz</format>
+    <format>zip</format>
+  </formats>
+  <fileSets>
+    <fileSet>
+      <directory>${project.basedir}</directory>
+      <useDefaultExcludes>true</useDefaultExcludes>
+      <excludes>
+        <exclude>**/${project.build.directory}/**</exclude>
+      </excludes>
+    </fileSet>
+  </fileSets>
+</assembly>



Re: svn commit: r775789 - in /maven/resources/trunk/apache-source-release-assembly-descriptor: ./ pom.xml src/ src/main/ src/main/resources/ src/main/resources/assemblies/ src/main/resources/assemblies/source-release.xml

Posted by Brian Fox <br...@infinity.nu>.
That was the bug i mentioned that needs to be fixed first ;-)

The excludes will only work for the current project, not all child projects
if they weren't already clean. Since my intents is to insert this into the
release profile, I should be able to make it work pretty reliably. I'm
concerned about adding **/target/** though since if a child project includes
a target folder somewhere in the src, it would be excluded as well.

On Mon, May 18, 2009 at 9:17 AM, Brett Porter <br...@apache.org> wrote:

>
> On 18/05/2009, at 3:56 PM, Benjamin Bentmann wrote:
>
>  Hi Brian,
>>
>>  Author: brianf
>>> Date: Mon May 18 01:15:18 2009
>>> New Revision: 775789
>>> URL: http://svn.apache.org/viewvc?rev=775789&view=rev
>>> Log:
>>> add new component to hold the asf specific source descriptor
>>> +<assembly>
>>> +  <id>source-release</id>
>>> +  <formats>
>>> +    <format>tar.gz</format>
>>> +    <format>zip</format>
>>> +  </formats>
>>> +  <fileSets>
>>> +    <fileSet>
>>> +      <directory>${project.basedir}</directory>
>>> +      <useDefaultExcludes>true</useDefaultExcludes>
>>> +      <excludes>
>>> +        <exclude>**/${project.build.directory}/**</exclude>
>>> +      </excludes>
>>>
>>
>> Is this <exclude> working reliably? AFAIK, include/exclude patterns are
>> usually relative to the fileset's base directory but
>> ${project.build.directory} could resolve to an absolute path, couldn't it?
>>
>
>
> I checked with 2.2-beta-3 and it doesn't behave correctly (it is always an
> absolute path), and fails trying to include the tarball itself from target.
> Does it require a more recent assembly plugin change?
>
> - Brett
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>

Re: svn commit: r775789 - in /maven/resources/trunk/apache-source-release-assembly-descriptor: ./ pom.xml src/ src/main/ src/main/resources/ src/main/resources/assemblies/ src/main/resources/assemblies/source-release.xml

Posted by Brett Porter <br...@apache.org>.
On 18/05/2009, at 3:56 PM, Benjamin Bentmann wrote:

> Hi Brian,
>
>> Author: brianf
>> Date: Mon May 18 01:15:18 2009
>> New Revision: 775789
>> URL: http://svn.apache.org/viewvc?rev=775789&view=rev
>> Log:
>> add new component to hold the asf specific source descriptor
>> +<assembly>
>> +  <id>source-release</id>
>> +  <formats>
>> +    <format>tar.gz</format>
>> +    <format>zip</format>
>> +  </formats>
>> +  <fileSets>
>> +    <fileSet>
>> +      <directory>${project.basedir}</directory>
>> +      <useDefaultExcludes>true</useDefaultExcludes>
>> +      <excludes>
>> +        <exclude>**/${project.build.directory}/**</exclude>
>> +      </excludes>
>
> Is this <exclude> working reliably? AFAIK, include/exclude patterns  
> are usually relative to the fileset's base directory but $ 
> {project.build.directory} could resolve to an absolute path,  
> couldn't it?


I checked with 2.2-beta-3 and it doesn't behave correctly (it is  
always an absolute path), and fails trying to include the tarball  
itself from target. Does it require a more recent assembly plugin  
change?

- Brett


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: svn commit: r775789 - in /maven/resources/trunk/apache-source-release-assembly-descriptor: ./ pom.xml src/ src/main/ src/main/resources/ src/main/resources/assemblies/ src/main/resources/assemblies/source-release.xml

Posted by Benjamin Bentmann <be...@udo.edu>.
Hi Brian,

> Author: brianf
> Date: Mon May 18 01:15:18 2009
> New Revision: 775789
> 
> URL: http://svn.apache.org/viewvc?rev=775789&view=rev
> Log:
> add new component to hold the asf specific source descriptor
> 
> +<assembly>
> +  <id>source-release</id>
> +  <formats>
> +    <format>tar.gz</format>
> +    <format>zip</format>
> +  </formats>
> +  <fileSets>
> +    <fileSet>
> +      <directory>${project.basedir}</directory>
> +      <useDefaultExcludes>true</useDefaultExcludes>
> +      <excludes>
> +        <exclude>**/${project.build.directory}/**</exclude>
> +      </excludes>

Is this <exclude> working reliably? AFAIK, include/exclude patterns are 
usually relative to the fileset's base directory but 
${project.build.directory} could resolve to an absolute path, couldn't it?


Benjamin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org