You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/07/27 01:26:14 UTC

[GitHub] [iotdb] SteveYurongSu commented on a change in pull request #3614: [IOTDB-1524] Support SELECT ... INTO ... clause

SteveYurongSu commented on a change in pull request #3614:
URL: https://github.com/apache/iotdb/pull/3614#discussion_r677049396



##########
File path: server/src/main/java/org/apache/iotdb/db/qp/physical/PhysicalPlan.java
##########
@@ -170,7 +175,7 @@ public void serialize(ByteBuffer buffer) {
    *
    * @param buffer
    */
-  public void deserialize(ByteBuffer buffer) throws IllegalPathException {
+  public void deserialize(ByteBuffer buffer) throws IllegalPathException, IOException {

Review comment:
       ![image](https://user-images.githubusercontent.com/30497621/127079991-1b0a08ac-dd3e-4058-b834-2a9cd6faca89.png)
   
   IOException may be thrown by `SelectIntoPlan#deserialize`. To be specific, it may be thrown by `queryPlan = (QueryPlan) Factory.create(buffer);`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org