You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2017/09/05 20:22:00 UTC
[jira] [Commented] (JCLOUDS-1332)
BaseComputeService.destroyNodesMatching and BaseComputeService.destroyNode
different behavior
[ https://issues.apache.org/jira/browse/JCLOUDS-1332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154234#comment-16154234 ]
ASF subversion and git services commented on JCLOUDS-1332:
----------------------------------------------------------
Commit af4bd3a86b964c53e31a568221cc5ad08da35615 in jclouds's branch refs/heads/master from [~andreaturli]
[ https://git-wip-us.apache.org/repos/asf?p=jclouds.git;h=af4bd3a ]
[JCLOUDS-1332] destroyNode and destroyNodesMatchingPredicate different semantic
- modify BaseComputeService to make the 2 operations more similar
- remove overridden destroyNode and destroyNodesMatching from GoogleComputeEngineService
> BaseComputeService.destroyNodesMatching and BaseComputeService.destroyNode different behavior
> ---------------------------------------------------------------------------------------------
>
> Key: JCLOUDS-1332
> URL: https://issues.apache.org/jira/browse/JCLOUDS-1332
> Project: jclouds
> Issue Type: Bug
> Components: jclouds-compute
> Affects Versions: 2.0.1, 2.0.2
> Reporter: Andrea Turli
> Assignee: Andrea Turli
> Priority: Critical
> Fix For: 2.1.0, 2.0.3
>
>
> DestroyNode doesn't clean up incidental resources as the destroyNodesMatching does.
> In fact, nodeTerminate.apply(node) has a side-effect and set node=null
> Potential fixes:
> - return `md` instead of node.get
> or
> - TrueIfNullOrDeletedRefreshAndDoubleCheckOnFalse predicate to return true when `refreshOrNull` return null
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)