You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@dubbo.apache.org by "chickenlj (GitHub)" <gi...@apache.org> on 2020/01/09 08:33:55 UTC

[GitHub] [dubbo] chickenlj opened pull request #5613: Reduce memory allocation during address change notification.

1. Merge registry notification events happened in a certain short interval.
2. cache URL instances to reduce string -> URL recreation
3. reduce allocation during export and refer at start up.
4. add frozen status for URL
5. use URLBuilder for unfrozen URLs

[ Full content available at: https://github.com/apache/dubbo/pull/5613 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo] LinShunKang commented on pull request #5613: Reduce memory allocation during address change notification.

Posted by "LinShunKang (GitHub)" <gi...@apache.org>.

Use `StringUtils.isNotEmpty(remoteFilter) && StringUtils.isNotEmpty(localFilter)` is better ?

[ Full content available at: https://github.com/apache/dubbo/pull/5613 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo] chickenlj commented on pull request #5613: Reduce memory allocation during address change notification.

Posted by "chickenlj (GitHub)" <gi...@apache.org>.

For most registries, It's a single-threaded model.  But I think we can add volatile.

[ Full content available at: https://github.com/apache/dubbo/pull/5613 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org