You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nifi.apache.org by Vibhath Ileperuma <vi...@gmail.com> on 2021/12/19 17:32:09 UTC
Clarification of PRs
Hi All,
I'm new to Apache Nifi and contributing to it. I reported the issue,
'NIFI-8605' some time back and created a PR for this issue recently.
However, some test scenarios failed with this fix, since db connection
auto-commit is set to false by default with this change.
I did a git commit again to set the auto-commit to true by default and I
can see this change in the PR now. Do I need to follow any further steps to
execute ci-workflow on my PR again?
Thanks & Regards
*Vibhath Ileperuma*
Re: Clarification of PRs
Posted by Vibhath Ileperuma <vi...@gmail.com>.
Thank you Chris
On Sun, 19 Dec 2021, 11:42 pm Chris Sampson,
<ch...@naimuri.com.invalid> wrote:
> Vibhath,
>
> Your PR does indeed have your changes and the checks have automatically
> re-executed after you pushed your second commit [1] - they appear to have
> passed without issue. Hopefully someone will be able to review your PR in
> the near future.
>
> [1] https://github.com/apache/nifi/pull/5554/checks
>
> ---
> *Chris Sampson*
> IT Consultant
> chris.sampson@naimuri.com
>
>
> On Sun, 19 Dec 2021 at 17:32, Vibhath Ileperuma <
> vibhatharunapriya@gmail.com>
> wrote:
>
> > Hi All,
> >
> > I'm new to Apache Nifi and contributing to it. I reported the issue,
> > 'NIFI-8605' some time back and created a PR for this issue recently.
> > However, some test scenarios failed with this fix, since db connection
> > auto-commit is set to false by default with this change.
> > I did a git commit again to set the auto-commit to true by default and I
> > can see this change in the PR now. Do I need to follow any further steps
> to
> > execute ci-workflow on my PR again?
> >
> > Thanks & Regards
> >
> > *Vibhath Ileperuma*
> >
>
Re: Clarification of PRs
Posted by Chris Sampson <ch...@naimuri.com.INVALID>.
Vibhath,
Your PR does indeed have your changes and the checks have automatically
re-executed after you pushed your second commit [1] - they appear to have
passed without issue. Hopefully someone will be able to review your PR in
the near future.
[1] https://github.com/apache/nifi/pull/5554/checks
---
*Chris Sampson*
IT Consultant
chris.sampson@naimuri.com
On Sun, 19 Dec 2021 at 17:32, Vibhath Ileperuma <vi...@gmail.com>
wrote:
> Hi All,
>
> I'm new to Apache Nifi and contributing to it. I reported the issue,
> 'NIFI-8605' some time back and created a PR for this issue recently.
> However, some test scenarios failed with this fix, since db connection
> auto-commit is set to false by default with this change.
> I did a git commit again to set the auto-commit to true by default and I
> can see this change in the PR now. Do I need to follow any further steps to
> execute ci-workflow on my PR again?
>
> Thanks & Regards
>
> *Vibhath Ileperuma*
>