[PR] (fix) StringUtil.toUpperCase does not uppercase supplementary-plane letters (opennlp)

["krickert (via GitHub)" <gi...@apache.org>]

krickert opened a new pull request, #1381:
URL: https://github.com/apache/opennlp/pull/1381

   Fixes #1376
   
   `StringUtil.toUpperCase` mapped one `char` at a time, so a letter outside the Basic Multilingual Plane, such as DESERET SMALL LETTER LONG I (U+10428), stayed lower case. It now maps by code point, the same way `StringUtil.toLowerCase` already does. BMP output and unpaired surrogates are unchanged.
   
   Tests cover supplementary and BMP letters, unpaired surrogates, empty input, and a mutable `CharSequence` that must not be modified. The manual notes the behavior.
   
   ### For all changes:
   - [x] Is there a GitHub issue associated with this PR? Is it referenced in the PR description?
   - [x] Has your PR been rebased against the latest commit within the target branch (typically main)?
   - [x] Is your initial contribution a single, squashed commit?
   
   ### For code changes:
   - [ ] Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder?
   - [x] Have you written or updated unit tests to verify your changes?
   - n/a: new dependencies, LICENSE, NOTICE
   
   ### For documentation related changes:
   - [x] Have you ensured that format looks appropriate for the output in which it is rendered?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] (fix) GH-1376: StringUtil.toUpperCase does not uppercase supplementary-plane letters (opennlp)

["mawiesne (via GitHub)" <gi...@apache.org>]

mawiesne merged PR #1381:
URL: https://github.com/apache/opennlp/pull/1381


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org