You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/06/14 07:59:38 UTC
[GitHub] [airflow] houqp opened a new pull request #16411: generate go client with latest openapi generator template
houqp opened a new pull request #16411:
URL: https://github.com/apache/airflow/pull/16411
Fix go client generation for openapi-generator 5.x. After this the client repo is updated, I will start a discussion on the dev list to finalize go client's release procedure following @msumit 's python runbook.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] msumit commented on a change in pull request #16411: generate go client with latest openapi generator template
Posted by GitBox <gi...@apache.org>.
msumit commented on a change in pull request #16411:
URL: https://github.com/apache/airflow/pull/16411#discussion_r650427627
##########
File path: clients/gen/go.sh
##########
@@ -25,7 +25,7 @@ readonly CLEANUP_DIRS
# shellcheck source=./clients/gen/common.sh
source "${CLIENTS_GEN_DIR}/common.sh"
-VERSION=1.1.0
+VERSION=2.0.0
Review comment:
Shouldn't it be `2.1.0`?
##########
File path: clients/gen/go.sh
##########
@@ -25,7 +25,7 @@ readonly CLEANUP_DIRS
# shellcheck source=./clients/gen/common.sh
source "${CLIENTS_GEN_DIR}/common.sh"
-VERSION=1.1.0
+VERSION=2.0.0
Review comment:
Nop, we decided to use Major.Minor release numbers from the Airflow and only last digit denoting fixes done on the client.
##########
File path: clients/gen/go.sh
##########
@@ -25,7 +25,7 @@ readonly CLEANUP_DIRS
# shellcheck source=./clients/gen/common.sh
source "${CLIENTS_GEN_DIR}/common.sh"
-VERSION=1.1.0
+VERSION=2.0.0
Review comment:
@potiuk it was on the dev mailing list ([here](https://lists.apache.org/thread.html/r8b7f615f56eaa6d5c1955173295d70b47e038b92b84310a82e2765a9%40%3Cdev.airflow.apache.org%3E)).. I don't think that we've added it somewhere in the docs yet..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] houqp commented on pull request #16411: generate go client with latest openapi generator template
Posted by GitBox <gi...@apache.org>.
houqp commented on pull request #16411:
URL: https://github.com/apache/airflow/pull/16411#issuecomment-860515736
@msumit @potiuk version updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] houqp merged pull request #16411: generate go client with latest openapi generator template
Posted by GitBox <gi...@apache.org>.
houqp merged pull request #16411:
URL: https://github.com/apache/airflow/pull/16411
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #16411: generate go client with latest openapi generator template
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #16411:
URL: https://github.com/apache/airflow/pull/16411#discussion_r650449833
##########
File path: clients/gen/go.sh
##########
@@ -25,7 +25,7 @@ readonly CLEANUP_DIRS
# shellcheck source=./clients/gen/common.sh
source "${CLIENTS_GEN_DIR}/common.sh"
-VERSION=1.1.0
+VERSION=2.0.0
Review comment:
Hm. I remember we discussed versioning, but can't find it quickly. My memory is not the best recently (got some disruptions and distractions) but if I remember correctly, we agreed to only follow MAJOR release, assuming that most recent MAJOR client will work with Any MAJOR version of airflow (and in this case 2.0.0 is perfectly fine).
But I might be wrong - does anyone remember where we had that discussion and did we capture the result of it.?
##########
File path: clients/gen/go.sh
##########
@@ -25,7 +25,7 @@ readonly CLEANUP_DIRS
# shellcheck source=./clients/gen/common.sh
source "${CLIENTS_GEN_DIR}/common.sh"
-VERSION=1.1.0
+VERSION=2.0.0
Review comment:
@kaxil @ashb ?
##########
File path: clients/gen/go.sh
##########
@@ -25,7 +25,7 @@ readonly CLEANUP_DIRS
# shellcheck source=./clients/gen/common.sh
source "${CLIENTS_GEN_DIR}/common.sh"
-VERSION=1.1.0
+VERSION=2.0.0
Review comment:
Ah. So my memory is failing me. Do you remember where the discussion was @msumit ? I think we need to capture it somewhere (unless it's already captured and I just did not find it :) ) ?
##########
File path: clients/gen/go.sh
##########
@@ -25,7 +25,7 @@ readonly CLEANUP_DIRS
# shellcheck source=./clients/gen/common.sh
source "${CLIENTS_GEN_DIR}/common.sh"
-VERSION=1.1.0
+VERSION=2.0.0
Review comment:
Thanks! Yeah. I remembered everything except the final conclusion :).
I created https://github.com/apache/airflow/pull/16422 with an attempt to capture all the SemVer rules we discussed so far. Happy to iterate and merge :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #16411: generate go client with latest openapi generator template
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #16411:
URL: https://github.com/apache/airflow/pull/16411#issuecomment-860043916
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org