You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2020/09/03 16:07:09 UTC
[GitHub] [logging-log4net] triumlabs opened a new pull request #65: Fix: RollingFileAppender does not work on Android and iOS
triumlabs opened a new pull request #65:
URL: https://github.com/apache/logging-log4net/pull/65
However netstandard contains cross-process Mutex, Android and iOS platform does not support it.
Therefore, current implementation of RollingFileAppender cannot be used on these platforms.
To fix it, Mutex object is replaced to a file based cross-process implementation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4net] fluffynuts commented on a change in pull request #65: Fix: RollingFileAppender does not work on Android and iOS
Posted by GitBox <gi...@apache.org>.
fluffynuts commented on a change in pull request #65:
URL: https://github.com/apache/logging-log4net/pull/65#discussion_r735437906
##########
File path: src/log4net/Appender/RollingFileAppender.cs
##########
@@ -1158,10 +1158,8 @@ override public void ActivateOptions()
m_baseFileName = base.File;
}
-#if !NETCF
// initialize the mutex that is used to lock rolling
- m_mutexForRolling = new Mutex(false, m_baseFileName.Replace("\\", "_").Replace(":", "_").Replace("/", "_"));
-#endif
+ m_mutexForRolling = new FileBasedMutex($"{m_baseFileName}.lock");
Review comment:
Please find a way to make this change specific to the platforms that need it - I don't want to risk issues on platforms where this is not a problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4net] fluffynuts commented on pull request #65: Fix: RollingFileAppender does not work on Android and iOS
Posted by GitBox <gi...@apache.org>.
fluffynuts commented on pull request #65:
URL: https://github.com/apache/logging-log4net/pull/65#issuecomment-957132782
This PR is quite stale & conflicts with the target branch; please re-open if it's still an issue you'd like to solve (: Thanks for your contribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4net] fluffynuts closed pull request #65: Fix: RollingFileAppender does not work on Android and iOS
Posted by GitBox <gi...@apache.org>.
fluffynuts closed pull request #65:
URL: https://github.com/apache/logging-log4net/pull/65
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4net] fluffynuts closed pull request #65: Fix: RollingFileAppender does not work on Android and iOS
Posted by GitBox <gi...@apache.org>.
fluffynuts closed pull request #65:
URL: https://github.com/apache/logging-log4net/pull/65
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4net] fluffynuts closed pull request #65: Fix: RollingFileAppender does not work on Android and iOS
Posted by GitBox <gi...@apache.org>.
fluffynuts closed pull request #65:
URL: https://github.com/apache/logging-log4net/pull/65
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4net] fluffynuts commented on pull request #65: Fix: RollingFileAppender does not work on Android and iOS
Posted by GitBox <gi...@apache.org>.
fluffynuts commented on pull request #65:
URL: https://github.com/apache/logging-log4net/pull/65#issuecomment-957132782
This PR is quite stale & conflicts with the target branch; please re-open if it's still an issue you'd like to solve (: Thanks for your contribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4net] fluffynuts commented on pull request #65: Fix: RollingFileAppender does not work on Android and iOS
Posted by GitBox <gi...@apache.org>.
fluffynuts commented on pull request #65:
URL: https://github.com/apache/logging-log4net/pull/65#issuecomment-957132782
This PR is quite stale & conflicts with the target branch; please re-open if it's still an issue you'd like to solve (: Thanks for your contribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org