You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/11/18 08:01:20 UTC
[GitHub] [apisix-dashboard] LiteSun opened a new issue #823: [Proposal]: Version management of route
LiteSun opened a new issue #823:
URL: https://github.com/apache/apisix-dashboard/issues/823
Please answer these questions before submitting your issue.
- Why do you submit this issue?
- [ ] Question or discussion
- [ ] Bug
- [ ] Requirements
- [X] Feature or performance improvement
- [ ] Other
___
### Question
- What do you want to know?
___
### Bug
- Which version of Apache APISIX Dashboard, OS, and Browser?
- What happened?
If possible, provide a way to reproduce the error.
___
### Requirements or improvement
- Please describe your requirements or improvement suggestions.
TODO
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #823: [Proposal]: Version management of route
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #823:
URL: https://github.com/apache/apisix-dashboard/issues/823#issuecomment-731560942
For draft proposal, please add some attractive notes, such as in title [DRAFT]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on issue #823: [Proposal]: Version management of route
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #823:
URL: https://github.com/apache/apisix-dashboard/issues/823#issuecomment-747892113
In the first version, I think it is enough to control the API version by only supporting the header.
This makes our implementation design easier.
I was confused with `Edit version drawer` and `version table`, need more docs @LiteSun , I can not understand them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun commented on issue #823: [DRAFT]: Version management of route
Posted by GitBox <gi...@apache.org>.
LiteSun commented on issue #823:
URL: https://github.com/apache/apisix-dashboard/issues/823#issuecomment-747847820
In order to manage api more finely, I propose to add api version management feature.
## front-end
- add version management section in route step1 page
- when `enable version` turn on, section `version config` and `version table` will show.
- when click `add` or `edit`, `Edit version drawer` will show.
## back-end
- `POST /apisix/admin/routes` and `PUT /apisix/admin/routes` need to support `version`.
```json
{
...,
...,
version: {
enable: true,
location:'header' | 'url' | 'first part of path',
strip_versio?n: false,
name:'string',
default: 'string',
version_list:[{
value:'v1',
override target host:'string',
expires: timestamp
},{}]
}
}
```
- need a new API to get version list, `get /version`:
```json
version_list:[{
value:'v1',
override target host:'string',
expires: timestamp
},{}]
```
## apisix
need to discuss.
cc @juzhiyuan @liuxiran @moonming @membphis @nic-chen
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #823: [Proposal]: Version management of route
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #823:
URL: https://github.com/apache/apisix-dashboard/issues/823#issuecomment-748007006
I will take this proposal.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun edited a comment on issue #823: [Proposal]: Version management of route
Posted by GitBox <gi...@apache.org>.
LiteSun edited a comment on issue #823:
URL: https://github.com/apache/apisix-dashboard/issues/823#issuecomment-747847820
In order to manage api more finely, I propose to add api version management feature.
## front-end
- add version management section in route step1 page
- when `enable version` turn on, section `version config` and `version table` will show.
- when click `add` or `edit`, `Edit version drawer` will show.
## back-end
- `POST /apisix/admin/routes` and `PUT /apisix/admin/routes` need to support `version`.
```json
{
...,
...,
version: {
enable: true,
location:'header' | 'url' | 'first part of path',
strip_versio?n: false,
name:'string',
default: 'string',
version_list:[{
value:'v1',
override target host:'string',
expires: timestamp
},{}]
}
}
```
## apisix
need to discuss.
cc @juzhiyuan @liuxiran @moonming @membphis @nic-chen
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun closed issue #823: [Proposal]: Version management of route
Posted by GitBox <gi...@apache.org>.
LiteSun closed issue #823:
URL: https://github.com/apache/apisix-dashboard/issues/823
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun commented on issue #823: [Proposal]: Version management of route
Posted by GitBox <gi...@apache.org>.
LiteSun commented on issue #823:
URL: https://github.com/apache/apisix-dashboard/issues/823#issuecomment-747917717
> I was confused with `Edit version drawer` and `version table`, need more docs @LiteSun , I can not understand them.
1. version table is used to show the version list, just like our `Advanced Routing Matching Conditions`
2.` Edit version drawer` is used to edit or create a version item. will trigger show when you click the `add` button or `edit`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] moonming commented on issue #823: [Proposal]: Version management of route
Posted by GitBox <gi...@apache.org>.
moonming commented on issue #823:
URL: https://github.com/apache/apisix-dashboard/issues/823#issuecomment-731559963
Why empty?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun edited a comment on issue #823: [DRAFT]: Version management of route
Posted by GitBox <gi...@apache.org>.
LiteSun edited a comment on issue #823:
URL: https://github.com/apache/apisix-dashboard/issues/823#issuecomment-747847820
In order to manage api more finely, I propose to add api version management feature.
## front-end
- add version management section in route step1 page
- when `enable version` turn on, section `version config` and `version table` will show.
- when click `add` or `edit`, `Edit version drawer` will show.
## back-end
- `POST /apisix/admin/routes` and `PUT /apisix/admin/routes` need to support `version`.
```json
{
...,
...,
version: {
enable: true,
location:'header' | 'url' | 'first part of path',
strip_versio?n: false,
name:'string',
default: 'string',
version_list:[{
value:'v1',
override target host:'string',
expires: timestamp
},{}]
}
}
```
- need a new API to get version list, `get /version`:
```json
version_list:[{
value:'v1',
override_target_host:'string',
expires: timestamp
},{}]
```
## apisix
need to discuss.
cc @juzhiyuan @liuxiran @moonming @membphis @nic-chen
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org