You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commons-dev@ws.apache.org by "Rich Scheuerle (JIRA)" <ji...@apache.org> on 2008/09/15 23:11:44 UTC

[jira] Created: (WSCOMMONS-384) OMElement.getXMLStreamReader

OMElement.getXMLStreamReader
----------------------------

                 Key: WSCOMMONS-384
                 URL: https://issues.apache.org/jira/browse/WSCOMMONS-384
             Project: WS-Commons
          Issue Type: Bug
          Components: AXIOM
            Reporter: Rich Scheuerle
            Assignee: Rich Scheuerle


Problem:

The OMElementImpl.getXMLStreamReader implementation is always doing a buildNext().  This is not necessary, it should only do a buildNext if the element is not complete.

Here is the current code:

private XMLStreamReader getXMLStreamReader(boolean cache) {
        if (builder != null && this.builder instanceof StAXOMBuilder) {
            if (((StAXOMBuilder) builder).isLookahead()) {
                this.buildNext();
            }
        }

Here is the code after the fix:

/**
     * Method getXMLStreamReader.
     *
     * @return Returns reader.
     */
    private XMLStreamReader getXMLStreamReader(boolean cache) {
        if (builder != null && this.builder instanceof StAXOMBuilder) {
            if (!isComplete()) {
                if (((StAXOMBuilder) builder).isLookahead()) {
                    this.buildNext();
                }
            }
        }

Kudos to Doug Larson, IBM Performance Analysist, for finding this problem and suggesting a solution.

I am currently testing the code, and I will commit the day in the next day or so.



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (WSCOMMONS-384) OMElement.getXMLStreamReader

Posted by "Rich Scheuerle (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WSCOMMONS-384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rich Scheuerle resolved WSCOMMONS-384.
--------------------------------------

    Resolution: Fixed

Committed revision 695708.

> OMElement.getXMLStreamReader
> ----------------------------
>
>                 Key: WSCOMMONS-384
>                 URL: https://issues.apache.org/jira/browse/WSCOMMONS-384
>             Project: WS-Commons
>          Issue Type: Bug
>          Components: AXIOM
>            Reporter: Rich Scheuerle
>            Assignee: Rich Scheuerle
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> Problem:
> The OMElementImpl.getXMLStreamReader implementation is always doing a buildNext().  This is not necessary, it should only do a buildNext if the element is not complete.
> Here is the current code:
> private XMLStreamReader getXMLStreamReader(boolean cache) {
>         if (builder != null && this.builder instanceof StAXOMBuilder) {
>             if (((StAXOMBuilder) builder).isLookahead()) {
>                 this.buildNext();
>             }
>         }
> Here is the code after the fix:
> /**
>      * Method getXMLStreamReader.
>      *
>      * @return Returns reader.
>      */
>     private XMLStreamReader getXMLStreamReader(boolean cache) {
>         if (builder != null && this.builder instanceof StAXOMBuilder) {
>             if (!isComplete()) {
>                 if (((StAXOMBuilder) builder).isLookahead()) {
>                     this.buildNext();
>                 }
>             }
>         }
> Kudos to Doug Larson, IBM Performance Analysist, for finding this problem and suggesting a solution.
> I am currently testing the code, and I will commit the day in the next day or so.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.