You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/07/30 07:31:21 UTC

[GitHub] [hudi] xicm opened a new pull request, #6252: [HUDI-4509] filter out files not exist

xicm opened a new pull request, #6252:
URL: https://github.com/apache/hudi/pull/6252

   ## *Tips*
   - *Thank you very much for contributing to Apache Hudi.*
   - *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
   
   ## What is the purpose of the pull request
   
   When I read hudi table with spark readStream, FileNotFoundException happens after a while. This happens when a compaction happens while reading and the compaction completes quickly, deleting the file that was being read.
   
   It seems that there is no mechanism to ensure no compaction while doing incremental read. 
   
   Spark job have retries, this pr filter files not exist to make stream read successful after a retry.
   
   ## Brief change log
   
   *(for example:)*
     - *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
   
   ## Verify this pull request
   
   *(Please pick either of the following options)*
   
   This pull request is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This pull request is already covered by existing tests, such as *(please describe tests)*.
   
   (or)
   
   This change added tests and can be verified as follows:
   
   *(example:)*
   
     - *Added integration tests for end-to-end.*
     - *Added HoodieClientWriteTest to verify the change.*
     - *Manually verified the change by running a job locally.*
   
   ## Committer checklist
   
    - [ ] Has a corresponding JIRA in PR title & commit
    
    - [ ] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] xicm commented on pull request #6252: [HUDI-4509] filter out files not exist

Posted by GitBox <gi...@apache.org>.
xicm commented on PR #6252:
URL: https://github.com/apache/hudi/pull/6252#issuecomment-1200752639

   Will be fixed by https://github.com/apache/hudi/pull/6141


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #6252: [HUDI-4509] filter out files not exist

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6252:
URL: https://github.com/apache/hudi/pull/6252#issuecomment-1200130211

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "56ead9e97a703d7e1e03951d2d5da44252704cbc",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10468",
       "triggerID" : "56ead9e97a703d7e1e03951d2d5da44252704cbc",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 56ead9e97a703d7e1e03951d2d5da44252704cbc Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10468) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] danny0405 commented on pull request #6252: [HUDI-4509] filter out files not exist

Posted by GitBox <gi...@apache.org>.
danny0405 commented on PR #6252:
URL: https://github.com/apache/hudi/pull/6252#issuecomment-1200787152

   > > Maybe this is what you need: #6141
   > 
   > Hi @danny0405 , thanks for your help. Alse check with you, can #6096 solve the FileNotFoundException in flink stream read?
   
   No, #6090 would only solve the incremental read for batch mode.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] danny0405 commented on pull request #6252: [HUDI-4509] filter out files not exist

Posted by GitBox <gi...@apache.org>.
danny0405 commented on PR #6252:
URL: https://github.com/apache/hudi/pull/6252#issuecomment-1200606284

   Maybe this is what you need: https://github.com/apache/hudi/pull/6141


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #6252: [HUDI-4509] filter out files not exist

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6252:
URL: https://github.com/apache/hudi/pull/6252#issuecomment-1200112760

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "56ead9e97a703d7e1e03951d2d5da44252704cbc",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "56ead9e97a703d7e1e03951d2d5da44252704cbc",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 56ead9e97a703d7e1e03951d2d5da44252704cbc UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #6252: [HUDI-4509] filter out files not exist

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6252:
URL: https://github.com/apache/hudi/pull/6252#issuecomment-1200113489

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "56ead9e97a703d7e1e03951d2d5da44252704cbc",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10468",
       "triggerID" : "56ead9e97a703d7e1e03951d2d5da44252704cbc",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 56ead9e97a703d7e1e03951d2d5da44252704cbc Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10468) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] xicm commented on pull request #6252: [HUDI-4509] filter out files not exist

Posted by GitBox <gi...@apache.org>.
xicm commented on PR #6252:
URL: https://github.com/apache/hudi/pull/6252#issuecomment-1200634972

   > Maybe this is what you need: #6141
   
   Hi @danny0405 , thanks for your help.
   Alse check with you, can https://github.com/apache/hudi/pull/6096 solve the FileNotFoundException in flink stream read?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] xicm commented on pull request #6252: [HUDI-4509] filter out files not exist

Posted by GitBox <gi...@apache.org>.
xicm commented on PR #6252:
URL: https://github.com/apache/hudi/pull/6252#issuecomment-1200754267

   Will be fixed by https://github.com/apache/hudi/pull/6141


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] xicm closed pull request #6252: [HUDI-4509] filter out files not exist

Posted by GitBox <gi...@apache.org>.
xicm closed pull request #6252: [HUDI-4509] filter out files not exist
URL: https://github.com/apache/hudi/pull/6252


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] xicm commented on pull request #6252: [HUDI-4509] filter out files not exist

Posted by GitBox <gi...@apache.org>.
xicm commented on PR #6252:
URL: https://github.com/apache/hudi/pull/6252#issuecomment-1200110852

   This fix is not good, is there any advice I can go into?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] xicm commented on pull request #6252: [HUDI-4509] filter out files not exist

Posted by GitBox <gi...@apache.org>.
xicm commented on PR #6252:
URL: https://github.com/apache/hudi/pull/6252#issuecomment-1200649459

   https://github.com/apache/hudi/blob/c72d895fed4b8f0ca899f15ff07d3446143811ac/hudi-common/src/main/java/org/apache/hudi/common/fs/FSUtils.java#L319-L323
   When I look into #6096 , I find a typo spillableMapPath, do we need to fix this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org