You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "tqchen (via GitHub)" <gi...@apache.org> on 2023/06/21 22:25:35 UTC

[GitHub] [tvm] tqchen commented on a diff in pull request #15140: [Unity][IR][UX] Privacy annotation

tqchen commented on code in PR #15140:
URL: https://github.com/apache/tvm/pull/15140#discussion_r1237781286


##########
tests/python/relax/test_tvmscript_printer_relax.py:
##########
@@ -47,8 +47,10 @@ def main(a: R.Tensor((10, 10))) -> R.Tensor((10, 10)):
 
 
 def test_extern_func():
+    # note: this function will be treated as private unless a global symbol is added

Review Comment:
   How about we treat function outside as public always?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org