You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Jukka Zitting (Commented) (JIRA)" <ji...@apache.org> on 2011/11/01 12:44:32 UTC
[jira] [Commented] (JCR-3131) NPE in ItemManager when calling
Session.save() with nothing to save
[ https://issues.apache.org/jira/browse/JCR-3131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141086#comment-13141086 ]
Jukka Zitting commented on JCR-3131:
------------------------------------
+1 the patch looks good
> NPE in ItemManager when calling Session.save() with nothing to save
> -------------------------------------------------------------------
>
> Key: JCR-3131
> URL: https://issues.apache.org/jira/browse/JCR-3131
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-core
> Affects Versions: 2.3.2
> Reporter: Bertrand Delacretaz
> Assignee: Julian Reschke
> Priority: Minor
> Attachments: JCR-3131.patch
>
>
> I'm getting an NPE on the id.denoteNodes() call below, in ItemManager:
> private ItemData retrieveItem(ItemId id) {
> synchronized (itemCache) {
> ItemData data = itemCache.get(id);
> if (data == null && id.denotesNode()) {
> ...
> because the id is null after taking the second branch of this if in SessionSaveOperation.perform:
> if (context.getSessionImpl().hasPermission("/", Session.ACTION_READ)) {
> id = context.getRootNodeId();
> } else {
> id = context.getItemStateManager().getIdOfRootTransientNodeState();
> }
> context.toString() says:
> session-author-3623:
> ItemManager (org.apache.jackrabbit.core.ItemManager@1e911ccc)
> Items in cache:
> SessionItemStateManager (org.apache.jackrabbit.core.state.SessionItemStateManager@15472b43)
> [transient]
> {}[attic]
> {}
> which I assume means there's nothing to save.
> The correct behavior is probably to do nothing in perform to avoid the NPE.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira