You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/07/29 05:09:46 UTC
[GitHub] [iotdb] SpriCoder commented on a diff in pull request #6801: [IOTDB-3955] Improved node information metrics to push more detailed node information, online and offline total and survival information of each node
SpriCoder commented on code in PR #6801:
URL: https://github.com/apache/iotdb/pull/6801#discussion_r932871483
##########
confignode/src/main/java/org/apache/iotdb/confignode/manager/load/LoadManager.java:
##########
@@ -420,6 +428,140 @@ public List<TDataNodeConfiguration> getOnlineDataNodes(int dataNodeId) {
.collect(Collectors.toList());
}
+ public List<TConfigNodeLocation> getUnknownConfigNodes() {
+ return getNodeManager().getRegisteredConfigNodes().stream()
+ .filter(
+ registeredConfigNode ->
+ nodeCacheMap
+ .get(registeredConfigNode.getConfigNodeId())
+ .getNodeStatus()
+ .equals(NodeStatus.Unknown))
+ .collect(Collectors.toList());
+ }
+
+ public List<TDataNodeConfiguration> getUnknownDataNodes(int dataNodeId) {
+ return getNodeManager().getRegisteredDataNodes(dataNodeId).stream()
+ .filter(
+ registeredDataNode ->
+ nodeCacheMap
+ .get(registeredDataNode.getLocation().getDataNodeId())
+ .getNodeStatus()
+ .equals(NodeStatus.Unknown))
+ .collect(Collectors.toList());
+ }
+
+ public int getRunningConfigNodesNum() {
+ List<TConfigNodeLocation> allConfigNodes = getOnlineConfigNodes();
+ if (allConfigNodes == null) {
+ return 0;
+ }
+ return allConfigNodes.size();
+ }
+
+ public int getRunningDataNodesNum() {
+ List<TDataNodeConfiguration> allDataNodes = getOnlineDataNodes(-1);
+ if (allDataNodes == null) {
+ return 0;
+ }
+ return allDataNodes.size();
+ }
+
+ public int getUnknownConfigNodesNum() {
+ List<TConfigNodeLocation> allConfigNodes = getUnknownConfigNodes();
+ if (allConfigNodes == null) {
+ return 0;
+ }
+ return allConfigNodes.size();
+ }
+
+ public int getUnknownDataNodesNum() {
+ List<TDataNodeConfiguration> allDataNodes = getUnknownDataNodes(-1);
+ if (allDataNodes == null) {
+ return 0;
+ }
+ return allDataNodes.size();
+ }
+
+ public void addMetrics() {
+ if (MetricConfigDescriptor.getInstance().getMetricConfig().getEnableMetric()) {
+ MetricsService.getInstance()
+ .getMetricManager()
+ .getOrCreateGauge(
+ Metric.CONFIG_NODE.toString(),
+ MetricLevel.CORE,
+ Tag.NAME.toString(),
+ "total",
+ Tag.STATUS.toString(),
+ "online")
+ .set(getRunningConfigNodesNum());
+ MetricsService.getInstance()
+ .getMetricManager()
+ .getOrCreateGauge(
+ Metric.DATA_NODE.toString(),
+ MetricLevel.CORE,
+ Tag.NAME.toString(),
+ "total",
+ Tag.STATUS.toString(),
+ "online")
+ .set(getRunningDataNodesNum());
+ MetricsService.getInstance()
+ .getMetricManager()
+ .getOrCreateGauge(
+ Metric.CONFIG_NODE.toString(),
+ MetricLevel.CORE,
+ Tag.NAME.toString(),
+ "total",
+ Tag.STATUS.toString(),
+ "unknown")
+ .set(getUnknownConfigNodesNum());
+ MetricsService.getInstance()
+ .getMetricManager()
+ .getOrCreateGauge(
+ Metric.DATA_NODE.toString(),
+ MetricLevel.CORE,
+ Tag.NAME.toString(),
+ "total",
+ Tag.STATUS.toString(),
+ "unknown")
+ .set(getUnknownDataNodesNum());
+ }
+ }
Review Comment:
I think the value of tag can be the name of NodeStatus enums to remove hard code.
##########
confignode/src/main/java/org/apache/iotdb/confignode/persistence/NodeInfo.java:
##########
@@ -121,7 +123,9 @@ public void addMetrics() {
registeredDataNodes,
Map::size,
Tag.NAME.toString(),
- "online");
+ "total",
+ Tag.STATUS.toString(),
+ "registered");
Review Comment:
I think the value of tag can be the name of NodeStatus enums to remove hard code.
##########
confignode/src/main/java/org/apache/iotdb/confignode/persistence/NodeInfo.java:
##########
@@ -112,7 +112,9 @@ public void addMetrics() {
registeredConfigNodes,
o -> getRegisteredConfigNodeCount(),
Tag.NAME.toString(),
- "online");
+ "total",
+ Tag.STATUS.toString(),
+ "registered");
Review Comment:
I think the value of tag can be the name of NodeStatus enums to remove hard code.
##########
confignode/src/main/java/org/apache/iotdb/confignode/manager/load/LoadManager.java:
##########
@@ -244,6 +249,8 @@ public void start() {
/** Stop the heartbeat service and the load balancing service */
public void stop() {
+ LOGGER.info("Remove loadManager metrics");
Review Comment:
This log is useless.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org