You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/02/07 12:00:39 UTC
[GitHub] [incubator-nuttx] masayuki2009 commented on a change in pull
request #220: ELF64 support
masayuki2009 commented on a change in pull request #220: ELF64 support
URL: https://github.com/apache/incubator-nuttx/pull/220#discussion_r376355930
##########
File path: include/elf_common.h
##########
@@ -0,0 +1,214 @@
+/****************************************************************************
+ * include/elf_common.h
Review comment:
> It is better to rename elf_common.h to elf.h to more compatible with other POSIX variant,
> and include elf32.h/elf64.h inside elf.h like this:
@xiaoxiang781216 Thanks for the comment. I'll modify the file later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services