You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/09/24 18:26:05 UTC
Review Request 68826: Fixed bug in `verify-reviews` due to mismatched
types.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68826/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier and Vinod Kone.
Repository: mesos
Description
-------
Because Python is not type-safe, we encountered a bug in the code
executed on non-Windows platforms that was expecting `output` to be a
normal Python string instead of a Python byte string (with encoded
content). To fix this, we now always decode the bytes into a string,
so that the logic afterwards only has one type to deal with.
Diffs
-----
support/verify-reviews.py 72b7eb5b9baaf8eaa352b55dad55e62881d87323
Diff: https://reviews.apache.org/r/68826/diff/1/
Testing
-------
Thanks,
Andrew Schwartzmeyer
Re: Review Request 68826: Fixed bug in `verify-reviews` due to
mismatched types.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68826/#review208960
-----------------------------------------------------------
PASS: Mesos patch 68826 was successfully built and tested.
Reviews applied: `['68826']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2390/mesos-review-68826
- Mesos Reviewbot Windows
On Sept. 24, 2018, 6:27 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68826/
> -----------------------------------------------------------
>
> (Updated Sept. 24, 2018, 6:27 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Vinod Kone.
>
>
> Bugs: MESOS-9253
> https://issues.apache.org/jira/browse/MESOS-9253
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Because Python is not type-safe, we encountered a bug in the code
> executed on non-Windows platforms that was expecting `output` to be a
> normal Python string instead of a Python byte string (with encoded
> content). To fix this, we now always decode the bytes into a string,
> so that the logic afterwards only has one type to deal with.
>
>
> Diffs
> -----
>
> support/verify-reviews.py 72b7eb5b9baaf8eaa352b55dad55e62881d87323
>
>
> Diff: https://reviews.apache.org/r/68826/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 68826: Fixed bug in `verify-reviews` due to
mismatched types.
Posted by Vinod Kone <vi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68826/#review208959
-----------------------------------------------------------
Ship it!
LGTM from my limited understanding of python
- Vinod Kone
On Sept. 24, 2018, 6:27 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68826/
> -----------------------------------------------------------
>
> (Updated Sept. 24, 2018, 6:27 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Vinod Kone.
>
>
> Bugs: MESOS-9253
> https://issues.apache.org/jira/browse/MESOS-9253
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Because Python is not type-safe, we encountered a bug in the code
> executed on non-Windows platforms that was expecting `output` to be a
> normal Python string instead of a Python byte string (with encoded
> content). To fix this, we now always decode the bytes into a string,
> so that the logic afterwards only has one type to deal with.
>
>
> Diffs
> -----
>
> support/verify-reviews.py 72b7eb5b9baaf8eaa352b55dad55e62881d87323
>
>
> Diff: https://reviews.apache.org/r/68826/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 68826: Fixed bug in `verify-reviews` due to
mismatched types.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68826/
-----------------------------------------------------------
(Updated Sept. 24, 2018, 11:27 a.m.)
Review request for mesos, Benjamin Bannier and Vinod Kone.
Bugs: MESOS-9253
https://issues.apache.org/jira/browse/MESOS-9253
Repository: mesos
Description
-------
Because Python is not type-safe, we encountered a bug in the code
executed on non-Windows platforms that was expecting `output` to be a
normal Python string instead of a Python byte string (with encoded
content). To fix this, we now always decode the bytes into a string,
so that the logic afterwards only has one type to deal with.
Diffs
-----
support/verify-reviews.py 72b7eb5b9baaf8eaa352b55dad55e62881d87323
Diff: https://reviews.apache.org/r/68826/diff/1/
Testing
-------
Thanks,
Andrew Schwartzmeyer