You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/04/25 14:16:46 UTC

[GitHub] [flink] snuyanzin commented on pull request #19565: [FLINK-27368][table-planner] Trim casts from character string to numeric

snuyanzin commented on PR #19565:
URL: https://github.com/apache/flink/pull/19565#issuecomment-1108636404

   LGTM from my side
   the only neat question I have:
   does it make sense to add a test for case with no integer part like
   ```java
   .fromCase(
                                   STRING(),
                                   fromString(" .1 "),
                                   fromBigDecimal(new BigDecimal("0.100"), 5, 3))
   ```
   postgres also supports that


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org