You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/02/18 19:44:10 UTC

[GitHub] mistercrunch commented on issue #6610: Add support to Apache Drill

mistercrunch commented on issue #6610: Add support to Apache Drill
URL: https://github.com/apache/incubator-superset/pull/6610#issuecomment-464854934
 
 
   I don't think it's ok to have references to `@@@` scattered across the code base. It really should be limited to the `db_engine_spec` entry for drill. Looks like there are few entries on the frontend and one on the backend outside of `db_engine_spec` to clean up.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org