[GitHub] lburgazzoli commented on a change in pull request #479: Activate Kaniko caching and warm the platform base image

[GitBox <gi...@apache.org>]

lburgazzoli commented on a change in pull request #479: Activate Kaniko caching and warm the platform base image
URL: https://github.com/apache/camel-k/pull/479#discussion_r259236975
 
 

 ##########
 File path: pkg/controller/integrationplatform/initialize.go
 ##########
 @@ -115,19 +115,29 @@ func (action *initializeAction) Handle(ctx context.Context, platform *v1alpha1.I
 		return err
 	}
 
+	if target.Spec.Build.PublishStrategy == v1alpha1.IntegrationPlatformBuildPublishStrategyKaniko {
+		// create and warm the Kaniko cache into the Camel K builder volume
+		action.L.Info("Warming Kaniko cache...")
+		err = warmKanikoCache(ctx, action.client, target)
 
 Review comment:
   wondering if this warming up could be translate into an additional phase and the warmKanikoCache done in a separate co-routine to avoid blocking the reconcile loop

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services