[jira] [Commented] (CALCITE-4585) when use prepareStatement parse and run RelNode or Queryable, Maybe Confusing log information be thrown

["Stamatis Zampetakis (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-4585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17324723#comment-17324723 ] 

Stamatis Zampetakis commented on CALCITE-4585:
----------------------------------------------

If understand well the problem is that you may be missing SQL information from the query object but have RelNode or something else when you get the exception, is that right?

Is it possible to add test cases in the PR triggering the exception and checking the expected messages?

> when use prepareStatement parse and run RelNode or Queryable, Maybe Confusing log information be thrown
> -------------------------------------------------------------------------------------------------------
>
>                 Key: CALCITE-4585
>                 URL: https://issues.apache.org/jira/browse/CALCITE-4585
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.26.0
>            Reporter: duan xiong
>            Assignee: duan xiong
>            Priority: Minor
>              Labels: pull-request-available
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> This code capture the exception,But Only the output of SQL exception is processed.So need to add the procedure to handle extra exception. 
> {code:java}
> // 
> try {
>   final Meta.Signature signature =
>       parseQuery(query, createPrepareContext(), -1);
>   final CalcitePreparedStatement calcitePreparedStatement =
>       (CalcitePreparedStatement) factory.newPreparedStatement(this, null,
>           signature, resultSetType, resultSetConcurrency, resultSetHoldability);
>   server.getStatement(calcitePreparedStatement.handle).setSignature(signature);
>   return calcitePreparedStatement;
> } catch (Exception e) {
>   throw Helper.INSTANCE.createException(
>       "Error while preparing statement [" + query.sql + "]", e);
> }
> {code}
> When we run RelNode or  queryable show wrong,this exception can be:
> "Error while preparing statement [null]"
>  can't log the real exception



--
This message was sent by Atlassian Jira
(v8.3.4#803005)