[jira] [Comment Edited] (KAFKA-324) enforce broker.id to be a non-negative integer

["Swapnil Ghike (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13436379#comment-13436379 ] 

Swapnil Ghike edited comment on KAFKA-324 at 8/17/12 9:47 AM:
--------------------------------------------------------------

Actually all the get* helper functions in Utils throw IllegalArgumentException in 0.7 trunk. Can change the KafkaExceptions to IllegalArgumentException in 0.8. Adding a Utils.require(bool, errmsg) to maintain similar looks of KanfaConfig.
                
      was (Author: swapnilghike):
    Actually all the get* helper functions in Utils throw IllegalArgumentException as they are right now. Added a Utils.require(bool, errmsg) to maintain similar looks of KanfaConfig.
                  
> enforce broker.id to be a non-negative integer
> ----------------------------------------------
>
>                 Key: KAFKA-324
>                 URL: https://issues.apache.org/jira/browse/KAFKA-324
>             Project: Kafka
>          Issue Type: Improvement
>    Affects Versions: 0.8
>            Reporter: Jun Rao
>            Assignee: Swapnil Ghike
>              Labels: newbie, noob
>         Attachments: kafka-324.patch
>
>
> In DefaultEventHandler, it seems that we rely on the fact that broker.id is a non-negative integer. However, we don't enforce that in broker startup. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira