You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by bhuvnesh chaudhary <bc...@pivotal.io> on 2016/02/19 18:38:25 UTC
Review Request 43771: HAWQSEGMENT should be not be recommended on
host which does not have DataNode
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43771/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, jun aoki, Jayush Luniya, Oleksandr Diachenko, Richard Zang, and Yusaku Sako.
Bugs: AMBARI-15116
https://issues.apache.org/jira/browse/AMBARI-15116
Repository: ambari
Description
-------
This patches ensures that HAWQSEGMENT should not be recommended on host which does not have DataNode at Assign Slaves and Client page.
Recommendation should always suggests to have HAWQSEGMENT colocated with DATANODE.
Diffs
-----
ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py b354378
Diff: https://reviews.apache.org/r/43771/diff/
Testing
-------
yes. manual
Thanks,
bhuvnesh chaudhary
Re: Review Request 43771: HAWQSEGMENT should be not be recommended on
host which does not have DataNode
Posted by bhuvnesh chaudhary <bc...@pivotal.io>.
> On Feb. 21, 2016, 10:34 p.m., Matt wrote:
> > ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py, line 227
> > <https://reviews.apache.org/r/43771/diff/2/?file=1263588#file1263588line227>
> >
> > Thought the JIRA was about 'HAWQSEGMENT should not be recommended on a host without DATANODE'.
> >
> > I see no DATANODE on host-group-1, but the comment says HAWQSEGMENT should be recommended on host-group-1? I believe you meant to say that the recommendation should have neither of them on host-group-1.
The recommendations snippet in comment should not have any component on host-group-1, updated it, good catch.
- bhuvnesh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43771/#review120078
-----------------------------------------------------------
On Feb. 22, 2016, 2:23 a.m., bhuvnesh chaudhary wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43771/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2016, 2:23 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, jun aoki, Jayush Luniya, Oleksandr Diachenko, Richard Zang, and Yusaku Sako.
>
>
> Bugs: AMBARI-15116
> https://issues.apache.org/jira/browse/AMBARI-15116
>
>
> Repository: ambari
>
>
> Description
> -------
>
> This patches ensures that HAWQSEGMENT should not be recommended on host which does not have DataNode at Assign Slaves and Client page.
> Recommendation should always suggests to have HAWQSEGMENT colocated with DATANODE.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 34e4cfa
> ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 03ae6cc
>
> Diff: https://reviews.apache.org/r/43771/diff/
>
>
> Testing
> -------
>
> yes. manual
>
>
> Thanks,
>
> bhuvnesh chaudhary
>
>
Re: Review Request 43771: HAWQSEGMENT should be not be recommended on
host which does not have DataNode
Posted by Matt <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43771/#review120078
-----------------------------------------------------------
Fix it, then Ship it!
The code and test case looks good. However, the comment does not align with the test case that was added.
ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py (line 227)
<https://reviews.apache.org/r/43771/#comment181444>
Thought the JIRA was about 'HAWQSEGMENT should not be recommended on a host without DATANODE'.
I see no DATANODE on host-group-1, but the comment says HAWQSEGMENT should be recommended on host-group-1? I believe you meant to say that the recommendation should have neither of them on host-group-1.
- Matt
On Feb. 20, 2016, noon, bhuvnesh chaudhary wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43771/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2016, noon)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, jun aoki, Jayush Luniya, Oleksandr Diachenko, Richard Zang, and Yusaku Sako.
>
>
> Bugs: AMBARI-15116
> https://issues.apache.org/jira/browse/AMBARI-15116
>
>
> Repository: ambari
>
>
> Description
> -------
>
> This patches ensures that HAWQSEGMENT should not be recommended on host which does not have DataNode at Assign Slaves and Client page.
> Recommendation should always suggests to have HAWQSEGMENT colocated with DATANODE.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 34e4cfa
> ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 03ae6cc
>
> Diff: https://reviews.apache.org/r/43771/diff/
>
>
> Testing
> -------
>
> yes. manual
>
>
> Thanks,
>
> bhuvnesh chaudhary
>
>
Re: Review Request 43771: HAWQSEGMENT should be not be recommended on
host which does not have DataNode
Posted by Oleksandr Diachenko <od...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43771/#review120194
-----------------------------------------------------------
Ship it!
Ship It!
- Oleksandr Diachenko
On Feb. 22, 2016, 2:23 a.m., bhuvnesh chaudhary wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43771/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2016, 2:23 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, jun aoki, Jayush Luniya, Oleksandr Diachenko, Richard Zang, and Yusaku Sako.
>
>
> Bugs: AMBARI-15116
> https://issues.apache.org/jira/browse/AMBARI-15116
>
>
> Repository: ambari
>
>
> Description
> -------
>
> This patches ensures that HAWQSEGMENT should not be recommended on host which does not have DataNode at Assign Slaves and Client page.
> Recommendation should always suggests to have HAWQSEGMENT colocated with DATANODE.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 34e4cfa
> ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 03ae6cc
>
> Diff: https://reviews.apache.org/r/43771/diff/
>
>
> Testing
> -------
>
> yes. manual
>
>
> Thanks,
>
> bhuvnesh chaudhary
>
>
Re: Review Request 43771: HAWQSEGMENT should be not be recommended on
host which does not have DataNode
Posted by bhuvnesh chaudhary <bc...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43771/
-----------------------------------------------------------
(Updated Feb. 22, 2016, 2:23 a.m.)
Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, jun aoki, Jayush Luniya, Oleksandr Diachenko, Richard Zang, and Yusaku Sako.
Changes
-------
Updated recommendations. host-group-1 should have no component.
Bugs: AMBARI-15116
https://issues.apache.org/jira/browse/AMBARI-15116
Repository: ambari
Description
-------
This patches ensures that HAWQSEGMENT should not be recommended on host which does not have DataNode at Assign Slaves and Client page.
Recommendation should always suggests to have HAWQSEGMENT colocated with DATANODE.
Diffs (updated)
-----
ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 34e4cfa
ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 03ae6cc
Diff: https://reviews.apache.org/r/43771/diff/
Testing
-------
yes. manual
Thanks,
bhuvnesh chaudhary
Re: Review Request 43771: HAWQSEGMENT should be not be recommended on
host which does not have DataNode
Posted by bhuvnesh chaudhary <bc...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43771/
-----------------------------------------------------------
(Updated Feb. 20, 2016, 8 p.m.)
Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, jun aoki, Jayush Luniya, Oleksandr Diachenko, Richard Zang, and Yusaku Sako.
Changes
-------
Included testcase.
Bugs: AMBARI-15116
https://issues.apache.org/jira/browse/AMBARI-15116
Repository: ambari
Description
-------
This patches ensures that HAWQSEGMENT should not be recommended on host which does not have DataNode at Assign Slaves and Client page.
Recommendation should always suggests to have HAWQSEGMENT colocated with DATANODE.
Diffs (updated)
-----
ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 34e4cfa
ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 03ae6cc
Diff: https://reviews.apache.org/r/43771/diff/
Testing
-------
yes. manual
Thanks,
bhuvnesh chaudhary
Re: Review Request 43771: HAWQSEGMENT should be not be recommended on
host which does not have DataNode
Posted by Matt <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43771/#review120013
-----------------------------------------------------------
Fix it, then Ship it!
ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py (line 43)
<https://reviews.apache.org/r/43771/#comment181375>
Add unit test
- Matt
On Feb. 19, 2016, 9:38 a.m., bhuvnesh chaudhary wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43771/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2016, 9:38 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, jun aoki, Jayush Luniya, Oleksandr Diachenko, Richard Zang, and Yusaku Sako.
>
>
> Bugs: AMBARI-15116
> https://issues.apache.org/jira/browse/AMBARI-15116
>
>
> Repository: ambari
>
>
> Description
> -------
>
> This patches ensures that HAWQSEGMENT should not be recommended on host which does not have DataNode at Assign Slaves and Client page.
> Recommendation should always suggests to have HAWQSEGMENT colocated with DATANODE.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py b354378
>
> Diff: https://reviews.apache.org/r/43771/diff/
>
>
> Testing
> -------
>
> yes. manual
>
>
> Thanks,
>
> bhuvnesh chaudhary
>
>