You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2022/05/21 04:12:08 UTC
[GitHub] [lucene] mocobeta opened a new pull request, #916: Refine contribution guide and pull request template
mocobeta opened a new pull request, #916:
URL: https://github.com/apache/lucene/pull/916
Some part of the pull request template has been a bit obsoleted, and there are overlaps between the contribution guide and the template.
I noticed the majority of developers (including me...) delete all texts in the template and start with a blank sheet (90% of PRs, I roughly estimate) - then how about just encouraging people to refer to the contribution guide in the template?
To avoid information loss, I moved checklist items that did not appear in the contribution guide to it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta commented on a diff in pull request #916: Refine contribution guide and pull request template
Posted by GitBox <gi...@apache.org>.
mocobeta commented on code in PR #916:
URL: https://github.com/apache/lucene/pull/916#discussion_r879634562
##########
CONTRIBUTING.md:
##########
@@ -78,8 +78,11 @@ Please be patient. Committers are busy people too. If no one responds to your pa
Please refer to [GitHub's documentation](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests) for an explanation of how to create a pull request.
+You should open a pull request against the `main` branch. It is also recommended to give Lucene maintainers [access](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to your PR branch.
Review Comment:
For sure. We already have the good default, then the request to give access wouldn't be needed anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta commented on a diff in pull request #916: Refine contribution guide and pull request template
Posted by GitBox <gi...@apache.org>.
mocobeta commented on code in PR #916:
URL: https://github.com/apache/lucene/pull/916#discussion_r879964992
##########
CONTRIBUTING.md:
##########
@@ -78,8 +78,11 @@ Please be patient. Committers are busy people too. If no one responds to your pa
Please refer to [GitHub's documentation](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests) for an explanation of how to create a pull request.
+You should open a pull request against the `main` branch. It is also recommended to give Lucene maintainers [access](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to your PR branch.
Review Comment:
```suggestion
You should open a pull request against the `main` branch.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta commented on a diff in pull request #916: Refine contribution guide and pull request template
Posted by GitBox <gi...@apache.org>.
mocobeta commented on code in PR #916:
URL: https://github.com/apache/lucene/pull/916#discussion_r879967339
##########
CONTRIBUTING.md:
##########
@@ -78,8 +78,11 @@ Please be patient. Committers are busy people too. If no one responds to your pa
Please refer to [GitHub's documentation](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests) for an explanation of how to create a pull request.
+You should open a pull request against the `main` branch.
Review Comment:
```suggestion
You should open a pull request against the `main` branch. Committers will backport it to the maintenance branches once the change is merged into `main` (as far as it is possible).
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] rmuir commented on a diff in pull request #916: Refine contribution guide and pull request template
Posted by GitBox <gi...@apache.org>.
rmuir commented on code in PR #916:
URL: https://github.com/apache/lucene/pull/916#discussion_r879605545
##########
CONTRIBUTING.md:
##########
@@ -78,8 +78,11 @@ Please be patient. Committers are busy people too. If no one responds to your pa
Please refer to [GitHub's documentation](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests) for an explanation of how to create a pull request.
+You should open a pull request against the `main` branch. It is also recommended to give Lucene maintainers [access](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to your PR branch.
Review Comment:
Is this "access" step required anymore? Isn't it the default in github these days?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta commented on pull request #916: Refine contribution guide and pull request template
Posted by GitBox <gi...@apache.org>.
mocobeta commented on PR #916:
URL: https://github.com/apache/lucene/pull/916#issuecomment-1135442476
Thank you @rmuir for reviewing.
I'd merge this - let's restart from a blank sheet (all necessary information should be written in the contribution guide), but if anyone has suggestions to make the pull request template helpful for committers/contributors, please make another issue/PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta merged pull request #916: Refine contribution guide and pull request template
Posted by GitBox <gi...@apache.org>.
mocobeta merged PR #916:
URL: https://github.com/apache/lucene/pull/916
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org