You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by chiwanpark <gi...@git.apache.org> on 2015/09/30 10:46:33 UTC

[GitHub] flink pull request: [FLINK-2767] [scala shell] Add Scala 2.11 supp...

GitHub user chiwanpark opened a pull request:

    https://github.com/apache/flink/pull/1197

    [FLINK-2767] [scala shell] Add Scala 2.11 support to Scala shell

    This PR contains following changes:
    
    * Add `ILoopCompat` class for supporting both Scala 2.10 and Scala 2.11 (Inspired by [Scalding REPL](https://github.com/twitter/scalding/blob/develop/scalding-repl/src/main/scala-2.11/com/twitter/scalding/ILoopCompat.scala))
    * Some modification of POM to include `flink-scala-shell` with Scala 2.11
    
    I have tested local execution and remote execution with standalone Flink cluster.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/chiwanpark/flink FLINK-2767

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1197.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1197
    
----
commit a0ad8fbc90262d6ceb8699b02e5a9661f836d405
Author: Chiwan Park <ch...@apache.org>
Date:   2015-09-25T17:47:06Z

    [FLINK-2767] [scala shell] Add Scala 2.11 support to Scala shell

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2767] [scala shell] Add Scala 2.11 supp...

Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:

    https://github.com/apache/flink/pull/1197#issuecomment-145708723
  
    Thank you for the review @nikste!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2767] [scala shell] Add Scala 2.11 supp...

Posted by chiwanpark <gi...@git.apache.org>.
Github user chiwanpark commented on the pull request:

    https://github.com/apache/flink/pull/1197#issuecomment-145606437
  
    It occured by jline library version mismatching between Scala 2.10 and 2.11. Since Scala 2.11.5, we don't need jline dependency. Scala REPL uses its own jline library. So I upgraded Scala minor version to 2.11.7 and moved jline to Scala 2.10 only dependencies list.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2767] [scala shell] Add Scala 2.11 supp...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/1197


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2767] [scala shell] Add Scala 2.11 supp...

Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:

    https://github.com/apache/flink/pull/1197#issuecomment-144660508
  
    @nikste, can you quickly review this PR?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2767] [scala shell] Add Scala 2.11 supp...

Posted by nikste <gi...@git.apache.org>.
Github user nikste commented on the pull request:

    https://github.com/apache/flink/pull/1197#issuecomment-145510215
  
    For me it says:
    ~~~bash
    Failed to created JLineReader: java.lang.NoClassDefFoundError: jline/console/completer/Completer
    Falling back to SimpleReader.
    ~~~


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2767] [scala shell] Add Scala 2.11 supp...

Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:

    https://github.com/apache/flink/pull/1197#issuecomment-144330468
  
    Cool, looks like a very nice solution.
    
    The package directors structure seems a bit strange for teh file `flink-staging/flink-scala-shell/src/main/scala/org.apache.flink/api/scala/FlinkILoop.scala`. Is that on purpose?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2767] [scala shell] Add Scala 2.11 supp...

Posted by chiwanpark <gi...@git.apache.org>.
Github user chiwanpark commented on the pull request:

    https://github.com/apache/flink/pull/1197#issuecomment-144335229
  
    AFAIK, the directory structure is planned to correct in #1106. But I didn't know #1106 is closed. I'll update the directory structure.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2767] [scala shell] Add Scala 2.11 supp...

Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the pull request:

    https://github.com/apache/flink/pull/1197#issuecomment-146151202
  
    Thanks for the update @chiwanpark!
    LGTM, will merge it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2767] [scala shell] Add Scala 2.11 supp...

Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:

    https://github.com/apache/flink/pull/1197#issuecomment-145488561
  
    I think this looks good, I would merge it...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2767] [scala shell] Add Scala 2.11 supp...

Posted by chiwanpark <gi...@git.apache.org>.
Github user chiwanpark commented on the pull request:

    https://github.com/apache/flink/pull/1197#issuecomment-144336975
  
    The directory name is changed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2767] [scala shell] Add Scala 2.11 supp...

Posted by chiwanpark <gi...@git.apache.org>.
Github user chiwanpark commented on the pull request:

    https://github.com/apache/flink/pull/1197#issuecomment-145509803
  
    Oh, I'll investigate it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2767] [scala shell] Add Scala 2.11 supp...

Posted by nikste <gi...@git.apache.org>.
Github user nikste commented on the pull request:

    https://github.com/apache/flink/pull/1197#issuecomment-145509252
  
    Code looks fine. However, I noticed if I compile the code (for scala version 2.11), and start up the scala shell manually (./start-scala-shell.sh), the autocomplete function (tab) and history (arrow up) are not working anymore.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---