You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2016/08/11 09:41:47 UTC
[kudu-CR] Clarify that minor delta compaction is for REDOs
Hello Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/3944
to review the following change.
Change subject: Clarify that minor delta compaction is for REDOs
......................................................................
Clarify that minor delta compaction is for REDOs
This just clarifies docs and comments around minor delta compaction, as
it relates to the current implementation.
Change-Id: I6e7f3822f3216c53818c082a03f1a1e5c98639d8
---
M docs/design-docs/tablet.md
M src/kudu/tablet/delta_tracker.cc
M src/kudu/tablet/delta_tracker.h
M src/kudu/tablet/deltafile.cc
M src/kudu/tablet/tablet.h
5 files changed, 13 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/44/3944/1
--
To view, visit http://gerrit.cloudera.org:8080/3944
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6e7f3822f3216c53818c082a03f1a1e5c98639d8
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Clarify that delta compaction is for REDOs
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: Clarify that delta compaction is for REDOs
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3944/1/src/kudu/tablet/tablet.h
File src/kudu/tablet/tablet.h:
Line 286: // issues a delta compaction.
> Because the method takes a parameter indicating the type of compaction (min
oh, doh :)
--
To view, visit http://gerrit.cloudera.org:8080/3944
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e7f3822f3216c53818c082a03f1a1e5c98639d8
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] Clarify that delta compaction is for REDOs
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3944
to look at the new patch set (#2).
Change subject: Clarify that delta compaction is for REDOs
......................................................................
Clarify that delta compaction is for REDOs
This just clarifies docs and comments around delta compaction, as
it relates to the current implementation.
Change-Id: I6e7f3822f3216c53818c082a03f1a1e5c98639d8
---
M docs/design-docs/tablet.md
M src/kudu/tablet/delta_tracker.cc
M src/kudu/tablet/delta_tracker.h
M src/kudu/tablet/deltafile.cc
M src/kudu/tablet/tablet.h
5 files changed, 24 insertions(+), 18 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/44/3944/2
--
To view, visit http://gerrit.cloudera.org:8080/3944
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6e7f3822f3216c53818c082a03f1a1e5c98639d8
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Clarify that minor delta compaction is for REDOs
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: Clarify that minor delta compaction is for REDOs
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/3944/1/src/kudu/tablet/tablet.h
File src/kudu/tablet/tablet.h:
Line 286: // issues a delta compaction.
why did you remove 'minor' here?
--
To view, visit http://gerrit.cloudera.org:8080/3944
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e7f3822f3216c53818c082a03f1a1e5c98639d8
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] Clarify that minor delta compaction is for REDOs
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: Clarify that minor delta compaction is for REDOs
......................................................................
Patch Set 1:
(1 comment)
actually i have a couple more changes i want to make
http://gerrit.cloudera.org:8080/#/c/3944/1/src/kudu/tablet/tablet.h
File src/kudu/tablet/tablet.h:
Line 286: // issues a delta compaction.
> why did you remove 'minor' here?
Because the method takes a parameter indicating the type of compaction (minor or major)
--
To view, visit http://gerrit.cloudera.org:8080/3944
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e7f3822f3216c53818c082a03f1a1e5c98639d8
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] Clarify that delta compaction is for REDOs
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: Clarify that delta compaction is for REDOs
......................................................................
Patch Set 2:
Build Started http://104.196.14.100/job/kudu-gerrit/2818/
--
To view, visit http://gerrit.cloudera.org:8080/3944
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e7f3822f3216c53818c082a03f1a1e5c98639d8
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Clarify that delta compaction is for REDOs
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged.
Change subject: Clarify that delta compaction is for REDOs
......................................................................
Clarify that delta compaction is for REDOs
This just clarifies docs and comments around delta compaction, as
it relates to the current implementation.
Change-Id: I6e7f3822f3216c53818c082a03f1a1e5c98639d8
Reviewed-on: http://gerrit.cloudera.org:8080/3944
Reviewed-by: Todd Lipcon <to...@apache.org>
Tested-by: Kudu Jenkins
---
M docs/design-docs/tablet.md
M src/kudu/tablet/delta_tracker.cc
M src/kudu/tablet/delta_tracker.h
M src/kudu/tablet/deltafile.cc
M src/kudu/tablet/tablet.h
5 files changed, 24 insertions(+), 18 deletions(-)
Approvals:
Todd Lipcon: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/3944
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6e7f3822f3216c53818c082a03f1a1e5c98639d8
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Clarify that minor delta compaction is for REDOs
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: Clarify that minor delta compaction is for REDOs
......................................................................
Patch Set 1:
Build Started http://104.196.14.100/job/kudu-gerrit/2814/
--
To view, visit http://gerrit.cloudera.org:8080/3944
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e7f3822f3216c53818c082a03f1a1e5c98639d8
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Clarify that delta compaction is for REDOs
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: Clarify that delta compaction is for REDOs
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3944
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e7f3822f3216c53818c082a03f1a1e5c98639d8
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No