You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Jing Zhao (JIRA)" <ji...@apache.org> on 2012/11/04 20:08:12 UTC
[jira] [Created] (HDFS-4147) Deletion of snapshottable dir with
snapshots should fail
Jing Zhao created HDFS-4147:
-------------------------------
Summary: Deletion of snapshottable dir with snapshots should fail
Key: HDFS-4147
URL: https://issues.apache.org/jira/browse/HDFS-4147
Project: Hadoop HDFS
Issue Type: Sub-task
Reporter: Jing Zhao
Assignee: Jing Zhao
Deletion of snapshottable dir with snapshots should fail.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-4147) Deletion of snapshottable dir with
snapshots should fail
Posted by "Jing Zhao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-4147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jing Zhao updated HDFS-4147:
----------------------------
Attachment: HDFS-4147.002.patch
Thanks for the comments Nicholas! New patch uploaded.
> Deletion of snapshottable dir with snapshots should fail
> --------------------------------------------------------
>
> Key: HDFS-4147
> URL: https://issues.apache.org/jira/browse/HDFS-4147
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: data-node, name-node
> Reporter: Jing Zhao
> Assignee: Jing Zhao
> Attachments: HDFS-4147.001.patch, HDFS-4147.002.patch
>
>
> Deletion of snapshottable dir with snapshots should fail.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-4147) Deletion of snapshottable dir with
snapshots should fail
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-4147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13490337#comment-13490337 ]
Tsz Wo (Nicholas), SZE commented on HDFS-4147:
----------------------------------------------
We cannot throw IOException in unprotectedDelete since it is also used by edit log loading. The check should be done before it.
> Deletion of snapshottable dir with snapshots should fail
> --------------------------------------------------------
>
> Key: HDFS-4147
> URL: https://issues.apache.org/jira/browse/HDFS-4147
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: data-node, name-node
> Reporter: Jing Zhao
> Assignee: Jing Zhao
> Attachments: HDFS-4147.001.patch
>
>
> Deletion of snapshottable dir with snapshots should fail.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-4147) Deletion of snapshottable dir with
snapshots should fail
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-4147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HDFS-4147:
-----------------------------------------
Component/s: (was: data-node)
Hadoop Flags: Reviewed
+1 patch looks good.
> Deletion of snapshottable dir with snapshots should fail
> --------------------------------------------------------
>
> Key: HDFS-4147
> URL: https://issues.apache.org/jira/browse/HDFS-4147
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: name-node
> Reporter: Jing Zhao
> Assignee: Jing Zhao
> Fix For: Snapshot (HDFS-2802)
>
> Attachments: HDFS-4147.001.patch, HDFS-4147.002.patch
>
>
> Deletion of snapshottable dir with snapshots should fail.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-4147) Deletion of snapshottable dir with
snapshots should fail
Posted by "Jing Zhao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-4147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jing Zhao updated HDFS-4147:
----------------------------
Attachment: HDFS-4147.001.patch
Initial patch for this.
> Deletion of snapshottable dir with snapshots should fail
> --------------------------------------------------------
>
> Key: HDFS-4147
> URL: https://issues.apache.org/jira/browse/HDFS-4147
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: data-node, name-node
> Reporter: Jing Zhao
> Assignee: Jing Zhao
> Attachments: HDFS-4147.001.patch
>
>
> Deletion of snapshottable dir with snapshots should fail.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-4147) Deletion of snapshottable dir with
snapshots should fail
Posted by "Jing Zhao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-4147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jing Zhao updated HDFS-4147:
----------------------------
Attachment: HDFS-snapshot-check-rename.patch
The same check should also be applied to rename when the destination directory is snapshottable and has snapshots (since the destination directory needs to be deleted).
> Deletion of snapshottable dir with snapshots should fail
> --------------------------------------------------------
>
> Key: HDFS-4147
> URL: https://issues.apache.org/jira/browse/HDFS-4147
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: name-node
> Reporter: Jing Zhao
> Assignee: Jing Zhao
> Fix For: Snapshot (HDFS-2802)
>
> Attachments: HDFS-4147.001.patch, HDFS-4147.002.patch, HDFS-snapshot-check-rename.patch
>
>
> Deletion of snapshottable dir with snapshots should fail.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HDFS-4147) Deletion of snapshottable dir with
snapshots should fail
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-4147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE resolved HDFS-4147.
------------------------------------------
Resolution: Fixed
Fix Version/s: Snapshot (HDFS-2802)
I have committed this. Thanks, Jing!
> Deletion of snapshottable dir with snapshots should fail
> --------------------------------------------------------
>
> Key: HDFS-4147
> URL: https://issues.apache.org/jira/browse/HDFS-4147
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: name-node
> Reporter: Jing Zhao
> Assignee: Jing Zhao
> Fix For: Snapshot (HDFS-2802)
>
> Attachments: HDFS-4147.001.patch, HDFS-4147.002.patch
>
>
> Deletion of snapshottable dir with snapshots should fail.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira