[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #8993: [log] fix, log model view permissions

[GitBox <gi...@apache.org>]

dpgaspar commented on a change in pull request #8993: [log] fix, log model view permissions
URL: https://github.com/apache/incubator-superset/pull/8993#discussion_r369997149
 
 

 ##########
 File path: tests/security_tests.py
 ##########
 @@ -594,11 +594,16 @@ def test_is_admin_only(self):
             )
         )
 
-        self.assertTrue(
-            security_manager._is_admin_only(
-                security_manager.find_permission_view_menu("can_delete", "DatabaseView")
+        log_permissions = ["can_list", "can_show", "can_add", "can_edit", "can_delete"]
 
 Review comment:
   Right! but that is being handled on #8960. I would merge #8960 first then on the solution found adapt this change to it, or merge this and then make the change on #8960 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org