You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/08/10 08:28:23 UTC

[GitHub] [spark] ulysses-you commented on a diff in pull request #37415: [SPARK-40020][SQL] Centralize the code of qualifying identifiers in SessionCatalog

ulysses-you commented on code in PR #37415:
URL: https://github.com/apache/spark/pull/37415#discussion_r942169914


##########
sql/core/src/test/resources/sql-tests/results/explain-aqe.sql.out:
##########
@@ -909,7 +909,7 @@ Execute CreateViewCommand (1)
 Output: []
 
 (2) CreateViewCommand
-Arguments: `spark_catalog`.`default`.`explain_view`, SELECT key, val FROM explain_temp1, false, false, PersistedView, true

Review Comment:
   it seems we can distinguish if the target view type of CreateViewCommand is temp ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org