You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2015/10/23 18:38:12 UTC
Re: Review Request 38218: Quota: Extended the Allocator interface with
quota-related methods.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38218/
-----------------------------------------------------------
(Updated Oct. 23, 2015, 4:38 p.m.)
Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere.
Bugs: MESOS-3716
https://issues.apache.org/jira/browse/MESOS-3716
Repository: mesos
Description
-------
See summary.
Diffs
-----
include/mesos/master/allocator.hpp dbceb53a3accd32762d09785ecae06667c3cb611
src/master/allocator/mesos/allocator.hpp c5375aa89b210e46c41ac7d68d119749de15d2f5
src/master/allocator/mesos/hierarchical.hpp cfd937ba306273c24fb5337dfeb1a15e1545169b
src/master/allocator/mesos/hierarchical.cpp f4e4a123d3da0442e8b0b0ad14d1ee760752ba36
src/tests/mesos.hpp 3e58b454c75a2ab9f8b4a29785fa823afefd0c8a
Diff: https://reviews.apache.org/r/38218/diff/
Testing
-------
make check (Mac OS X 10.10.4)
Thanks,
Alexander Rukletsov
Re: Review Request 38218: Quota: Extended the Allocator interface with
quota-related methods.
Posted by Alexander Rukletsov <ru...@gmail.com>.
> On Nov. 5, 2015, 7:09 p.m., Joseph Wu wrote:
> > include/mesos/master/allocator.hpp, lines 355-356
> > <https://reviews.apache.org/r/38218/diff/7/?file=1105051#file1105051line355>
> >
> > This bit is somewhat unclear:
> > "the group of roles with quota set" sounds like it is referring to an argument, but it's actually referring to the implementation, right?
Yeah, let me try to re-phrase it.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38218/#review105288
-----------------------------------------------------------
On Nov. 5, 2015, 7:29 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38218/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2015, 7:29 p.m.)
>
>
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3716
> https://issues.apache.org/jira/browse/MESOS-3716
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/master/allocator.hpp dbceb53a3accd32762d09785ecae06667c3cb611
> src/master/allocator/mesos/allocator.hpp c5375aa89b210e46c41ac7d68d119749de15d2f5
> src/master/allocator/mesos/hierarchical.hpp cfd937ba306273c24fb5337dfeb1a15e1545169b
> src/master/allocator/mesos/hierarchical.cpp f4e4a123d3da0442e8b0b0ad14d1ee760752ba36
> src/tests/mesos.hpp 3e58b454c75a2ab9f8b4a29785fa823afefd0c8a
>
> Diff: https://reviews.apache.org/r/38218/diff/
>
>
> Testing
> -------
>
> make check (Mac OS X 10.10.4)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 38218: Quota: Extended the Allocator interface with
quota-related methods.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38218/#review105288
-----------------------------------------------------------
include/mesos/master/allocator.hpp (lines 355 - 356)
<https://reviews.apache.org/r/38218/#comment163799>
This bit is somewhat unclear:
"the group of roles with quota set" sounds like it is referring to an argument, but it's actually referring to the implementation, right?
include/mesos/master/allocator.hpp (lines 370 - 371)
<https://reviews.apache.org/r/38218/#comment163800>
Suggestion: s/with quota and without/with or without quota/
- Joseph Wu
On Oct. 23, 2015, 9:38 a.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38218/
> -----------------------------------------------------------
>
> (Updated Oct. 23, 2015, 9:38 a.m.)
>
>
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere.
>
>
> Bugs: MESOS-3716
> https://issues.apache.org/jira/browse/MESOS-3716
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/master/allocator.hpp dbceb53a3accd32762d09785ecae06667c3cb611
> src/master/allocator/mesos/allocator.hpp c5375aa89b210e46c41ac7d68d119749de15d2f5
> src/master/allocator/mesos/hierarchical.hpp cfd937ba306273c24fb5337dfeb1a15e1545169b
> src/master/allocator/mesos/hierarchical.cpp f4e4a123d3da0442e8b0b0ad14d1ee760752ba36
> src/tests/mesos.hpp 3e58b454c75a2ab9f8b4a29785fa823afefd0c8a
>
> Diff: https://reviews.apache.org/r/38218/diff/
>
>
> Testing
> -------
>
> make check (Mac OS X 10.10.4)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 38218: Quota: Extended the Allocator interface with
quota-related methods.
Posted by Alexander Rukletsov <ru...@gmail.com>.
> On Nov. 2, 2015, 2:22 p.m., Joerg Schad wrote:
> > src/master/allocator/mesos/allocator.hpp, line 268
> > <https://reviews.apache.org/r/38218/diff/7/?file=1105052#file1105052line268>
> >
> > Could we add a todo for updateQuota()? In my opinion this would make it easier to understand both the MVP semantic as well as the post mvp plans. Same below.
I'm not sure we plan a triad `set`, `update`, `remove` is an agreed design for the post MVP. I can envision the situation we agree to use, say, `update` and `remove`. Hence I'm reluctant to add a todo here.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38218/#review104710
-----------------------------------------------------------
On Nov. 5, 2015, 7:29 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38218/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2015, 7:29 p.m.)
>
>
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3716
> https://issues.apache.org/jira/browse/MESOS-3716
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/master/allocator.hpp dbceb53a3accd32762d09785ecae06667c3cb611
> src/master/allocator/mesos/allocator.hpp c5375aa89b210e46c41ac7d68d119749de15d2f5
> src/master/allocator/mesos/hierarchical.hpp cfd937ba306273c24fb5337dfeb1a15e1545169b
> src/master/allocator/mesos/hierarchical.cpp f4e4a123d3da0442e8b0b0ad14d1ee760752ba36
> src/tests/mesos.hpp 3e58b454c75a2ab9f8b4a29785fa823afefd0c8a
>
> Diff: https://reviews.apache.org/r/38218/diff/
>
>
> Testing
> -------
>
> make check (Mac OS X 10.10.4)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 38218: Quota: Extended the Allocator interface with
quota-related methods.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38218/#review104710
-----------------------------------------------------------
Ship it!
src/master/allocator/mesos/allocator.hpp (line 268)
<https://reviews.apache.org/r/38218/#comment162961>
Could we add a todo for updateQuota()? In my opinion this would make it easier to understand both the MVP semantic as well as the post mvp plans. Same below.
src/tests/mesos.hpp (line 1652)
<https://reviews.apache.org/r/38218/#comment162962>
Why not single line?
- Joerg Schad
On Oct. 23, 2015, 4:38 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38218/
> -----------------------------------------------------------
>
> (Updated Oct. 23, 2015, 4:38 p.m.)
>
>
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere.
>
>
> Bugs: MESOS-3716
> https://issues.apache.org/jira/browse/MESOS-3716
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/master/allocator.hpp dbceb53a3accd32762d09785ecae06667c3cb611
> src/master/allocator/mesos/allocator.hpp c5375aa89b210e46c41ac7d68d119749de15d2f5
> src/master/allocator/mesos/hierarchical.hpp cfd937ba306273c24fb5337dfeb1a15e1545169b
> src/master/allocator/mesos/hierarchical.cpp f4e4a123d3da0442e8b0b0ad14d1ee760752ba36
> src/tests/mesos.hpp 3e58b454c75a2ab9f8b4a29785fa823afefd0c8a
>
> Diff: https://reviews.apache.org/r/38218/diff/
>
>
> Testing
> -------
>
> make check (Mac OS X 10.10.4)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 38218: Quota: Extended the Allocator interface with
quota-related methods.
Posted by Alexander Rukletsov <ru...@gmail.com>.
> On Oct. 25, 2015, 12:46 p.m., Qian Zhang wrote:
> > include/mesos/master/allocator.hpp, line 357
> > <https://reviews.apache.org/r/38218/diff/7/?file=1105051#file1105051line357>
> >
> > Why do we assume quota for the given role is not set prior to the call? I thought we support setting quota for a role many time, i.e., the subsequent call will overwrite the quota set by the previous call, right?
Nope. "Overwriting" or updating quota is not straightforward and will be done in the next iterations, which means there will be introduced an `updateQuota()` method.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38218/#review103953
-----------------------------------------------------------
On Oct. 23, 2015, 4:38 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38218/
> -----------------------------------------------------------
>
> (Updated Oct. 23, 2015, 4:38 p.m.)
>
>
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere.
>
>
> Bugs: MESOS-3716
> https://issues.apache.org/jira/browse/MESOS-3716
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/master/allocator.hpp dbceb53a3accd32762d09785ecae06667c3cb611
> src/master/allocator/mesos/allocator.hpp c5375aa89b210e46c41ac7d68d119749de15d2f5
> src/master/allocator/mesos/hierarchical.hpp cfd937ba306273c24fb5337dfeb1a15e1545169b
> src/master/allocator/mesos/hierarchical.cpp f4e4a123d3da0442e8b0b0ad14d1ee760752ba36
> src/tests/mesos.hpp 3e58b454c75a2ab9f8b4a29785fa823afefd0c8a
>
> Diff: https://reviews.apache.org/r/38218/diff/
>
>
> Testing
> -------
>
> make check (Mac OS X 10.10.4)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 38218: Quota: Extended the Allocator interface with
quota-related methods.
Posted by Bernd Mathiske <be...@mesosphere.io>.
> On Oct. 25, 2015, 5:46 a.m., Qian Zhang wrote:
> > include/mesos/master/allocator.hpp, line 357
> > <https://reviews.apache.org/r/38218/diff/7/?file=1105051#file1105051line357>
> >
> > Why do we assume quota for the given role is not set prior to the call? I thought we support setting quota for a role many time, i.e., the subsequent call will overwrite the quota set by the previous call, right?
>
> Alexander Rukletsov wrote:
> Nope. "Overwriting" or updating quota is not straightforward and will be done in the next iterations, which means there will be introduced an `updateQuota()` method.
IMHO having a setQuota call that assumes no prior quota is superfluous once we have implemented updateQuota, which will be able to deal with any situation. But it is OK for this first interation to get there. Let's revisit this later.
- Bernd
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38218/#review103953
-----------------------------------------------------------
On Oct. 23, 2015, 9:38 a.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38218/
> -----------------------------------------------------------
>
> (Updated Oct. 23, 2015, 9:38 a.m.)
>
>
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere.
>
>
> Bugs: MESOS-3716
> https://issues.apache.org/jira/browse/MESOS-3716
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/master/allocator.hpp dbceb53a3accd32762d09785ecae06667c3cb611
> src/master/allocator/mesos/allocator.hpp c5375aa89b210e46c41ac7d68d119749de15d2f5
> src/master/allocator/mesos/hierarchical.hpp cfd937ba306273c24fb5337dfeb1a15e1545169b
> src/master/allocator/mesos/hierarchical.cpp f4e4a123d3da0442e8b0b0ad14d1ee760752ba36
> src/tests/mesos.hpp 3e58b454c75a2ab9f8b4a29785fa823afefd0c8a
>
> Diff: https://reviews.apache.org/r/38218/diff/
>
>
> Testing
> -------
>
> make check (Mac OS X 10.10.4)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 38218: Quota: Extended the Allocator interface with
quota-related methods.
Posted by Qian Zhang <zh...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38218/#review103953
-----------------------------------------------------------
include/mesos/master/allocator.hpp (line 357)
<https://reviews.apache.org/r/38218/#comment162060>
Why do we assume quota for the given role is not set prior to the call? I thought we support setting quota for a role many time, i.e., the subsequent call will overwrite the quota set by the previous call, right?
- Qian Zhang
On Oct. 24, 2015, 12:38 a.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38218/
> -----------------------------------------------------------
>
> (Updated Oct. 24, 2015, 12:38 a.m.)
>
>
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere.
>
>
> Bugs: MESOS-3716
> https://issues.apache.org/jira/browse/MESOS-3716
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/master/allocator.hpp dbceb53a3accd32762d09785ecae06667c3cb611
> src/master/allocator/mesos/allocator.hpp c5375aa89b210e46c41ac7d68d119749de15d2f5
> src/master/allocator/mesos/hierarchical.hpp cfd937ba306273c24fb5337dfeb1a15e1545169b
> src/master/allocator/mesos/hierarchical.cpp f4e4a123d3da0442e8b0b0ad14d1ee760752ba36
> src/tests/mesos.hpp 3e58b454c75a2ab9f8b4a29785fa823afefd0c8a
>
> Diff: https://reviews.apache.org/r/38218/diff/
>
>
> Testing
> -------
>
> make check (Mac OS X 10.10.4)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 38218: Quota: Extended the Allocator interface with
quota-related methods.
Posted by Alexander Rukletsov <ru...@gmail.com>.
> On Nov. 4, 2015, 11:24 p.m., Joris Van Remoortere wrote:
> > include/mesos/master/allocator.hpp, lines 332-347
> > <https://reviews.apache.org/r/38218/diff/7/?file=1105051#file1105051line332>
> >
> > do you want to re-order these (here or in the implementations) so that the function name order stay consistent between classes / interface?
> > Not your fault :-)
Good catch! I'll re-order here, as it seems all others are in sync.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38218/#review105175
-----------------------------------------------------------
On Nov. 5, 2015, 7:29 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38218/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2015, 7:29 p.m.)
>
>
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3716
> https://issues.apache.org/jira/browse/MESOS-3716
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/master/allocator.hpp dbceb53a3accd32762d09785ecae06667c3cb611
> src/master/allocator/mesos/allocator.hpp c5375aa89b210e46c41ac7d68d119749de15d2f5
> src/master/allocator/mesos/hierarchical.hpp cfd937ba306273c24fb5337dfeb1a15e1545169b
> src/master/allocator/mesos/hierarchical.cpp f4e4a123d3da0442e8b0b0ad14d1ee760752ba36
> src/tests/mesos.hpp 3e58b454c75a2ab9f8b4a29785fa823afefd0c8a
>
> Diff: https://reviews.apache.org/r/38218/diff/
>
>
> Testing
> -------
>
> make check (Mac OS X 10.10.4)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 38218: Quota: Extended the Allocator interface with
quota-related methods.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38218/#review105175
-----------------------------------------------------------
Ship it!
include/mesos/master/allocator.hpp (lines 332 - 347)
<https://reviews.apache.org/r/38218/#comment163599>
do you want to re-order these (here or in the implementations) so that the function name order stay consistent between classes / interface?
Not your fault :-)
include/mesos/master/allocator.hpp (line 374)
<https://reviews.apache.org/r/38218/#comment163594>
s/prior/prior to/
- Joris Van Remoortere
On Oct. 23, 2015, 4:38 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38218/
> -----------------------------------------------------------
>
> (Updated Oct. 23, 2015, 4:38 p.m.)
>
>
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere.
>
>
> Bugs: MESOS-3716
> https://issues.apache.org/jira/browse/MESOS-3716
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/master/allocator.hpp dbceb53a3accd32762d09785ecae06667c3cb611
> src/master/allocator/mesos/allocator.hpp c5375aa89b210e46c41ac7d68d119749de15d2f5
> src/master/allocator/mesos/hierarchical.hpp cfd937ba306273c24fb5337dfeb1a15e1545169b
> src/master/allocator/mesos/hierarchical.cpp f4e4a123d3da0442e8b0b0ad14d1ee760752ba36
> src/tests/mesos.hpp 3e58b454c75a2ab9f8b4a29785fa823afefd0c8a
>
> Diff: https://reviews.apache.org/r/38218/diff/
>
>
> Testing
> -------
>
> make check (Mac OS X 10.10.4)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 38218: Quota: Extended the Allocator interface with
quota-related methods.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38218/#review103905
-----------------------------------------------------------
include/mesos/master/allocator.hpp (line 360)
<https://reviews.apache.org/r/38218/#comment162020>
Agree would be helpful.
include/mesos/master/allocator.hpp (line 377)
<https://reviews.apache.org/r/38218/#comment162019>
Agree, this would be helpful.
- Joerg Schad
On Oct. 23, 2015, 4:38 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38218/
> -----------------------------------------------------------
>
> (Updated Oct. 23, 2015, 4:38 p.m.)
>
>
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere.
>
>
> Bugs: MESOS-3716
> https://issues.apache.org/jira/browse/MESOS-3716
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/master/allocator.hpp dbceb53a3accd32762d09785ecae06667c3cb611
> src/master/allocator/mesos/allocator.hpp c5375aa89b210e46c41ac7d68d119749de15d2f5
> src/master/allocator/mesos/hierarchical.hpp cfd937ba306273c24fb5337dfeb1a15e1545169b
> src/master/allocator/mesos/hierarchical.cpp f4e4a123d3da0442e8b0b0ad14d1ee760752ba36
> src/tests/mesos.hpp 3e58b454c75a2ab9f8b4a29785fa823afefd0c8a
>
> Diff: https://reviews.apache.org/r/38218/diff/
>
>
> Testing
> -------
>
> make check (Mac OS X 10.10.4)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 38218: Quota: Extended the Allocator interface with
quota-related methods.
Posted by Klaus Ma <kl...@gmail.com>.
> On Oct. 25, 2015, 8:10 a.m., Klaus Ma wrote:
> > include/mesos/master/allocator.hpp, line 358
> > <https://reviews.apache.org/r/38218/diff/7/?file=1105051#file1105051line358>
> >
> > It said Mesos master will also validate the quota request in design document; should we clarify which part is covered by Mesos master and which part should be covered by allocator? For example, according to this comments, empty role will pass master's checking; it's allocator's resposibility to accept or reject it.
>
> Alexander Rukletsov wrote:
> A hard thing here is to specify, what a *custom* allocator should check. I try to impose as few restrictions as possible. The part of the comment you refer to says that if an internal invariant (double `setQuota()` call) is violated.
That's OK to me :).
- Klaus
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38218/#review103910
-----------------------------------------------------------
On Nov. 6, 2015, 3:29 a.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38218/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2015, 3:29 a.m.)
>
>
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3716
> https://issues.apache.org/jira/browse/MESOS-3716
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/master/allocator.hpp dbceb53a3accd32762d09785ecae06667c3cb611
> src/master/allocator/mesos/allocator.hpp c5375aa89b210e46c41ac7d68d119749de15d2f5
> src/master/allocator/mesos/hierarchical.hpp cfd937ba306273c24fb5337dfeb1a15e1545169b
> src/master/allocator/mesos/hierarchical.cpp f4e4a123d3da0442e8b0b0ad14d1ee760752ba36
> src/tests/mesos.hpp 3e58b454c75a2ab9f8b4a29785fa823afefd0c8a
>
> Diff: https://reviews.apache.org/r/38218/diff/
>
>
> Testing
> -------
>
> make check (Mac OS X 10.10.4)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 38218: Quota: Extended the Allocator interface with
quota-related methods.
Posted by Alexander Rukletsov <ru...@gmail.com>.
> On Oct. 25, 2015, 12:10 a.m., Klaus Ma wrote:
> > include/mesos/master/allocator.hpp, line 358
> > <https://reviews.apache.org/r/38218/diff/7/?file=1105051#file1105051line358>
> >
> > It said Mesos master will also validate the quota request in design document; should we clarify which part is covered by Mesos master and which part should be covered by allocator? For example, according to this comments, empty role will pass master's checking; it's allocator's resposibility to accept or reject it.
A hard thing here is to specify, what a *custom* allocator should check. I try to impose as few restrictions as possible. The part of the comment you refer to says that if an internal invariant (double `setQuota()` call) is violated.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38218/#review103910
-----------------------------------------------------------
On Oct. 23, 2015, 4:38 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38218/
> -----------------------------------------------------------
>
> (Updated Oct. 23, 2015, 4:38 p.m.)
>
>
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere.
>
>
> Bugs: MESOS-3716
> https://issues.apache.org/jira/browse/MESOS-3716
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/master/allocator.hpp dbceb53a3accd32762d09785ecae06667c3cb611
> src/master/allocator/mesos/allocator.hpp c5375aa89b210e46c41ac7d68d119749de15d2f5
> src/master/allocator/mesos/hierarchical.hpp cfd937ba306273c24fb5337dfeb1a15e1545169b
> src/master/allocator/mesos/hierarchical.cpp f4e4a123d3da0442e8b0b0ad14d1ee760752ba36
> src/tests/mesos.hpp 3e58b454c75a2ab9f8b4a29785fa823afefd0c8a
>
> Diff: https://reviews.apache.org/r/38218/diff/
>
>
> Testing
> -------
>
> make check (Mac OS X 10.10.4)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 38218: Quota: Extended the Allocator interface with
quota-related methods.
Posted by Klaus Ma <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38218/#review103910
-----------------------------------------------------------
include/mesos/master/allocator.hpp (line 358)
<https://reviews.apache.org/r/38218/#comment162022>
It said Mesos master will also validate the quota request in design document; should we clarify which part is covered by Mesos master and which part should be covered by allocator? For example, according to this comments, empty role will pass master's checking; it's allocator's resposibility to accept or reject it.
- Klaus Ma
On Oct. 24, 2015, 12:38 a.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38218/
> -----------------------------------------------------------
>
> (Updated Oct. 24, 2015, 12:38 a.m.)
>
>
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere.
>
>
> Bugs: MESOS-3716
> https://issues.apache.org/jira/browse/MESOS-3716
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/master/allocator.hpp dbceb53a3accd32762d09785ecae06667c3cb611
> src/master/allocator/mesos/allocator.hpp c5375aa89b210e46c41ac7d68d119749de15d2f5
> src/master/allocator/mesos/hierarchical.hpp cfd937ba306273c24fb5337dfeb1a15e1545169b
> src/master/allocator/mesos/hierarchical.cpp f4e4a123d3da0442e8b0b0ad14d1ee760752ba36
> src/tests/mesos.hpp 3e58b454c75a2ab9f8b4a29785fa823afefd0c8a
>
> Diff: https://reviews.apache.org/r/38218/diff/
>
>
> Testing
> -------
>
> make check (Mac OS X 10.10.4)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>