[GitHub] [tvm] Lyken17 commented on pull request #10867: Update gradle version and other changes in android apps

[GitBox <gi...@apache.org>]

Lyken17 commented on PR #10867:
URL: https://github.com/apache/tvm/pull/10867#issuecomment-1106712651

   Sry for being late, was busy for some conference experiments. 
   
   I rarely code in Java so I am afraid that I cannot comment much on the modified code. But I have seen @argrento update `javah` command to `javac -h`. This was the cause of building error when using latest JDK https://discuss.tvm.apache.org/t/jvmpkg-fails-to-build-on-mac-osx/11578/2
   
   In my build machine (Intel Mac Mini), JDK version 1.8.0_312, Clang 13.0.0, all three projects `android_camera`, `android_rpc`, `android_camera`, `android_deploy`  can build successfully without error.
   
   ```
   (base) ligeng@Lgs-Mac-mini➜  tvm2 git:(gradle-update) ✗ gh pr checkout 10867
   (base) ligeng@Lgs-Mac-mini➜  tvm2 git:(gradle-update) ✗ java -version
   openjdk version "1.8.0_312"
   OpenJDK Runtime Environment (build 1.8.0_312-bre_2021_10_21_00_49-b00)
   OpenJDK 64-Bit Server VM (build 25.312-b00, mixed mode)
   
   (base) ligeng@Lgs-Mac-mini➜  tvm2 git:(gradle-update) ✗ clang --version
   Homebrew clang version 13.0.0
   Target: x86_64-apple-darwin19.6.0
   Thread model: posix
   InstalledDir: /usr/local/opt/llvm/bin
   
   (base) ligeng@Lgs-Mac-mini➜  tvm2 git:(gradle-update) ✗ llvm-config --version
   13.0.0
   ```
   
   Due to my limited (human) bandwidth, I may be able to test 2~3 more JDK / NDK versions. Would it be possible to setup CI  auto-build test for the three demos? @argrento 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org