[GitHub] [incubator-doris] morningman commented on a change in pull request #2877: [FIX] fix a bug when using grouping set without all column in a grouping set item

[GitBox <gi...@apache.org>]

morningman commented on a change in pull request #2877: [FIX] fix a bug when using grouping set without all column in a grouping set item
URL: https://github.com/apache/incubator-doris/pull/2877#discussion_r377635413
 
 

 ##########
 File path: gensrc/thrift/PlanNodes.thrift
 ##########
 @@ -396,6 +396,8 @@ struct TRepeatNode {
   3: required list<i64> repeat_id_list
   // A list of integer list, it indicates the position of the grouping virtual slot.
   4: required list<list<i64>> grouping_list
+  // A list of all slot
+  5: required set<Types.TSlotId> all_slot_id
 
 Review comment:
   All newly added fields should be optional, or it will cause incompatible.
   And name should be `all_slot_ids`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org