You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/02/12 18:19:00 UTC

[GitHub] [ignite] Mmuzaf opened a new pull request #8796: IGNITE-14166 Fix public javadocs of metrics registry links

Mmuzaf opened a new pull request #8796:
URL: https://github.com/apache/ignite/pull/8796


   Thank you for submitting the pull request to the Apache Ignite.
   
   In order to streamline the review of the contribution 
   we ask you to ensure the following steps have been taken:
   
   ### The Contribution Checklist
   - [ ] There is a single JIRA ticket related to the pull request. 
   - [ ] The web-link to the pull request is attached to the JIRA ticket.
   - [ ] The JIRA ticket has the _Patch Available_ state.
   - [ ] The pull request body describes changes that have been made. 
   The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
   - [ ] The pull request title is treated as the final commit message. 
   The following pattern must be used: `IGNITE-XXXX Change summary` where `XXXX` - number of JIRA issue.
   - [ ] A reviewer has been mentioned through the JIRA comments 
   (see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers)) 
   - [ ] The pull request has been checked by the Teamcity Bot and 
   the `green visa` attached to the JIRA ticket (see [TC.Bot: Check PR](https://mtcga.gridgain.com/prs.html))
   
   ### Notes
   - [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
   - [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
   - [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
   - [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
   
   If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com _#ignite_ channel.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] nizhikov commented on a change in pull request #8796: IGNITE-14166 Fix public javadocs of metrics registry links

Posted by GitBox <gi...@apache.org>.
nizhikov commented on a change in pull request #8796:
URL: https://github.com/apache/ignite/pull/8796#discussion_r582186282



##########
File path: modules/core/src/main/java/org/apache/ignite/DataRegionMetricsAdapter.java
##########
@@ -18,12 +18,20 @@
 
 import java.util.ArrayList;
 import java.util.Collection;
-import org.apache.ignite.internal.processors.metric.GridMetricManager;
+import org.apache.ignite.spi.metric.MetricExporterSpi;
+import org.apache.ignite.spi.metric.ReadOnlyMetricManager;
+import org.apache.ignite.spi.metric.ReadOnlyMetricRegistry;
+import org.apache.ignite.spi.metric.jmx.JmxMetricExporterSpi;
 
 /**
  * Converter class from {@link DataRegionMetrics} to legacy {@link MemoryMetrics}.
  *
- * @deprecated Use {@link GridMetricManager} instead.
+ * @deprecated Check the {@link ReadOnlyMetricRegistry} instead.

Review comment:
       ```suggestion
    * @deprecated Check the {@link ReadOnlyMetricRegistry} "io.dataregion.{data_region_name}" instead.
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] Mmuzaf merged pull request #8796: IGNITE-14166 Fix public javadocs of metrics registry links

Posted by GitBox <gi...@apache.org>.
Mmuzaf merged pull request #8796:
URL: https://github.com/apache/ignite/pull/8796


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] nizhikov commented on a change in pull request #8796: IGNITE-14166 Fix public javadocs of metrics registry links

Posted by GitBox <gi...@apache.org>.
nizhikov commented on a change in pull request #8796:
URL: https://github.com/apache/ignite/pull/8796#discussion_r582187472



##########
File path: modules/core/src/main/java/org/apache/ignite/DataStorageMetricsAdapter.java
##########
@@ -16,12 +16,20 @@
 */
 package org.apache.ignite;
 
-import org.apache.ignite.internal.processors.metric.GridMetricManager;
+import org.apache.ignite.spi.metric.MetricExporterSpi;
+import org.apache.ignite.spi.metric.ReadOnlyMetricManager;
+import org.apache.ignite.spi.metric.ReadOnlyMetricRegistry;
+import org.apache.ignite.spi.metric.jmx.JmxMetricExporterSpi;
 
 /**
  * Converter class from {@link DataStorageMetrics} to legacy {@link PersistenceMetrics}.
  *
- * @deprecated Use {@link GridMetricManager} instead.
+ * @deprecated Check the {@link ReadOnlyMetricRegistry} instead.

Review comment:
       ```suggestion
    * @deprecated Check the {@link ReadOnlyMetricRegistry} "io.datastorage" instead.
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] nizhikov commented on a change in pull request #8796: IGNITE-14166 Fix public javadocs of metrics registry links

Posted by GitBox <gi...@apache.org>.
nizhikov commented on a change in pull request #8796:
URL: https://github.com/apache/ignite/pull/8796#discussion_r582190340



##########
File path: modules/core/src/main/java/org/apache/ignite/Ignite.java
##########
@@ -725,6 +727,7 @@ public IgniteLock reentrantLock(String name, boolean failoverSafe, boolean fair,
 
     /**
      * @return {@link DataStorageMetrics} snapshot.
+     * @deprecated Check the {@link ReadOnlyMetricRegistry} instead.

Review comment:
       ```suggestion
        * @deprecated Check the {@link ReadOnlyMetricRegistry} "io.datastorage" instead.
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] nizhikov commented on a change in pull request #8796: IGNITE-14166 Fix public javadocs of metrics registry links

Posted by GitBox <gi...@apache.org>.
nizhikov commented on a change in pull request #8796:
URL: https://github.com/apache/ignite/pull/8796#discussion_r582192041



##########
File path: modules/core/src/main/java/org/apache/ignite/PersistenceMetrics.java
##########
@@ -17,11 +17,12 @@
 package org.apache.ignite;
 
 import org.apache.ignite.configuration.PersistentStoreConfiguration;
+import org.apache.ignite.spi.metric.ReadOnlyMetricRegistry;
 
 /**
  * Persistence metrics used to obtain statistics on persistence.
  *
- * @deprecated Use {@link DataStorageMetrics} instead.
+ * @deprecated Check the {@link ReadOnlyMetricRegistry} instead.

Review comment:
       ```suggestion
    * @deprecated Check the {@link ReadOnlyMetricRegistry} "io.datastorage" instead.
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] nizhikov commented on a change in pull request #8796: IGNITE-14166 Fix public javadocs of metrics registry links

Posted by GitBox <gi...@apache.org>.
nizhikov commented on a change in pull request #8796:
URL: https://github.com/apache/ignite/pull/8796#discussion_r582205651



##########
File path: modules/core/src/main/java/org/apache/ignite/mxbean/CacheMetricsMXBean.java
##########
@@ -21,12 +21,20 @@
 import javax.cache.management.CacheStatisticsMXBean;
 import org.apache.ignite.IgniteCache;
 import org.apache.ignite.cache.CacheMetrics;
-import org.apache.ignite.internal.processors.metric.GridMetricManager;
+import org.apache.ignite.spi.metric.MetricExporterSpi;
+import org.apache.ignite.spi.metric.ReadOnlyMetricManager;
+import org.apache.ignite.spi.metric.ReadOnlyMetricRegistry;
+import org.apache.ignite.spi.metric.jmx.JmxMetricExporterSpi;
 
 /**
  * This interface defines JMX view on {@link IgniteCache}.
  *
- * @deprecated Use {@link GridMetricManager} instead.
+ * @deprecated Check the {@link JmxMetricExporterSpi} instead.

Review comment:
       ```suggestion
    * @deprecated Check the {@link JmxMetricExporterSpi} "cache.{cache_name}" instead.
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] nizhikov commented on a change in pull request #8796: IGNITE-14166 Fix public javadocs of metrics registry links

Posted by GitBox <gi...@apache.org>.
nizhikov commented on a change in pull request #8796:
URL: https://github.com/apache/ignite/pull/8796#discussion_r582186993



##########
File path: modules/core/src/main/java/org/apache/ignite/DataStorageMetrics.java
##########
@@ -17,12 +17,20 @@
 package org.apache.ignite;
 
 import org.apache.ignite.configuration.DataStorageConfiguration;
-import org.apache.ignite.internal.processors.metric.GridMetricManager;
+import org.apache.ignite.spi.metric.MetricExporterSpi;
+import org.apache.ignite.spi.metric.ReadOnlyMetricManager;
+import org.apache.ignite.spi.metric.ReadOnlyMetricRegistry;
+import org.apache.ignite.spi.metric.jmx.JmxMetricExporterSpi;
 
 /**
  * Data storage metrics are used to obtain statistics on persistent store and whole data storage.
  *
- * @deprecated Use {@link GridMetricManager} instead.
+ * @deprecated Check the {@link ReadOnlyMetricRegistry} instead.

Review comment:
       ```suggestion
    * @deprecated Check the {@link ReadOnlyMetricRegistry} "io.datastorage" instead.
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] nizhikov commented on a change in pull request #8796: IGNITE-14166 Fix public javadocs of metrics registry links

Posted by GitBox <gi...@apache.org>.
nizhikov commented on a change in pull request #8796:
URL: https://github.com/apache/ignite/pull/8796#discussion_r582203097



##########
File path: modules/core/src/main/java/org/apache/ignite/mxbean/CacheGroupMetricsMXBean.java
##########
@@ -21,12 +21,20 @@
 import java.util.Map;
 import java.util.Set;
 import org.apache.ignite.internal.processors.cache.CacheGroupContext;
-import org.apache.ignite.internal.processors.metric.GridMetricManager;
+import org.apache.ignite.spi.metric.MetricExporterSpi;
+import org.apache.ignite.spi.metric.ReadOnlyMetricManager;
+import org.apache.ignite.spi.metric.ReadOnlyMetricRegistry;
+import org.apache.ignite.spi.metric.jmx.JmxMetricExporterSpi;
 
 /**
  * This interface defines JMX view on {@link CacheGroupContext}.
  *
- * @deprecated Use {@link GridMetricManager} instead.
+ * @deprecated Check the {@link JmxMetricExporterSpi} instead.

Review comment:
       ```suggestion
    * @deprecated Check the {@link JmxMetricExporterSpi} "cacheGroups.{cache_group_name}" instead.
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] nizhikov commented on a change in pull request #8796: IGNITE-14166 Fix public javadocs of metrics registry links

Posted by GitBox <gi...@apache.org>.
nizhikov commented on a change in pull request #8796:
URL: https://github.com/apache/ignite/pull/8796#discussion_r582185928



##########
File path: modules/core/src/main/java/org/apache/ignite/DataRegionMetrics.java
##########
@@ -47,7 +50,12 @@
  * {@link DataRegionConfiguration#setMetricsEnabled(boolean)} configuration property or
  * {@link DataRegionMetricsMXBean#enableMetrics()} method of a respective JMX bean.
  *
- * @deprecated Use {@link GridMetricManager} instead.
+ * @deprecated Check the {@link ReadOnlyMetricRegistry} instead.

Review comment:
       ```suggestion
    * @deprecated Check the {@link ReadOnlyMetricRegistry} "io.dataregion.{data_region_name}" instead.
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] nizhikov commented on a change in pull request #8796: IGNITE-14166 Fix public javadocs of metrics registry links

Posted by GitBox <gi...@apache.org>.
nizhikov commented on a change in pull request #8796:
URL: https://github.com/apache/ignite/pull/8796#discussion_r582190084



##########
File path: modules/core/src/main/java/org/apache/ignite/Ignite.java
##########
@@ -708,6 +709,7 @@ public IgniteLock reentrantLock(String name, boolean failoverSafe, boolean fair,
      * configured with {@link DataRegionConfiguration configuration} on this Ignite node instance.
      *
      * @return Collection of {@link DataRegionMetrics} snapshots.
+     * @deprecated Check the {@link ReadOnlyMetricRegistry} instead.

Review comment:
       ```suggestion
        * @deprecated Check the {@link ReadOnlyMetricRegistry} "io.dataregion.{data_region_name}" instead.
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] nizhikov commented on a change in pull request #8796: IGNITE-14166 Fix public javadocs of metrics registry links

Posted by GitBox <gi...@apache.org>.
nizhikov commented on a change in pull request #8796:
URL: https://github.com/apache/ignite/pull/8796#discussion_r582191518



##########
File path: modules/core/src/main/java/org/apache/ignite/MemoryMetrics.java
##########
@@ -46,7 +47,7 @@
  * {@link MemoryPolicyConfiguration#setMetricsEnabled(boolean)} configuration property or
  * {@link DataRegionMetricsMXBean#enableMetrics()} method of a respective JMX bean.
  *
- * @deprecated Use {@link DataRegionMetrics} instead.
+ * @deprecated Check the {@link ReadOnlyMetricRegistry} instead.

Review comment:
       ```suggestion
    * @deprecated Check the {@link ReadOnlyMetricRegistry} "io.dataregion.{data_region_name}" instead.
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] nizhikov commented on a change in pull request #8796: IGNITE-14166 Fix public javadocs of metrics registry links

Posted by GitBox <gi...@apache.org>.
nizhikov commented on a change in pull request #8796:
URL: https://github.com/apache/ignite/pull/8796#discussion_r582194234



##########
File path: modules/core/src/main/java/org/apache/ignite/internal/processors/cache/CacheLocalMetricsMXBeanImpl.java
##########
@@ -20,13 +20,21 @@
 import java.util.Collections;
 import org.apache.ignite.IgniteCache;
 import org.apache.ignite.IgniteCheckedException;
-import org.apache.ignite.internal.processors.metric.GridMetricManager;
 import org.apache.ignite.mxbean.CacheMetricsMXBean;
+import org.apache.ignite.spi.metric.MetricExporterSpi;
+import org.apache.ignite.spi.metric.ReadOnlyMetricManager;
+import org.apache.ignite.spi.metric.ReadOnlyMetricRegistry;
+import org.apache.ignite.spi.metric.jmx.JmxMetricExporterSpi;
 
 /**
  * Management bean that provides access to {@link IgniteCache IgniteCache}.
  *
- * @deprecated Use {@link GridMetricManager} instead.
+ * @deprecated Check the {@link JmxMetricExporterSpi} instead.

Review comment:
       ```suggestion
    * @deprecated Check the {@link JmxMetricExporterSpi} "cache.{cache_name}" instead.
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] nizhikov commented on a change in pull request #8796: IGNITE-14166 Fix public javadocs of metrics registry links

Posted by GitBox <gi...@apache.org>.
nizhikov commented on a change in pull request #8796:
URL: https://github.com/apache/ignite/pull/8796#discussion_r582196549



##########
File path: modules/core/src/main/java/org/apache/ignite/mxbean/DataStorageMetricsMXBean.java
##########
@@ -19,12 +19,20 @@
 
 import org.apache.ignite.DataStorageMetrics;
 import org.apache.ignite.configuration.DataStorageConfiguration;
-import org.apache.ignite.internal.processors.metric.GridMetricManager;
+import org.apache.ignite.spi.metric.MetricExporterSpi;
+import org.apache.ignite.spi.metric.ReadOnlyMetricManager;
+import org.apache.ignite.spi.metric.ReadOnlyMetricRegistry;
+import org.apache.ignite.spi.metric.jmx.JmxMetricExporterSpi;
 
 /**
  * An MX bean allowing to monitor and tune persistence metrics.
  *
- * @deprecated Use {@link GridMetricManager} instead.
+ * @deprecated Check the {@link JmxMetricExporterSpi} instead.

Review comment:
       ```suggestion
    * @deprecated Check the {@link JmxMetricExporterSpi} "io.datastorage" instead.
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] nizhikov commented on a change in pull request #8796: IGNITE-14166 Fix public javadocs of metrics registry links

Posted by GitBox <gi...@apache.org>.
nizhikov commented on a change in pull request #8796:
URL: https://github.com/apache/ignite/pull/8796#discussion_r582189385



##########
File path: modules/core/src/main/java/org/apache/ignite/Ignite.java
##########
@@ -682,21 +683,21 @@ public IgniteLock reentrantLock(String name, boolean failoverSafe, boolean fair,
 
     /**
      * @return Collection of {@link MemoryMetrics} snapshots.
-     * @deprecated Use {@link #dataRegionMetrics()} instead.
+     * @deprecated Check the {@link ReadOnlyMetricRegistry} instead.

Review comment:
       ```suggestion
        * @deprecated Check the {@link ReadOnlyMetricRegistry} "io.dataregion.{data_region_name}" instead.
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] nizhikov commented on a change in pull request #8796: IGNITE-14166 Fix public javadocs of metrics registry links

Posted by GitBox <gi...@apache.org>.
nizhikov commented on a change in pull request #8796:
URL: https://github.com/apache/ignite/pull/8796#discussion_r582202249



##########
File path: modules/core/src/main/java/org/apache/ignite/internal/processors/jobmetrics/GridJobMetrics.java
##########
@@ -17,13 +17,21 @@
 
 package org.apache.ignite.internal.processors.jobmetrics;
 
-import org.apache.ignite.internal.processors.metric.GridMetricManager;
 import org.apache.ignite.internal.util.typedef.internal.S;
+import org.apache.ignite.spi.metric.MetricExporterSpi;
+import org.apache.ignite.spi.metric.ReadOnlyMetricManager;
+import org.apache.ignite.spi.metric.ReadOnlyMetricRegistry;
+import org.apache.ignite.spi.metric.jmx.JmxMetricExporterSpi;
 
 /**
  * Job metrics.
  *
- * @deprecated Use {@link GridMetricManager} instead.
+ * @deprecated Check the {@link ReadOnlyMetricRegistry} instead.

Review comment:
       ```suggestion
    * @deprecated Check the {@link ReadOnlyMetricRegistry} "compute.jobs" instead.
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] nizhikov commented on a change in pull request #8796: IGNITE-14166 Fix public javadocs of metrics registry links

Posted by GitBox <gi...@apache.org>.
nizhikov commented on a change in pull request #8796:
URL: https://github.com/apache/ignite/pull/8796#discussion_r582204579



##########
File path: modules/core/src/main/java/org/apache/ignite/mxbean/ThreadPoolMXBean.java
##########
@@ -17,12 +17,20 @@
 
 package org.apache.ignite.mxbean;
 
-import org.apache.ignite.internal.processors.metric.GridMetricManager;
+import org.apache.ignite.spi.metric.MetricExporterSpi;
+import org.apache.ignite.spi.metric.ReadOnlyMetricManager;
+import org.apache.ignite.spi.metric.ReadOnlyMetricRegistry;
+import org.apache.ignite.spi.metric.jmx.JmxMetricExporterSpi;
 
 /**
  * MBean that provides access to information about executor service.
  *
- * @deprecated Use {@link GridMetricManager} instead.
+ * @deprecated Check the {@link JmxMetricExporterSpi} instead.

Review comment:
       ```suggestion
    * @deprecated Check the {@link JmxMetricExporterSpi} "threadPools.{thread_pool_name}" instead.
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] nizhikov commented on a change in pull request #8796: IGNITE-14166 Fix public javadocs of metrics registry links

Posted by GitBox <gi...@apache.org>.
nizhikov commented on a change in pull request #8796:
URL: https://github.com/apache/ignite/pull/8796#discussion_r582205971



##########
File path: modules/core/src/main/java/org/apache/ignite/mxbean/TransactionMetricsMxBean.java
##########
@@ -18,13 +18,21 @@
 package org.apache.ignite.mxbean;
 
 import java.util.Map;
-import org.apache.ignite.internal.processors.metric.GridMetricManager;
+import org.apache.ignite.spi.metric.MetricExporterSpi;
+import org.apache.ignite.spi.metric.ReadOnlyMetricManager;
+import org.apache.ignite.spi.metric.ReadOnlyMetricRegistry;
+import org.apache.ignite.spi.metric.jmx.JmxMetricExporterSpi;
 import org.apache.ignite.transactions.TransactionMetrics;
 
 /**
  * Transactions MXBean interface.
  *
- * @deprecated Use {@link GridMetricManager} instead.
+ * @deprecated Check the {@link JmxMetricExporterSpi} instead.

Review comment:
       ```suggestion
    * @deprecated Check the {@link JmxMetricExporterSpi} "tx" instead.
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] nizhikov commented on a change in pull request #8796: IGNITE-14166 Fix public javadocs of metrics registry links

Posted by GitBox <gi...@apache.org>.
nizhikov commented on a change in pull request #8796:
URL: https://github.com/apache/ignite/pull/8796#discussion_r582202515



##########
File path: modules/core/src/main/java/org/apache/ignite/internal/processors/jobmetrics/GridJobMetricsProcessor.java
##########
@@ -23,17 +23,25 @@
 import org.apache.ignite.IgniteSystemProperties;
 import org.apache.ignite.internal.GridKernalContext;
 import org.apache.ignite.internal.processors.GridProcessorAdapter;
-import org.apache.ignite.internal.processors.metric.GridMetricManager;
 import org.apache.ignite.internal.util.typedef.X;
 import org.apache.ignite.internal.util.typedef.internal.U;
 import org.apache.ignite.lang.IgniteReducer;
+import org.apache.ignite.spi.metric.MetricExporterSpi;
+import org.apache.ignite.spi.metric.ReadOnlyMetricManager;
+import org.apache.ignite.spi.metric.ReadOnlyMetricRegistry;
+import org.apache.ignite.spi.metric.jmx.JmxMetricExporterSpi;
 
 import static org.apache.ignite.IgniteSystemProperties.IGNITE_JOBS_METRICS_CONCURRENCY_LEVEL;
 
 /**
  * Processes job metrics.
  *
- * @deprecated Use {@link GridMetricManager} instead.
+ * @deprecated Check the {@link ReadOnlyMetricRegistry} instead.

Review comment:
       ```suggestion
    * @deprecated Check the {@link ReadOnlyMetricRegistry} "compute.jobs" instead.
   ```

##########
File path: modules/core/src/main/java/org/apache/ignite/internal/processors/jobmetrics/GridJobMetricsSnapshot.java
##########
@@ -17,14 +17,22 @@
 
 package org.apache.ignite.internal.processors.jobmetrics;
 
-import org.apache.ignite.internal.processors.metric.GridMetricManager;
 import org.apache.ignite.internal.util.typedef.internal.S;
 import org.apache.ignite.internal.util.typedef.internal.U;
+import org.apache.ignite.spi.metric.MetricExporterSpi;
+import org.apache.ignite.spi.metric.ReadOnlyMetricManager;
+import org.apache.ignite.spi.metric.ReadOnlyMetricRegistry;
+import org.apache.ignite.spi.metric.jmx.JmxMetricExporterSpi;
 
 /**
  * Job metrics snapshot.
  *
- * @deprecated Use {@link GridMetricManager} instead.
+ * @deprecated Check the {@link ReadOnlyMetricRegistry} instead.

Review comment:
       ```suggestion
    * @deprecated Check the {@link ReadOnlyMetricRegistry} "compute.jobs" instead.
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] nizhikov commented on a change in pull request #8796: IGNITE-14166 Fix public javadocs of metrics registry links

Posted by GitBox <gi...@apache.org>.
nizhikov commented on a change in pull request #8796:
URL: https://github.com/apache/ignite/pull/8796#discussion_r582194774



##########
File path: modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/DataRegionMetricsMXBeanImpl.java
##########
@@ -18,13 +18,21 @@
 
 import org.apache.ignite.DataRegionMetrics;
 import org.apache.ignite.configuration.DataRegionConfiguration;
-import org.apache.ignite.internal.processors.metric.GridMetricManager;
 import org.apache.ignite.mxbean.DataRegionMetricsMXBean;
+import org.apache.ignite.spi.metric.MetricExporterSpi;
+import org.apache.ignite.spi.metric.ReadOnlyMetricManager;
+import org.apache.ignite.spi.metric.ReadOnlyMetricRegistry;
+import org.apache.ignite.spi.metric.jmx.JmxMetricExporterSpi;
 
 /**
  * MBean to expose {@link DataRegionMetrics} through JMX interface.
  *
- * @deprecated Use {@link GridMetricManager} instead.
+ * @deprecated Check the {@link JmxMetricExporterSpi} instead.

Review comment:
       ```suggestion
    * @deprecated Check the {@link JmxMetricExporterSpi} "io.dataregion.{data_region_name}" instead.
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] nizhikov commented on a change in pull request #8796: IGNITE-14166 Fix public javadocs of metrics registry links

Posted by GitBox <gi...@apache.org>.
nizhikov commented on a change in pull request #8796:
URL: https://github.com/apache/ignite/pull/8796#discussion_r582193097



##########
File path: modules/core/src/main/java/org/apache/ignite/internal/processors/cache/CacheGroupMetricsMXBeanImpl.java
##########
@@ -23,13 +23,21 @@
 import java.util.Map;
 import java.util.Set;
 import org.apache.ignite.cache.CacheMode;
-import org.apache.ignite.internal.processors.metric.GridMetricManager;
 import org.apache.ignite.mxbean.CacheGroupMetricsMXBean;
+import org.apache.ignite.spi.metric.MetricExporterSpi;
+import org.apache.ignite.spi.metric.ReadOnlyMetricManager;
+import org.apache.ignite.spi.metric.ReadOnlyMetricRegistry;
+import org.apache.ignite.spi.metric.jmx.JmxMetricExporterSpi;
 
 /**
  * Management bean that provides access to {@link CacheGroupContext}.
  *
- * @deprecated Use {@link GridMetricManager} instead.
+ * @deprecated Check the {@link JmxMetricExporterSpi} instead.

Review comment:
       ```suggestion
    * @deprecated Check the {@link JmxMetricExporterSpi} "cacheGroups.{cache_group_name}" instead.
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] nizhikov commented on a change in pull request #8796: IGNITE-14166 Fix public javadocs of metrics registry links

Posted by GitBox <gi...@apache.org>.
nizhikov commented on a change in pull request #8796:
URL: https://github.com/apache/ignite/pull/8796#discussion_r582196404



##########
File path: modules/core/src/main/java/org/apache/ignite/mxbean/DataRegionMetricsMXBean.java
##########
@@ -18,12 +18,20 @@
 
 import org.apache.ignite.DataRegionMetrics;
 import org.apache.ignite.configuration.DataRegionConfiguration;
-import org.apache.ignite.internal.processors.metric.GridMetricManager;
+import org.apache.ignite.spi.metric.MetricExporterSpi;
+import org.apache.ignite.spi.metric.ReadOnlyMetricManager;
+import org.apache.ignite.spi.metric.ReadOnlyMetricRegistry;
+import org.apache.ignite.spi.metric.jmx.JmxMetricExporterSpi;
 
 /**
  * This interface defines a JMX view on {@link DataRegionMetrics}.
  *
- * @deprecated Use {@link GridMetricManager} instead.
+ * @deprecated Check the {@link JmxMetricExporterSpi} instead.

Review comment:
       ```suggestion
    * @deprecated Check the {@link JmxMetricExporterSpi} "io.dataregion.{data_region_name}" instead.
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] nizhikov commented on a change in pull request #8796: IGNITE-14166 Fix public javadocs of metrics registry links

Posted by GitBox <gi...@apache.org>.
nizhikov commented on a change in pull request #8796:
URL: https://github.com/apache/ignite/pull/8796#discussion_r582192685



##########
File path: modules/core/src/main/java/org/apache/ignite/internal/TransactionMetricsMxBeanImpl.java
##########
@@ -18,14 +18,22 @@
 package org.apache.ignite.internal;
 
 import java.util.Map;
-import org.apache.ignite.internal.processors.metric.GridMetricManager;
 import org.apache.ignite.mxbean.TransactionMetricsMxBean;
+import org.apache.ignite.spi.metric.MetricExporterSpi;
+import org.apache.ignite.spi.metric.ReadOnlyMetricManager;
+import org.apache.ignite.spi.metric.ReadOnlyMetricRegistry;
+import org.apache.ignite.spi.metric.jmx.JmxMetricExporterSpi;
 import org.apache.ignite.transactions.TransactionMetrics;
 
 /**
  * Transactions MXBean implementation.
  *
- * @deprecated Use {@link GridMetricManager} instead.
+ * @deprecated Check the {@link ReadOnlyMetricRegistry} instead.

Review comment:
       ```suggestion
    * @deprecated Check the {@link ReadOnlyMetricRegistry} "tx" instead.
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] nizhikov commented on a change in pull request #8796: IGNITE-14166 Fix public javadocs of metrics registry links

Posted by GitBox <gi...@apache.org>.
nizhikov commented on a change in pull request #8796:
URL: https://github.com/apache/ignite/pull/8796#discussion_r582195739



##########
File path: modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/DataStorageMetricsSnapshot.java
##########
@@ -17,11 +17,19 @@
 package org.apache.ignite.internal.processors.cache.persistence;
 
 import org.apache.ignite.DataStorageMetrics;
-import org.apache.ignite.internal.processors.metric.GridMetricManager;
 import org.apache.ignite.internal.util.typedef.internal.S;
+import org.apache.ignite.spi.metric.MetricExporterSpi;
+import org.apache.ignite.spi.metric.ReadOnlyMetricManager;
+import org.apache.ignite.spi.metric.ReadOnlyMetricRegistry;
+import org.apache.ignite.spi.metric.jmx.JmxMetricExporterSpi;
 
 /**
- * @deprecated Use {@link GridMetricManager} instead.
+ * @deprecated Check the {@link ReadOnlyMetricRegistry} instead.

Review comment:
       ```suggestion
    * @deprecated Check the {@link ReadOnlyMetricRegistry} "io.datastorage" instead.
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] nizhikov commented on a change in pull request #8796: IGNITE-14166 Fix public javadocs of metrics registry links

Posted by GitBox <gi...@apache.org>.
nizhikov commented on a change in pull request #8796:
URL: https://github.com/apache/ignite/pull/8796#discussion_r582206980



##########
File path: modules/core/src/main/java/org/apache/ignite/IgniteSystemProperties.java
##########
@@ -493,7 +493,7 @@
      * concurrency level for structure holding job metrics snapshots.
      * Default value is {@code 64}.
      *
-     * @deprecated Use {@link GridMetricManager} instead.
+     * @deprecated Check the {@link ReadOnlyMetricRegistry} instead.

Review comment:
       ```suggestion
        * @deprecated Check the {@link ReadOnlyMetricRegistry} "compute.jobs" instead.
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] nizhikov commented on a change in pull request #8796: IGNITE-14166 Fix public javadocs of metrics registry links

Posted by GitBox <gi...@apache.org>.
nizhikov commented on a change in pull request #8796:
URL: https://github.com/apache/ignite/pull/8796#discussion_r582189603



##########
File path: modules/core/src/main/java/org/apache/ignite/Ignite.java
##########
@@ -682,21 +683,21 @@ public IgniteLock reentrantLock(String name, boolean failoverSafe, boolean fair,
 
     /**
      * @return Collection of {@link MemoryMetrics} snapshots.
-     * @deprecated Use {@link #dataRegionMetrics()} instead.
+     * @deprecated Check the {@link ReadOnlyMetricRegistry} instead.
      */
     @Deprecated
     public Collection<MemoryMetrics> memoryMetrics();
 
     /**
      * @return {@link MemoryMetrics} snapshot or {@code null} if no memory region is configured under specified name.
-     * @deprecated Use {@link #dataRegionMetrics(String)} instead.
+     * @deprecated Check the {@link ReadOnlyMetricRegistry} instead.

Review comment:
       ```suggestion
        * @deprecated Check the {@link ReadOnlyMetricRegistry} "io.dataregion.{data_region_name}" instead.
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] nizhikov commented on a change in pull request #8796: IGNITE-14166 Fix public javadocs of metrics registry links

Posted by GitBox <gi...@apache.org>.
nizhikov commented on a change in pull request #8796:
URL: https://github.com/apache/ignite/pull/8796#discussion_r582189774



##########
File path: modules/core/src/main/java/org/apache/ignite/Ignite.java
##########
@@ -682,21 +683,21 @@ public IgniteLock reentrantLock(String name, boolean failoverSafe, boolean fair,
 
     /**
      * @return Collection of {@link MemoryMetrics} snapshots.
-     * @deprecated Use {@link #dataRegionMetrics()} instead.
+     * @deprecated Check the {@link ReadOnlyMetricRegistry} instead.
      */
     @Deprecated
     public Collection<MemoryMetrics> memoryMetrics();
 
     /**
      * @return {@link MemoryMetrics} snapshot or {@code null} if no memory region is configured under specified name.
-     * @deprecated Use {@link #dataRegionMetrics(String)} instead.
+     * @deprecated Check the {@link ReadOnlyMetricRegistry} instead.
      */
     @Deprecated
     @Nullable public MemoryMetrics memoryMetrics(String memPlcName);
 
     /**
      * @return {@link PersistenceMetrics} snapshot.
-     * @deprecated Use {@link #dataStorageMetrics()} instead.
+     * @deprecated Check the {@link ReadOnlyMetricRegistry} instead.

Review comment:
       ```suggestion
        * @deprecated Check the {@link ReadOnlyMetricRegistry} "io.dataregion.{data_region_name}" instead.
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org