You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2017/12/21 22:19:23 UTC

Re: Review Request 62287: Added Log::Reader::catchup() method.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62287/#review194371
-----------------------------------------------------------


Ship it!




Ship It!

- Jie Yu


On Oct. 5, 2017, 8:05 p.m., Ilya Pronin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62287/
> -----------------------------------------------------------
> 
> (Updated Oct. 5, 2017, 8:05 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-7973
>     https://issues.apache.org/jira/browse/MESOS-7973
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The new method catches-up positions missing in the local non-leading
> replica to allow safe eventually consistent reads from it.
> 
> 
> Diffs
> -----
> 
>   include/mesos/log/log.hpp d92d7a0b982c1c4bc0fdedde19fe012a6523a224 
>   src/log/log.hpp 24481aaae145301e7a8ea1c91b1c16e48ded4843 
>   src/log/log.cpp dcb66f7dd5da5059925b7b731e83f7320f645030 
>   src/tests/log_tests.cpp f9f9400c901152779ae0ebfe74cf8f7aac1d3396 
> 
> 
> Diff: https://reviews.apache.org/r/62287/diff/2/
> 
> 
> Testing
> -------
> 
> Added a test that verifies that it's possible to catch-up the lagging replica using the `Reader` and successfully read entries that were caught-up. Ran `make check`.
> 
> 
> Thanks,
> 
> Ilya Pronin
> 
>