You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2017/09/06 20:34:47 UTC
[kudu-CR] test workload: make table creation more robust
Hello Todd Lipcon, Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/7982
to review the following change.
Change subject: test_workload: make table creation more robust
......................................................................
test_workload: make table creation more robust
The table creation here already works around the lack of Exactly Once
semantics by considering certain kinds of failures to mean success. However,
these failures imply that the client didn't finish waiting for the table to
be created, so we need to do that ourselves.
Change-Id: Ic1e76e502359b499466cfa90d21ac22f35928261
---
M src/kudu/integration-tests/test_workload.cc
1 file changed, 19 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/82/7982/1
--
To view, visit http://gerrit.cloudera.org:8080/7982
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic1e76e502359b499466cfa90d21ac22f35928261
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] test workload: make table creation more robust
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change.
Change subject: test_workload: make table creation more robust
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/7982
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1e76e502359b499466cfa90d21ac22f35928261
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] test workload: make table creation more robust
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged.
Change subject: test_workload: make table creation more robust
......................................................................
test_workload: make table creation more robust
The table creation here already works around the lack of Exactly Once
semantics by considering certain kinds of failures to mean success. However,
these failures imply that the client didn't finish waiting for the table to
be created, so we need to do that ourselves.
Without the patch, ClientStressTest_MultiMaster.TestLeaderResolutionTimeout
failed 1/1000 times in DEBUG mode. With it, there were no failures.
Change-Id: Ic1e76e502359b499466cfa90d21ac22f35928261
Reviewed-on: http://gerrit.cloudera.org:8080/7982
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Hao Hao <ha...@cloudera.com>
---
M src/kudu/integration-tests/test_workload.cc
1 file changed, 20 insertions(+), 3 deletions(-)
Approvals:
Hao Hao: Looks good to me, but someone else must approve
Alexey Serbin: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/7982
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic1e76e502359b499466cfa90d21ac22f35928261
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] test workload: make table creation more robust
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: test_workload: make table creation more robust
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7982
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1e76e502359b499466cfa90d21ac22f35928261
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] test workload: make table creation more robust
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has uploaded a new patch set (#2).
Change subject: test_workload: make table creation more robust
......................................................................
test_workload: make table creation more robust
The table creation here already works around the lack of Exactly Once
semantics by considering certain kinds of failures to mean success. However,
these failures imply that the client didn't finish waiting for the table to
be created, so we need to do that ourselves.
Without the patch, ClientStressTest_MultiMaster.TestLeaderResolutionTimeout
failed 1/1000 times in DEBUG mode. With it, there were no failures.
Change-Id: Ic1e76e502359b499466cfa90d21ac22f35928261
---
M src/kudu/integration-tests/test_workload.cc
1 file changed, 20 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/82/7982/2
--
To view, visit http://gerrit.cloudera.org:8080/7982
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic1e76e502359b499466cfa90d21ac22f35928261
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>