You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by John Kordich via Review Board <no...@reviews.apache.org> on 2018/06/05 19:09:22 UTC
Review Request 67454: Fixed failing ArchiverTest due to long filename.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67454/
-----------------------------------------------------------
Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Chun-Hung Hsiao, Eric Mumau, Jie Yu, Joseph Wu, Li Li, and Radhika Jandhyala.
Bugs: MESOS-8977
https://issues.apache.org/jira/browse/MESOS-8977
Repository: mesos
Description
-------
Replaced most of the ArchiverTest.ExtractZipFileWithLongDestinationDir
test such that it constructs a long path similar to how it is done in
filesystem_tests.cpp. This resolves a failure in the jenkins BuildBot
job that runs all of the tests inside a docker container, which uses a
filesystem called AUFS, which has an individual file name limit of 242
characters.
Diffs
-----
3rdparty/stout/tests/archiver_tests.cpp fc8db56897ba7e5881a8af27da11c1d21c835b94
Diff: https://reviews.apache.org/r/67454/diff/1/
Testing
-------
I ran the cmake build on both Linux and Windows and verified the tests pass. I was not able to run the tests inside a docker container, but considering the changes made, I would be very surprised if it failed in the same way because we are no longer creating a filename with greater than 242 characters.
Thanks,
John Kordich
Re: Review Request 67454: Fixed failing ArchiverTest due to long
filename.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67454/#review204343
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['67454']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67454
Relevant logs:
- [stout-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67454/logs/stout-tests-stdout.log):
```
[ RUN ] SocketTests.InitSocket
[ OK ] SocketTests.InitSocket (2 ms)
[ RUN ] SocketTests.IntFD
[ OK ] SocketTests.IntFD (1 ms)
[----------] 2 tests from SocketTests (5 ms total)
[----------] 2 tests from StrerrorTest
[ RUN ] StrerrorTest.ValidErrno
[ OK ] StrerrorTest.ValidErrno (0 ms)
[ RUN ] StrerrorTest.InvalidErrno
[ OK ] StrerrorTest.InvalidErrno (0 ms)
[----------] 2 tests from StrerrorTest (2 ms total)
[----------] 2 tests from OsSendfileTest
[ RUN ] OsSendfileTest.Sendfile
[ OK ] OsSendfileTest.Sendfile (1219 ms)
[ RUN ] OsSendfileTest.SendfileAsync
[ OK ] OsSendfileTest.SendfileAsync (18 ms)
[----------] 2 tests from OsSendfileTest (1240 ms total)
[----------] Global test environment tear-down
[==========] 321 tests from 49 test cases ran. (5907 ms total)
[ PASSED ] 318 tests.
[ FAILED ] 3 tests, listed below:
[ FAILED ] ArchiverTest.ExtractTarXZFile
[ FAILED ] ArchiverTest.ExtractTarBZ2File
[ FAILED ] ArchiverTest.ExtractTarBz2GzFile
3 FAILED TESTS
```
- [stout-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67454/logs/stout-tests-stderr.log):
```
'invalid.command' is not recognized as an internal or external command,
operable program or batch file.
Subcommand 'subcommand' is not available
Usage: command <subcommand> [OPTIONS]
Available subcommands:
help
subcommand2
Multiple subcommands have name 'subcommand'
```
- Mesos Reviewbot Windows
On June 5, 2018, 7:09 p.m., John Kordich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67454/
> -----------------------------------------------------------
>
> (Updated June 5, 2018, 7:09 p.m.)
>
>
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Chun-Hung Hsiao, Eric Mumau, Jie Yu, Joseph Wu, Li Li, and Radhika Jandhyala.
>
>
> Bugs: MESOS-8977
> https://issues.apache.org/jira/browse/MESOS-8977
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Replaced most of the ArchiverTest.ExtractZipFileWithLongDestinationDir
> test such that it constructs a long path similar to how it is done in
> filesystem_tests.cpp. This resolves a failure in the jenkins BuildBot
> job that runs all of the tests inside a docker container, which uses a
> filesystem called AUFS, which has an individual file name limit of 242
> characters.
>
>
> Diffs
> -----
>
> 3rdparty/stout/tests/archiver_tests.cpp fc8db56897ba7e5881a8af27da11c1d21c835b94
>
>
> Diff: https://reviews.apache.org/r/67454/diff/1/
>
>
> Testing
> -------
>
> I ran the cmake build on both Linux and Windows and verified the tests pass. I was not able to run the tests inside a docker container, but considering the changes made, I would be very surprised if it failed in the same way because we are no longer creating a filename with greater than 242 characters.
>
>
> Thanks,
>
> John Kordich
>
>
Re: Review Request 67454: Fixed failing ArchiverTest due to long
filename.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67454/#review204341
-----------------------------------------------------------
Ship it!
Ship It!
- Joseph Wu
On June 5, 2018, 12:09 p.m., John Kordich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67454/
> -----------------------------------------------------------
>
> (Updated June 5, 2018, 12:09 p.m.)
>
>
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Chun-Hung Hsiao, Eric Mumau, Jie Yu, Joseph Wu, Li Li, and Radhika Jandhyala.
>
>
> Bugs: MESOS-8977
> https://issues.apache.org/jira/browse/MESOS-8977
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Replaced most of the ArchiverTest.ExtractZipFileWithLongDestinationDir
> test such that it constructs a long path similar to how it is done in
> filesystem_tests.cpp. This resolves a failure in the jenkins BuildBot
> job that runs all of the tests inside a docker container, which uses a
> filesystem called AUFS, which has an individual file name limit of 242
> characters.
>
>
> Diffs
> -----
>
> 3rdparty/stout/tests/archiver_tests.cpp fc8db56897ba7e5881a8af27da11c1d21c835b94
>
>
> Diff: https://reviews.apache.org/r/67454/diff/1/
>
>
> Testing
> -------
>
> I ran the cmake build on both Linux and Windows and verified the tests pass. I was not able to run the tests inside a docker container, but considering the changes made, I would be very surprised if it failed in the same way because we are no longer creating a filename with greater than 242 characters.
>
>
> Thanks,
>
> John Kordich
>
>