You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Apoorv Naik <na...@gmail.com> on 2017/09/26 19:17:51 UTC
Review Request 62585: ATLAS-2179: Split Atlas client library to avoid
unnecessary dependencies
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62585/
-----------------------------------------------------------
Review request for atlas and Madhan Neethiraj.
Bugs: ATLAS-2179
https://issues.apache.org/jira/browse/ATLAS-2179
Repository: atlas
Description
-------
Split client library into V1 and V2 artifacts for lighter JARs
Diffs
-----
authorization/src/main/java/org/apache/atlas/authorize/simple/PolicyParser.java fc611c8a
client/common/pom.xml PRE-CREATION
client/pom.xml 9d411760
client/src/main/assembly/all-jar.xml PRE-CREATION
client/src/main/java/org/apache/atlas/AtlasAdminClient.java
client/src/main/java/org/apache/atlas/AtlasBaseClient.java 602831a2
client/src/main/java/org/apache/atlas/AtlasClient.java 5fa5df79
client/src/main/java/org/apache/atlas/AtlasClientV2.java 2cb9e84b
client/src/main/java/org/apache/atlas/AtlasServerEnsemble.java
client/src/main/java/org/apache/atlas/AtlasServiceException.java b128f982
client/src/main/java/org/apache/atlas/CreateUpdateEntitiesResult.java
client/src/main/java/org/apache/atlas/EntityAuditEvent.java
client/src/main/java/org/apache/atlas/ResourceCreator.java
client/src/main/java/org/apache/atlas/SerDe.java
client/src/main/java/org/apache/atlas/security/SecureClientUtils.java
client/src/test/java/org/apache/atlas/AtlasClientTest.java c33906ac
client/v1-client/pom.xml PRE-CREATION
client/v2-client/pom.xml PRE-CREATION
common/pom.xml 7178bfa6
common/src/main/java/org/apache/atlas/ApplicationProperties.java
common/src/main/java/org/apache/atlas/AtlasException.java
common/src/main/java/org/apache/atlas/groovy/ArithmeticExpression.java a6e1689c
common/src/main/java/org/apache/atlas/security/InMemoryJAASConfiguration.java
common/src/main/java/org/apache/atlas/security/SecurityProperties.java
common/src/main/java/org/apache/atlas/utils/AuthenticationUtil.java
common/src/test/java/org/apache/atlas/ApplicationPropertiesTest.java
common/src/test/java/org/apache/atlas/security/InMemoryJAASConfigurationTest.java
common/src/test/java/org/apache/atlas/security/InMemoryJAASConfigurationTicketBasedKafkaClientTest.java
intg/src/test/resources/atlas-jaas.properties PRE-CREATION
intg/src/test/resources/test.properties PRE-CREATION
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java ad88c1b3
Diff: https://reviews.apache.org/r/62585/diff/1/
Testing
-------
compile goes through fine
mvn clean package also goes through fine
Thanks,
Apoorv Naik
Re: Review Request 62585: ATLAS-2179: Split Atlas client library to
avoid unnecessary dependencies
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62585/#review186315
-----------------------------------------------------------
Fix it, then Ship it!
client/common/pom.xml
Lines 25 (patched)
<https://reviews.apache.org/r/62585/#comment262809>
0.9-SNAPSHOT ==> 1.0.0-SNAPSHOT
client/src/main/java/org/apache/atlas/AtlasBaseClient.java
Line 62 (original), 67 (patched)
<https://reviews.apache.org/r/62585/#comment262813>
Consider avoiding references to API_V1 and API_V2 in 'common'; instead use the interface API.
Consider one of the following approaches to get API object in AtlasBaseClient:
1) Abstract methods:
- protected abstract API getVersionAPI();
- protected abstract API getStatusAPI();
- protected abstract API getMetricsAPI();
2)Have the implementations pass API references vi AtlasBaseClient constructor:
- protected AtlasBaseClient(API version, API status, API metrics);
client/v1-client/pom.xml
Lines 25 (patched)
<https://reviews.apache.org/r/62585/#comment262810>
0.9-SNAPSHOT ==> 1.0.0-SNAPSHOT
client/v2-client/pom.xml
Lines 25 (patched)
<https://reviews.apache.org/r/62585/#comment262812>
0.9-SNAPSHOT ==> 1.0.0-SNAPSHOT
- Madhan Neethiraj
On Sept. 26, 2017, 7:17 p.m., Apoorv Naik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62585/
> -----------------------------------------------------------
>
> (Updated Sept. 26, 2017, 7:17 p.m.)
>
>
> Review request for atlas and Madhan Neethiraj.
>
>
> Bugs: ATLAS-2179
> https://issues.apache.org/jira/browse/ATLAS-2179
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Split client library into V1 and V2 artifacts for lighter JARs
>
>
> Diffs
> -----
>
> authorization/src/main/java/org/apache/atlas/authorize/simple/PolicyParser.java fc611c8a
> client/common/pom.xml PRE-CREATION
> client/pom.xml 9d411760
> client/src/main/assembly/all-jar.xml PRE-CREATION
> client/src/main/java/org/apache/atlas/AtlasAdminClient.java
> client/src/main/java/org/apache/atlas/AtlasBaseClient.java 602831a2
> client/src/main/java/org/apache/atlas/AtlasClient.java 5fa5df79
> client/src/main/java/org/apache/atlas/AtlasClientV2.java 2cb9e84b
> client/src/main/java/org/apache/atlas/AtlasServerEnsemble.java
> client/src/main/java/org/apache/atlas/AtlasServiceException.java b128f982
> client/src/main/java/org/apache/atlas/CreateUpdateEntitiesResult.java
> client/src/main/java/org/apache/atlas/EntityAuditEvent.java
> client/src/main/java/org/apache/atlas/ResourceCreator.java
> client/src/main/java/org/apache/atlas/SerDe.java
> client/src/main/java/org/apache/atlas/security/SecureClientUtils.java
> client/src/test/java/org/apache/atlas/AtlasClientTest.java c33906ac
> client/v1-client/pom.xml PRE-CREATION
> client/v2-client/pom.xml PRE-CREATION
> common/pom.xml 7178bfa6
> common/src/main/java/org/apache/atlas/ApplicationProperties.java
> common/src/main/java/org/apache/atlas/AtlasException.java
> common/src/main/java/org/apache/atlas/groovy/ArithmeticExpression.java a6e1689c
> common/src/main/java/org/apache/atlas/security/InMemoryJAASConfiguration.java
> common/src/main/java/org/apache/atlas/security/SecurityProperties.java
> common/src/main/java/org/apache/atlas/utils/AuthenticationUtil.java
> common/src/test/java/org/apache/atlas/ApplicationPropertiesTest.java
> common/src/test/java/org/apache/atlas/security/InMemoryJAASConfigurationTest.java
> common/src/test/java/org/apache/atlas/security/InMemoryJAASConfigurationTicketBasedKafkaClientTest.java
> intg/src/test/resources/atlas-jaas.properties PRE-CREATION
> intg/src/test/resources/test.properties PRE-CREATION
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java ad88c1b3
>
>
> Diff: https://reviews.apache.org/r/62585/diff/1/
>
>
> Testing
> -------
>
> compile goes through fine
> mvn clean package also goes through fine
>
>
> Thanks,
>
> Apoorv Naik
>
>
Re: Review Request 62585: ATLAS-2179: Split Atlas client library to
avoid unnecessary dependencies
Posted by Apoorv Naik <na...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62585/
-----------------------------------------------------------
(Updated Sept. 27, 2017, 2:36 a.m.)
Review request for atlas and Madhan Neethiraj.
Changes
-------
Reverted unwanted changes
Bugs: ATLAS-2179
https://issues.apache.org/jira/browse/ATLAS-2179
Repository: atlas
Description
-------
Split client library into V1 and V2 artifacts for lighter JARs
Diffs (updated)
-----
addons/falcon-bridge/pom.xml f0e668fb
addons/hdfs-model/pom.xml fe784422
addons/hive-bridge/pom.xml d16fde76
addons/sqoop-bridge/pom.xml c866f16a
addons/storm-bridge/pom.xml 87266815
authorization/pom.xml bc0882b2
authorization/src/main/java/org/apache/atlas/authorize/simple/AtlasAuthorizationUtils.java d67376fa
authorization/src/main/java/org/apache/atlas/authorize/simple/PolicyParser.java fc611c8a
client/common/pom.xml PRE-CREATION
client/pom.xml 9d411760
client/src/main/assembly/all-jar.xml PRE-CREATION
client/src/main/java/org/apache/atlas/AtlasAdminClient.java
client/src/main/java/org/apache/atlas/AtlasBaseClient.java 602831a2
client/src/main/java/org/apache/atlas/AtlasClient.java 5fa5df79
client/src/main/java/org/apache/atlas/AtlasClientV2.java 2cb9e84b
client/src/main/java/org/apache/atlas/AtlasServerEnsemble.java
client/src/main/java/org/apache/atlas/AtlasServiceException.java b128f982
client/src/main/java/org/apache/atlas/CreateUpdateEntitiesResult.java
client/src/main/java/org/apache/atlas/EntityAuditEvent.java
client/src/main/java/org/apache/atlas/ResourceCreator.java
client/src/main/java/org/apache/atlas/SerDe.java
client/src/main/java/org/apache/atlas/security/SecureClientUtils.java
client/src/test/java/org/apache/atlas/AtlasClientTest.java c33906ac
client/v1-client/pom.xml PRE-CREATION
client/v2-client/pom.xml PRE-CREATION
common/pom.xml 7178bfa6
common/src/main/java/org/apache/atlas/ApplicationProperties.java
common/src/main/java/org/apache/atlas/AtlasException.java
common/src/main/java/org/apache/atlas/groovy/ArithmeticExpression.java a6e1689c
common/src/main/java/org/apache/atlas/security/InMemoryJAASConfiguration.java
common/src/main/java/org/apache/atlas/security/SecurityProperties.java
common/src/main/java/org/apache/atlas/utils/AuthenticationUtil.java
common/src/test/java/org/apache/atlas/ApplicationPropertiesTest.java
common/src/test/java/org/apache/atlas/security/InMemoryJAASConfigurationTest.java
common/src/test/java/org/apache/atlas/security/InMemoryJAASConfigurationTicketBasedKafkaClientTest.java
intg/src/test/resources/atlas-jaas.properties PRE-CREATION
intg/src/test/resources/test.properties PRE-CREATION
notification/pom.xml 192a3fc7
pom.xml 684535a6
repository/pom.xml 4252751d
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java ad88c1b3
repository/src/test/java/org/apache/atlas/TestUtils.java 48912793
repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteTestBase.java 0e220803
server-api/pom.xml 05e5eec7
webapp/pom.xml 8d03af7a
webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java 858b3200
webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 711cc04d
webapp/src/test/java/org/apache/atlas/web/integration/AdminJerseyResourceIT.java cfe09d6f
webapp/src/test/java/org/apache/atlas/web/integration/DataSetLineageJerseyResourceIT.java 8c6ba775
webapp/src/test/java/org/apache/atlas/web/integration/EntityJerseyResourceIT.java ba5465d3
webapp/src/test/java/org/apache/atlas/web/integration/EntityLineageJerseyResourceIT.java 55c56c21
webapp/src/test/java/org/apache/atlas/web/integration/MetadataDiscoveryJerseyResourceIT.java 3fa85b18
webapp/src/test/java/org/apache/atlas/web/integration/TypesJerseyResourceIT.java 54db3c0c
Diff: https://reviews.apache.org/r/62585/diff/3/
Changes: https://reviews.apache.org/r/62585/diff/2-3/
Testing
-------
compile goes through fine
mvn clean package also goes through fine
QuickStart ran successfully
Thanks,
Apoorv Naik
Re: Review Request 62585: ATLAS-2179: Split Atlas client library to
avoid unnecessary dependencies
Posted by Apoorv Naik <na...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62585/
-----------------------------------------------------------
(Updated Sept. 26, 2017, 10:53 p.m.)
Review request for atlas and Madhan Neethiraj.
Changes
-------
Updated various POMs after version update to 1.0.0-SNAPSHOT, some more code refactoring around the base client
Bugs: ATLAS-2179
https://issues.apache.org/jira/browse/ATLAS-2179
Repository: atlas
Description
-------
Split client library into V1 and V2 artifacts for lighter JARs
Diffs (updated)
-----
addons/falcon-bridge/pom.xml f0e668fb
addons/hdfs-model/pom.xml fe784422
addons/hive-bridge/pom.xml d16fde76
addons/sqoop-bridge/pom.xml c866f16a
addons/storm-bridge/pom.xml 87266815
authorization/pom.xml bc0882b2
authorization/src/main/java/org/apache/atlas/authorize/simple/AtlasAuthorizationUtils.java d67376fa
authorization/src/main/java/org/apache/atlas/authorize/simple/PolicyParser.java fc611c8a
client/common/pom.xml PRE-CREATION
client/pom.xml 9d411760
client/src/main/assembly/all-jar.xml PRE-CREATION
client/src/main/java/org/apache/atlas/AtlasAdminClient.java
client/src/main/java/org/apache/atlas/AtlasBaseClient.java 602831a2
client/src/main/java/org/apache/atlas/AtlasClient.java 5fa5df79
client/src/main/java/org/apache/atlas/AtlasClientV2.java 2cb9e84b
client/src/main/java/org/apache/atlas/AtlasServerEnsemble.java
client/src/main/java/org/apache/atlas/AtlasServiceException.java b128f982
client/src/main/java/org/apache/atlas/CreateUpdateEntitiesResult.java
client/src/main/java/org/apache/atlas/EntityAuditEvent.java
client/src/main/java/org/apache/atlas/ResourceCreator.java
client/src/main/java/org/apache/atlas/SerDe.java
client/src/main/java/org/apache/atlas/security/SecureClientUtils.java
client/src/test/java/org/apache/atlas/AtlasClientTest.java c33906ac
client/v1-client/pom.xml PRE-CREATION
client/v2-client/pom.xml PRE-CREATION
common/pom.xml 7178bfa6
common/src/main/java/org/apache/atlas/ApplicationProperties.java
common/src/main/java/org/apache/atlas/AtlasException.java
common/src/main/java/org/apache/atlas/groovy/ArithmeticExpression.java a6e1689c
common/src/main/java/org/apache/atlas/security/InMemoryJAASConfiguration.java
common/src/main/java/org/apache/atlas/security/SecurityProperties.java
common/src/main/java/org/apache/atlas/utils/AuthenticationUtil.java
common/src/test/java/org/apache/atlas/ApplicationPropertiesTest.java
common/src/test/java/org/apache/atlas/security/InMemoryJAASConfigurationTest.java
common/src/test/java/org/apache/atlas/security/InMemoryJAASConfigurationTicketBasedKafkaClientTest.java
intg/src/test/resources/atlas-jaas.properties PRE-CREATION
intg/src/test/resources/test.properties PRE-CREATION
notification/pom.xml 192a3fc7
pom.xml 684535a6
repository/pom.xml 4252751d
repository/src/main/java/org/apache/atlas/repository/converters/AtlasInstanceConverter.java 3426ae51
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java 50b71167
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java ad88c1b3
repository/src/test/java/org/apache/atlas/TestUtils.java 48912793
repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteTestBase.java 0e220803
repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryTest.java d4c250cc
repository/src/test/java/org/apache/atlas/repository/graph/ReverseReferenceUpdateTestBase.java 26dc6a82
repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java e93f08d6
server-api/pom.xml 05e5eec7
server-api/src/main/java/org/apache/atlas/services/MetadataService.java 7fb3d3f6
typesystem/src/test/resources/atlas-application.properties 65dd9a31
webapp/pom.xml 8d03af7a
webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java 858b3200
webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 711cc04d
webapp/src/test/java/org/apache/atlas/web/integration/AdminJerseyResourceIT.java cfe09d6f
webapp/src/test/java/org/apache/atlas/web/integration/DataSetLineageJerseyResourceIT.java 8c6ba775
webapp/src/test/java/org/apache/atlas/web/integration/EntityJerseyResourceIT.java ba5465d3
webapp/src/test/java/org/apache/atlas/web/integration/EntityLineageJerseyResourceIT.java 55c56c21
webapp/src/test/java/org/apache/atlas/web/integration/MetadataDiscoveryJerseyResourceIT.java 3fa85b18
webapp/src/test/java/org/apache/atlas/web/integration/TypesJerseyResourceIT.java 54db3c0c
Diff: https://reviews.apache.org/r/62585/diff/2/
Changes: https://reviews.apache.org/r/62585/diff/1-2/
Testing (updated)
-------
compile goes through fine
mvn clean package also goes through fine
QuickStart ran successfully
Thanks,
Apoorv Naik