[GitHub] [ozone] captainzmc commented on a change in pull request #2574: HDDS-5666. Add option to createKey via streaming api in Freon

[GitBox <gi...@apache.org>]

captainzmc commented on a change in pull request #2574:
URL: https://github.com/apache/ozone/pull/2574#discussion_r815788664



##########
File path: hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/ContentGenerator.java
##########
@@ -80,6 +82,22 @@ public void write(OutputStream outputStream) throws IOException {
     }
   }
 
+  /**
+   * Write the required bytes to the output stream.

Review comment:
       `Write the required bytes to the streaming output stream.`

##########
File path: hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/OzoneClientKeyGenerator.java
##########
@@ -93,6 +103,9 @@ public Void call() throws Exception {
 
     contentGenerator = new ContentGenerator(keySize, bufferSize);
     metadata = new HashMap<>();
+    replicationConfig = ReplicationConfig

Review comment:
       This line will conflict with [the patch of EC](https://github.com/apache/ozone/pull/2996/files#diff-28399319a85aa26781a7ab36e4ae8232b086656016e76071edad5ed8b3b6430eR117). EC is currently voting on merge to master, so EC will merge into master before streaming.  So can we continue this PR after EC merge?
   

##########
File path: hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/OzoneClientKeyGenerator.java
##########
@@ -78,11 +81,18 @@
   )
   private String omServiceID = null;
 
+  @Option(
+      names = {"--enable_streaming", "--stream"},

Review comment:
       `names = {"--enable-streaming", "--stream"},`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org