You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/10/03 04:24:58 UTC
[GitHub] [incubator-superset] etr2460 opened a new pull request #11150: Revert "refactor: Remove usages of reactable from TimeTable"
etr2460 opened a new pull request #11150:
URL: https://github.com/apache/incubator-superset/pull/11150
Reverts apache/incubator-superset#11046
Fixes: https://github.com/apache/incubator-superset/issues/11142
This is a significant data quality issue where filters are shown as applying to the chart, but not applied to the query itself. therefore reverting from master seems prudent
to: @michellethomas @rusackas @john-bodley
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 merged pull request #11150: fix: Revert "refactor: Remove usages of reactable from TimeTable"
Posted by GitBox <gi...@apache.org>.
etr2460 merged pull request #11150:
URL: https://github.com/apache/incubator-superset/pull/11150
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on pull request #11150: fix: Revert "refactor: Remove usages of reactable from TimeTable"
Posted by GitBox <gi...@apache.org>.
etr2460 commented on pull request #11150:
URL: https://github.com/apache/incubator-superset/pull/11150#issuecomment-703045386
Thanks for the quick review! I don't think it'll be a hard fix, but I always prefer to keep master in a stable shape as often as possible
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org